[U-Boot] [PATCH v2 2/8] sf: spansion: Add support for S25FL128S_64K

[U-Boot] [PATCH v2 2/8] sf: spansion: Add support for S25FL128S_64K

[Baudouin, Charles]

I think the correct thing to do here is to set the flash up for uniform sector size of 64Kbytes.

CR3V[3] = 1

If I can get the code to work I will send up the updates for uboot.



Charles Baudouin
Research and Development Manager
Domo Tactical Communications
E: Charles.Baudouin at domotactical.com
T: +44 1489 884 430
M: +44 7973 146 671

DTC - Website<http://www.domotactical.com/>
DTC - Linkedin<https://www.linkedin.com/company/domo-tactical-communications-dtc-ltd>
DTC - Twitter<https://twitter.com/DomoBroadcast>
DTC - YouTube<https://www.youtube.com/channel/UC0nBUhsZ9iakjODp9nYRDSw/featured>

Domo Tactical Communications (DTC) LTD trading as DTC, Fusion 2, 1100 Parkway, Whiteley, Hampshire, PO15 7AB, United Kingdom. +44 (0) 1489 566750. www.domotactical.com<http://www.domotactical.com>

Registered office Fusion 2, 1100 Parkway, Solent Business Park, Whiteley, Hampshire, PO15 7AB. Registered in England and Wales, company number 1456922.

Please consider the environment before printing this email.

This e-mail and any files transmitted with it ("E-mail") is intended solely for the addressee(s) and may contain information that is proprietary, privileged, company confidential and/or exempt from disclosure under applicable law. If you are not the intended addressee(s), any disclosure, reproduction, copying, distribution or other use of the E-mail is strictly prohibited. It may also contain data subject to the International Traffic in Arms Regulations or United States Export Administration Regulations, particularly if this E-mail has been transmitted from a United States location, and cannot be disseminated, distributed or copied to foreign nationals, residing in the United States or abroad, without the prior approval of the U.S. Department of State or appropriate export licensing authority. If you have received this E-mail in error, please delete it and destroy all copies of this E-mail and notify the sender immediately via telephone call or return e-mail.

Neither the company nor any subsidiary or affiliate or associated company nor any individual sending this E-mail accepts any liability in respect of the content (including errors and omissions) nor shall this e-mail be deemed to enter the company or any subsidiary or affiliate or associated company into a contract or to create any legally binding obligations unless expressly agreed to in writing under separate cover and timeliness of the E-mail which arise as a result of transmission. If verification is required, please request a hard copy version from the sender.

[U-Boot] [PATCH v2 2/8] sf: spansion: Add support for S25FL128S_64K

[Jagan Teki]

On Thu, May 30, 2013 at 7:19 PM, Jagannadha Sutradharudu Teki
<jagannadha.sutradharudu-teki@xilinx.com> wrote:
> This commit is based on the patch from Xie Xiaobo <X.Xie@freescale.com>
> with commit head title as "sf: spansion: Add support for S25FL128S".
> pulled the same code changes into current u-boot tree with little update
> on the name field.
>
> http://patchwork.ozlabs.org/patch/218145/
>
> SPANSION recommend S25FL128S supersedes S25FL129P, and the two flash
> memory have the same device ID and Memory architecture. So they can
> use the same config parameters.
>
> Signed-off-by: Xie Xiaobo <X.Xie@freescale.com>
> Signed-off-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
> ---
> Changes for v2:
>         - none
>
>  drivers/mtd/spi/spansion.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi/spansion.c b/drivers/mtd/spi/spansion.c
> index 2218e2f..dad4fbb 100644
> --- a/drivers/mtd/spi/spansion.c
> +++ b/drivers/mtd/spi/spansion.c
> @@ -101,7 +101,7 @@ static const struct spansion_spi_flash_params spansion_spi_flash_table[] = {
>                 .idcode2 = 0x4d01,
>                 .pages_per_sector = 256,
>                 .nr_sectors = 256,
> -               .name = "S25FL129P_64K",
> +               .name = "S25FL129P_64K/S25FL128S_64K",

Any comments on this notation, as the ID's are same for these parts upto 5bytes.
if you need to differ then we should read the 6th byte.

If i.e the case increase the byte count on probe function for this, due to extra
over head only for this, i just noted like this. does it make sense?

Request comments.

--
Thanks,
Jagan.

[U-Boot] [PATCH v2 2/8] sf: spansion: Add support for S25FL128S_64K

[Jagannadha Sutradharudu Teki]

This commit is based on the patch from Xie Xiaobo <X.Xie@freescale.com>
with commit head title as "sf: spansion: Add support for S25FL128S".
pulled the same code changes into current u-boot tree with little update
on the name field.

http://patchwork.ozlabs.org/patch/218145/

SPANSION recommend S25FL128S supersedes S25FL129P, and the two flash
memory have the same device ID and Memory architecture. So they can
use the same config parameters.

Signed-off-by: Xie Xiaobo <X.Xie@freescale.com>
Signed-off-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
---
Changes for v2:
        - none

 drivers/mtd/spi/spansion.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/spi/spansion.c b/drivers/mtd/spi/spansion.c
index 2218e2f..dad4fbb 100644
--- a/drivers/mtd/spi/spansion.c
+++ b/drivers/mtd/spi/spansion.c
@@ -101,7 +101,7 @@ static const struct spansion_spi_flash_params spansion_spi_flash_table[] = {
 		.idcode2 = 0x4d01,
 		.pages_per_sector = 256,
 		.nr_sectors = 256,
-		.name = "S25FL129P_64K",
+		.name = "S25FL129P_64K/S25FL128S_64K",
 	},
 	{
 		.idcode1 = 0x0219,
-- 
1.8.3