All of lore.kernel.org
 help / color / mirror / Atom feed
From: Li Yang <leoyang.li@nxp.com>
To: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>,
	Rob Herring <robh@kernel.org>
Subject: Re: [PATCH] arm64: dts: remove big-endian filed from IFC controller
Date: Tue, 28 Aug 2018 13:38:23 -0500	[thread overview]
Message-ID: <CADRPPNTCZVkjzFfn7k2As2_VXGx3gXStVcrEOhYDV-i8QiSoeA@mail.gmail.com> (raw)
In-Reply-To: <20180828065936.8040-1-prabhakar.kushwaha@nxp.com>

On Tue, Aug 28, 2018 at 2:02 AM Prabhakar Kushwaha
<prabhakar.kushwaha@nxp.com> wrote:
>
> As per IFC binding, Absence of "little-endian" field causes registers
> access in big-endian mode.
> So no need to set explicit big-endian field IFC node for LS1043A and
> LS1046A.
>
> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 2 +-
>  arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 3 ++-
>  2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> index b9f5d2ff4ff2..68af84a8ade8 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> @@ -3,6 +3,7 @@
>   * Device Tree Include file for Freescale Layerscape-1043A family SoC.
>   *
>   * Copyright 2014-2015 Freescale Semiconductor, Inc.
> + * Copyright 2018 NXP
>   *
>   * Mingkai Hu <Mingkai.hu@freescale.com>
>   */
> @@ -280,7 +281,6 @@
>                 ifc: ifc@1530000 {
>                         compatible = "fsl,ifc", "simple-bus";
>                         reg = <0x0 0x1530000 0x0 0x10000>;
> -                       big-endian;
>                         interrupts = <0 43 0x4>;
>                 };
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> index 65ce1c3cb568..9f5acb4dfaf3 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> @@ -4,6 +4,8 @@
>   *
>   * Copyright 2016 Freescale Semiconductor, Inc.
>   *
> + * Copyright 2018 NXP
> + *

Probably better to align with the other files to not have empty line
between copyright claims?

>   * Mingkai Hu <mingkai.hu@nxp.com>
>   */
>
> @@ -198,7 +200,6 @@
>                 ifc: ifc@1530000 {
>                         compatible = "fsl,ifc", "simple-bus";
>                         reg = <0x0 0x1530000 0x0 0x10000>;
> -                       big-endian;
>                         interrupts = <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>;
>                 };
>
> --
> 2.14.1
>

WARNING: multiple messages have this Message-ID (diff)
From: leoyang.li@nxp.com (Li Yang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: dts: remove big-endian filed from IFC controller
Date: Tue, 28 Aug 2018 13:38:23 -0500	[thread overview]
Message-ID: <CADRPPNTCZVkjzFfn7k2As2_VXGx3gXStVcrEOhYDV-i8QiSoeA@mail.gmail.com> (raw)
In-Reply-To: <20180828065936.8040-1-prabhakar.kushwaha@nxp.com>

On Tue, Aug 28, 2018 at 2:02 AM Prabhakar Kushwaha
<prabhakar.kushwaha@nxp.com> wrote:
>
> As per IFC binding, Absence of "little-endian" field causes registers
> access in big-endian mode.
> So no need to set explicit big-endian field IFC node for LS1043A and
> LS1046A.
>
> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 2 +-
>  arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 3 ++-
>  2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> index b9f5d2ff4ff2..68af84a8ade8 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> @@ -3,6 +3,7 @@
>   * Device Tree Include file for Freescale Layerscape-1043A family SoC.
>   *
>   * Copyright 2014-2015 Freescale Semiconductor, Inc.
> + * Copyright 2018 NXP
>   *
>   * Mingkai Hu <Mingkai.hu@freescale.com>
>   */
> @@ -280,7 +281,6 @@
>                 ifc: ifc at 1530000 {
>                         compatible = "fsl,ifc", "simple-bus";
>                         reg = <0x0 0x1530000 0x0 0x10000>;
> -                       big-endian;
>                         interrupts = <0 43 0x4>;
>                 };
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> index 65ce1c3cb568..9f5acb4dfaf3 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> @@ -4,6 +4,8 @@
>   *
>   * Copyright 2016 Freescale Semiconductor, Inc.
>   *
> + * Copyright 2018 NXP
> + *

Probably better to align with the other files to not have empty line
between copyright claims?

>   * Mingkai Hu <mingkai.hu@nxp.com>
>   */
>
> @@ -198,7 +200,6 @@
>                 ifc: ifc at 1530000 {
>                         compatible = "fsl,ifc", "simple-bus";
>                         reg = <0x0 0x1530000 0x0 0x10000>;
> -                       big-endian;
>                         interrupts = <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>;
>                 };
>
> --
> 2.14.1
>

  parent reply	other threads:[~2018-08-28 18:38 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-28  6:59 [PATCH] arm64: dts: remove big-endian filed from IFC controller Prabhakar Kushwaha
2018-08-28  6:59 ` Prabhakar Kushwaha
2018-08-28  6:59 ` [PATCH 1/2][RESEND] ARM: dts: Add big-endian in nor node for ls1021a Prabhakar Kushwaha
2018-08-28  6:59   ` Prabhakar Kushwaha
2018-08-28 20:46   ` Li Yang
2018-08-28 20:46     ` Li Yang
2018-08-28 22:25   ` Fabio Estevam
2018-08-28 22:25     ` Fabio Estevam
2018-08-29  2:55     ` Prabhakar Kushwaha
2018-08-29  2:55       ` Prabhakar Kushwaha
2018-09-02 23:58   ` Shawn Guo
2018-09-02 23:58     ` Shawn Guo
2018-08-28  6:59 ` [PATCH 2/2][RESEND] arm64: dts: Add big-endian in nor node for ls104xa Prabhakar Kushwaha
2018-08-28  6:59   ` Prabhakar Kushwaha
2018-08-28 20:44   ` Li Yang
2018-08-28 20:44     ` Li Yang
2018-08-28 22:26   ` Fabio Estevam
2018-08-28 22:26     ` Fabio Estevam
2018-08-28 18:38 ` Li Yang [this message]
2018-08-28 18:38   ` [PATCH] arm64: dts: remove big-endian filed from IFC controller Li Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADRPPNTCZVkjzFfn7k2As2_VXGx3gXStVcrEOhYDV-i8QiSoeA@mail.gmail.com \
    --to=leoyang.li@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=prabhakar.kushwaha@nxp.com \
    --cc=robh@kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.