[OE-core][PATCH] core-image-sato: install virtio input for Qemu targets

[OE-core][PATCH] core-image-sato: install virtio input for Qemu targets

[Thomas Perrot]

Otherwise, it isn't possible to interact with the UI.

Signed-off-by: Thomas Perrot <thomas.perrot@bootlin.com>
---
 meta/recipes-sato/images/core-image-sato.bb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-sato/images/core-image-sato.bb b/meta/recipes-sato/images/core-image-sato.bb
index e63a229d1257..0e37c15097b3 100644
--- a/meta/recipes-sato/images/core-image-sato.bb
+++ b/meta/recipes-sato/images/core-image-sato.bb
@@ -12,6 +12,8 @@ inherit core-image
 TOOLCHAIN_HOST_TASK:append = " nativesdk-intltool nativesdk-glib-2.0"
 TOOLCHAIN_HOST_TASK:remove:task-populate-sdk-ext = " nativesdk-intltool nativesdk-glib-2.0"
 
+IMAGE_INSTALL:append:qemuall = " kernel-module-virtio-input"
+
 QB_MEM = '${@bb.utils.contains("DISTRO_FEATURES", "opengl", "-m 512", "-m 256", d)}'
 QB_MEM:qemuarmv5 = "-m 256"
 QB_MEM:qemumips = "-m 256"
-- 
2.37.3

Re: [OE-core][PATCH] core-image-sato: install virtio input for Qemu targets

[Alexander Kanavin]

[-- Attachment #1: Type: text/plain, Size: 1556 bytes --]

Has this regressed at some point? Why was it not needed before?

Alex

On Wed 5. Oct 2022 at 17.01, Thomas Perrot via lists.openembedded.org
<thomas.perrot=bootlin.com@lists.openembedded.org> wrote:

> Otherwise, it isn't possible to interact with the UI.
>
> Signed-off-by: Thomas Perrot <thomas.perrot@bootlin.com>
> ---
>  meta/recipes-sato/images/core-image-sato.bb | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta/recipes-sato/images/core-image-sato.bb
> b/meta/recipes-sato/images/core-image-sato.bb
> index e63a229d1257..0e37c15097b3 100644
> --- a/meta/recipes-sato/images/core-image-sato.bb
> +++ b/meta/recipes-sato/images/core-image-sato.bb
> @@ -12,6 +12,8 @@ inherit core-image
>  TOOLCHAIN_HOST_TASK:append = " nativesdk-intltool nativesdk-glib-2.0"
>  TOOLCHAIN_HOST_TASK:remove:task-populate-sdk-ext = " nativesdk-intltool
> nativesdk-glib-2.0"
>
> +IMAGE_INSTALL:append:qemuall = " kernel-module-virtio-input"
> +
>  QB_MEM = '${@bb.utils.contains("DISTRO_FEATURES", "opengl", "-m 512", "-m
> 256", d)}'
>  QB_MEM:qemuarmv5 = "-m 256"
>  QB_MEM:qemumips = "-m 256"
> --
> 2.37.3
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#171461):
> https://lists.openembedded.org/g/openembedded-core/message/171461
> Mute This Topic: https://lists.openembedded.org/mt/94137249/1686489
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> alex.kanavin@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>

[-- Attachment #2: Type: text/html, Size: 3088 bytes --]

Re: [OE-core][PATCH] core-image-sato: install virtio input for Qemu targets

[Thomas Perrot]

[-- Attachment #1.1: Type: text/plain, Size: 1942 bytes --]

Hello Alex,

On Wed, 2022-10-05 at 17:31 +0200, Alexander Kanavin wrote:
> Has this regressed at some point? Why was it not needed before?

This issue occurs when the rrecommends are not installed.

Kind regards,
Thomas

> 
> Alex
> 
> On Wed 5. Oct 2022 at 17.01, Thomas Perrot via lists.openembedded.org
> <thomas.perrot=bootlin.com@lists.openembedded.org> wrote:
> > Otherwise, it isn't possible to interact with the UI.
> > 
> > Signed-off-by: Thomas Perrot <thomas.perrot@bootlin.com>
> > ---
> >  meta/recipes-sato/images/core-image-sato.bb | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/meta/recipes-sato/images/core-image-sato.bb
> > b/meta/recipes-sato/images/core-image-sato.bb
> > index e63a229d1257..0e37c15097b3 100644
> > --- a/meta/recipes-sato/images/core-image-sato.bb
> > +++ b/meta/recipes-sato/images/core-image-sato.bb
> > @@ -12,6 +12,8 @@ inherit core-image
> >  TOOLCHAIN_HOST_TASK:append = " nativesdk-intltool nativesdk-glib-
> > 2.0"
> >  TOOLCHAIN_HOST_TASK:remove:task-populate-sdk-ext = " nativesdk-
> > intltool nativesdk-glib-2.0"
> > 
> > +IMAGE_INSTALL:append:qemuall = " kernel-module-virtio-input"
> > +
> >  QB_MEM = '${@bb.utils.contains("DISTRO_FEATURES", "opengl", "-m
> > 512", "-m 256", d)}'
> >  QB_MEM:qemuarmv5 = "-m 256"
> >  QB_MEM:qemumips = "-m 256"
> > 
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#171465):
> > https://lists.openembedded.org/g/openembedded-core/message/171465
> > Mute This Topic: https://lists.openembedded.org/mt/94137249/5443093
> > Group Owner: openembedded-core+owner@lists.openembedded.org
> > Unsubscribe:
> > https://lists.openembedded.org/g/openembedded-core/unsub [
> > thomas.perrot@bootlin.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> > 

-- 
Thomas Perrot, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com


[-- Attachment #1.2: Type: text/html, Size: 3653 bytes --]

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

Re: [OE-core][PATCH] core-image-sato: install virtio input for Qemu targets

[Alexander Kanavin]

Then please add this to the commit message.

Alex

On Wed, 5 Oct 2022 at 18:10, Thomas Perrot <thomas.perrot@bootlin.com> wrote:
>
> Hello Alex,
>
> On Wed, 2022-10-05 at 17:31 +0200, Alexander Kanavin wrote:
>
> Has this regressed at some point? Why was it not needed before?
>
>
> This issue occurs when the rrecommends are not installed.
>
> Kind regards,
> Thomas
>
>
> Alex
>
> On Wed 5. Oct 2022 at 17.01, Thomas Perrot via lists.openembedded.org <thomas.perrot=bootlin.com@lists.openembedded.org> wrote:
>
> Otherwise, it isn't possible to interact with the UI.
>
> Signed-off-by: Thomas Perrot <thomas.perrot@bootlin.com>
> ---
>  meta/recipes-sato/images/core-image-sato.bb | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta/recipes-sato/images/core-image-sato.bb b/meta/recipes-sato/images/core-image-sato.bb
> index e63a229d1257..0e37c15097b3 100644
> --- a/meta/recipes-sato/images/core-image-sato.bb
> +++ b/meta/recipes-sato/images/core-image-sato.bb
> @@ -12,6 +12,8 @@ inherit core-image
>  TOOLCHAIN_HOST_TASK:append = " nativesdk-intltool nativesdk-glib-2.0"
>  TOOLCHAIN_HOST_TASK:remove:task-populate-sdk-ext = " nativesdk-intltool nativesdk-glib-2.0"
>
> +IMAGE_INSTALL:append:qemuall = " kernel-module-virtio-input"
> +
>  QB_MEM = '${@bb.utils.contains("DISTRO_FEATURES", "opengl", "-m 512", "-m 256", d)}'
>  QB_MEM:qemuarmv5 = "-m 256"
>  QB_MEM:qemumips = "-m 256"
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#171465): https://lists.openembedded.org/g/openembedded-core/message/171465
> Mute This Topic: https://lists.openembedded.org/mt/94137249/5443093
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [thomas.perrot@bootlin.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
> --
>
> Thomas Perrot, Bootlin
> Embedded Linux and kernel engineering
> https://bootlin.com
>

Re: [OE-core][PATCH] core-image-sato: install virtio input for Qemu targets

[Khem Raj]

On Wed, Oct 5, 2022 at 8:01 AM Thomas Perrot via
lists.openembedded.org
<thomas.perrot=bootlin.com@lists.openembedded.org> wrote:
>
> Otherwise, it isn't possible to interact with the UI.

I wonder if it should be in the MACHINE_EXTRA_RRECOMMENDS in machine
configs, it will help a wide range of users who may be using
graphical images.

>
> Signed-off-by: Thomas Perrot <thomas.perrot@bootlin.com>
> ---
>  meta/recipes-sato/images/core-image-sato.bb | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta/recipes-sato/images/core-image-sato.bb b/meta/recipes-sato/images/core-image-sato.bb
> index e63a229d1257..0e37c15097b3 100644
> --- a/meta/recipes-sato/images/core-image-sato.bb
> +++ b/meta/recipes-sato/images/core-image-sato.bb
> @@ -12,6 +12,8 @@ inherit core-image
>  TOOLCHAIN_HOST_TASK:append = " nativesdk-intltool nativesdk-glib-2.0"
>  TOOLCHAIN_HOST_TASK:remove:task-populate-sdk-ext = " nativesdk-intltool nativesdk-glib-2.0"
>
> +IMAGE_INSTALL:append:qemuall = " kernel-module-virtio-input"
> +
>  QB_MEM = '${@bb.utils.contains("DISTRO_FEATURES", "opengl", "-m 512", "-m 256", d)}'
>  QB_MEM:qemuarmv5 = "-m 256"
>  QB_MEM:qemumips = "-m 256"
> --
> 2.37.3
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#171461): https://lists.openembedded.org/g/openembedded-core/message/171461
> Mute This Topic: https://lists.openembedded.org/mt/94137249/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>

Re: [OE-core][PATCH] core-image-sato: install virtio input for Qemu targets

[Thomas Perrot]

[-- Attachment #1: Type: text/plain, Size: 2194 bytes --]

Hello Khem,

On Wed, 2022-10-05 at 09:19 -0700, Khem Raj wrote:
> On Wed, Oct 5, 2022 at 8:01 AM Thomas Perrot via
> lists.openembedded.org
> <thomas.perrot=bootlin.com@lists.openembedded.org> wrote:
> > 
> > Otherwise, it isn't possible to interact with the UI.
> 
> I wonder if it should be in the MACHINE_EXTRA_RRECOMMENDS in machine
> configs, it will help a wide range of users who may be using
> graphical images.

I hesitated to put it in MACHINE_EXTRA_RDEPENDS for Qemu targets.

Currently, kernel-modules are in MACHINE_EXTRA_RRECOMMENDS of Qemu
RISC-V and PPC64, which are not installed when NO_RECOMMENDATIONS="1"

Kind regards,
Thomas

> 
> > 
> > Signed-off-by: Thomas Perrot <thomas.perrot@bootlin.com>
> > ---
> >  meta/recipes-sato/images/core-image-sato.bb | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/meta/recipes-sato/images/core-image-sato.bb
> > b/meta/recipes-sato/images/core-image-sato.bb
> > index e63a229d1257..0e37c15097b3 100644
> > --- a/meta/recipes-sato/images/core-image-sato.bb
> > +++ b/meta/recipes-sato/images/core-image-sato.bb
> > @@ -12,6 +12,8 @@ inherit core-image
> >  TOOLCHAIN_HOST_TASK:append = " nativesdk-intltool nativesdk-glib-
> > 2.0"
> >  TOOLCHAIN_HOST_TASK:remove:task-populate-sdk-ext = " nativesdk-
> > intltool nativesdk-glib-2.0"
> > 
> > +IMAGE_INSTALL:append:qemuall = " kernel-module-virtio-input"
> > +
> >  QB_MEM = '${@bb.utils.contains("DISTRO_FEATURES", "opengl", "-m
> > 512", "-m 256", d)}'
> >  QB_MEM:qemuarmv5 = "-m 256"
> >  QB_MEM:qemumips = "-m 256"
> > --
> > 2.37.3
> > 
> > 
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#171461):
> > https://lists.openembedded.org/g/openembedded-core/message/171461
> > Mute This Topic: https://lists.openembedded.org/mt/94137249/1997914
> > Group Owner: openembedded-core+owner@lists.openembedded.org
> > Unsubscribe:
> > https://lists.openembedded.org/g/openembedded-core/unsub [
> > raj.khem@gmail.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> > 

-- 
Thomas Perrot, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

Re: [OE-core][PATCH] core-image-sato: install virtio input for Qemu targets

[Alexander Kanavin]

Does core-image-weston have the same problem? If it does, then this
certainly needs to go to qemu include in conf/machine/

Alex

On Wed, 5 Oct 2022 at 18:51, Thomas Perrot via lists.openembedded.org
<thomas.perrot=bootlin.com@lists.openembedded.org> wrote:
>
> Hello Khem,
>
> On Wed, 2022-10-05 at 09:19 -0700, Khem Raj wrote:
> > On Wed, Oct 5, 2022 at 8:01 AM Thomas Perrot via
> > lists.openembedded.org
> > <thomas.perrot=bootlin.com@lists.openembedded.org> wrote:
> > >
> > > Otherwise, it isn't possible to interact with the UI.
> >
> > I wonder if it should be in the MACHINE_EXTRA_RRECOMMENDS in machine
> > configs, it will help a wide range of users who may be using
> > graphical images.
>
> I hesitated to put it in MACHINE_EXTRA_RDEPENDS for Qemu targets.
>
> Currently, kernel-modules are in MACHINE_EXTRA_RRECOMMENDS of Qemu
> RISC-V and PPC64, which are not installed when NO_RECOMMENDATIONS="1"
>
> Kind regards,
> Thomas
>
> >
> > >
> > > Signed-off-by: Thomas Perrot <thomas.perrot@bootlin.com>
> > > ---
> > >  meta/recipes-sato/images/core-image-sato.bb | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/meta/recipes-sato/images/core-image-sato.bb
> > > b/meta/recipes-sato/images/core-image-sato.bb
> > > index e63a229d1257..0e37c15097b3 100644
> > > --- a/meta/recipes-sato/images/core-image-sato.bb
> > > +++ b/meta/recipes-sato/images/core-image-sato.bb
> > > @@ -12,6 +12,8 @@ inherit core-image
> > >  TOOLCHAIN_HOST_TASK:append = " nativesdk-intltool nativesdk-glib-
> > > 2.0"
> > >  TOOLCHAIN_HOST_TASK:remove:task-populate-sdk-ext = " nativesdk-
> > > intltool nativesdk-glib-2.0"
> > >
> > > +IMAGE_INSTALL:append:qemuall = " kernel-module-virtio-input"
> > > +
> > >  QB_MEM = '${@bb.utils.contains("DISTRO_FEATURES", "opengl", "-m
> > > 512", "-m 256", d)}'
> > >  QB_MEM:qemuarmv5 = "-m 256"
> > >  QB_MEM:qemumips = "-m 256"
> > > --
> > > 2.37.3
> > >
> > >
> > >
> > >
>
> --
> Thomas Perrot, Bootlin
> Embedded Linux and kernel engineering
> https://bootlin.com
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#171468): https://lists.openembedded.org/g/openembedded-core/message/171468
> Mute This Topic: https://lists.openembedded.org/mt/94137249/1686489
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>

Re: [OE-core][PATCH] core-image-sato: install virtio input for Qemu targets

[Thomas Perrot]

[-- Attachment #1: Type: text/plain, Size: 3876 bytes --]

Hello Alex,

On Wed, 2022-10-05 at 19:09 +0200, Alexander Kanavin wrote:
> > Does core-image-weston have the same problem? If it does, then this
> > certainly needs to go to qemu include in conf/machine/
> > 

Yes, the same issue occurs on core-image-weston, when
NO_RECOMMENDATIONS = "1".

So, instead of adding this rdepends in the sato image, I can add
kernel-module-virtio-input in MACHINE_EXTRA_RDEPENDS in
conf/machine/include/qemu.inc.

In addition, I'm looking to use a built-in virtio-input, as proposed by
	Bruce Ashfield.

Kind regards,
Thomas

> > Alex
> > 
> > On Wed, 5 Oct 2022 at 18:51, Thomas Perrot via
> > lists.openembedded.org
> > <thomas.perrot=bootlin.com@lists.openembedded.org> wrote:
> > > > 
> > > > Hello Khem,
> > > > 
> > > > On Wed, 2022-10-05 at 09:19 -0700, Khem Raj wrote:
> > > > > > On Wed, Oct 5, 2022 at 8:01 AM Thomas Perrot via
> > > > > > lists.openembedded.org
> > > > > > <thomas.perrot=bootlin.com@lists.openembedded.org> wrote:
> > > > > > > > 
> > > > > > > > Otherwise, it isn't possible to interact with the UI.
> > > > > > 
> > > > > > I wonder if it should be in the MACHINE_EXTRA_RRECOMMENDS
> > > > > > in > > > machine
> > > > > > configs, it will help a wide range of users who may be
> > > > > > using
> > > > > > graphical images.
> > > > 
> > > > I hesitated to put it in MACHINE_EXTRA_RDEPENDS for Qemu
> > > > targets.
> > > > 
> > > > Currently, kernel-modules are in MACHINE_EXTRA_RRECOMMENDS of
> > > > Qemu
> > > > RISC-V and PPC64, which are not installed when > >
> > > > NO_RECOMMENDATIONS="1"
> > > > 
> > > > Kind regards,
> > > > Thomas
> > > > 
> > > > > > 
> > > > > > > > 
> > > > > > > > Signed-off-by: Thomas Perrot
> > > > > > > > <thomas.perrot@bootlin.com>
> > > > > > > > ---
> > > > > > > >  meta/recipes-sato/images/core-image-sato.bb | 2 ++
> > > > > > > >  1 file changed, 2 insertions(+)
> > > > > > > > 
> > > > > > > > diff --git a/meta/recipes-sato/images/core-image-
> > > > > > > > sato.bb
> > > > > > > > b/meta/recipes-sato/images/core-image-sato.bb
> > > > > > > > index e63a229d1257..0e37c15097b3 100644
> > > > > > > > --- a/meta/recipes-sato/images/core-image-sato.bb
> > > > > > > > +++ b/meta/recipes-sato/images/core-image-sato.bb
> > > > > > > > @@ -12,6 +12,8 @@ inherit core-image
> > > > > > > >  TOOLCHAIN_HOST_TASK:append = " nativesdk-intltool > >
> > > > > > > > > > nativesdk-glib-
> > > > > > > > 2.0"
> > > > > > > >  TOOLCHAIN_HOST_TASK:remove:task-populate-sdk-ext = " >
> > > > > > > > > > > nativesdk-
> > > > > > > > intltool nativesdk-glib-2.0"
> > > > > > > > 
> > > > > > > > +IMAGE_INSTALL:append:qemuall = " kernel-module-virtio-
> > > > > > > > input"
> > > > > > > > +
> > > > > > > >  QB_MEM = '${@bb.utils.contains("DISTRO_FEATURES",
> > > > > > > > "opengl", > > > > "-m
> > > > > > > > 512", "-m 256", d)}'
> > > > > > > >  QB_MEM:qemuarmv5 = "-m 256"
> > > > > > > >  QB_MEM:qemumips = "-m 256"
> > > > > > > > --
> > > > > > > > 2.37.3
> > > > > > > > 
> > > > > > > > 
> > > > > > > > 
> > > > > > > > 
> > > > 
> > > > --
> > > > Thomas Perrot, Bootlin
> > > > Embedded Linux and kernel engineering
> > > > https://bootlin.com
> > > > 
> > > > 
> > > > 
> > > > 
> > 
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#171469): >
> > https://lists.openembedded.org/g/openembedded-core/message/171469
> > Mute This Topic: https://lists.openembedded.org/mt/94137249/5443093
> > Group Owner: openembedded-core+owner@lists.openembedded.org
> > Unsubscribe:
> > https://lists.openembedded.org/g/openembedded-core/unsub>
> >  [thomas.perrot@bootlin.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> > 

-- 
Thomas Perrot, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

Re: [OE-core][PATCH] core-image-sato: install virtio input for Qemu targets

[Bruce Ashfield]

On Wed, Oct 5, 2022 at 12:51 PM Thomas Perrot via
lists.openembedded.org
<thomas.perrot=bootlin.com@lists.openembedded.org> wrote:
>
> Hello Khem,
>
> On Wed, 2022-10-05 at 09:19 -0700, Khem Raj wrote:
> > On Wed, Oct 5, 2022 at 8:01 AM Thomas Perrot via
> > lists.openembedded.org
> > <thomas.perrot=bootlin.com@lists.openembedded.org> wrote:
> > >
> > > Otherwise, it isn't possible to interact with the UI.
> >
> > I wonder if it should be in the MACHINE_EXTRA_RRECOMMENDS in machine
> > configs, it will help a wide range of users who may be using
> > graphical images.
>
> I hesitated to put it in MACHINE_EXTRA_RDEPENDS for Qemu targets.
>
> Currently, kernel-modules are in MACHINE_EXTRA_RRECOMMENDS of Qemu
> RISC-V and PPC64, which are not installed when NO_RECOMMENDATIONS="1"
>

We don't control the kernel configuration to the point where we can
guarantee that something is built as a module or not.

Have you tried assembling the image with that option built-in, versus
a module ? Last I checked, a kernel-module* dependency won't be
provided by the built-ins, and this will trigger an error.

With that option appended, it isn't something that can be overridden
easily, and the qemu* + core images are used as a starting point for
demos, etc (whether or not that is a good idea is also debatable). If
a non-core kernel provider and qemu are used in a scenario like that
.. they can trigger the error.

Bruce

> Kind regards,
> Thomas
>
> >
> > >
> > > Signed-off-by: Thomas Perrot <thomas.perrot@bootlin.com>
> > > ---
> > >  meta/recipes-sato/images/core-image-sato.bb | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/meta/recipes-sato/images/core-image-sato.bb
> > > b/meta/recipes-sato/images/core-image-sato.bb
> > > index e63a229d1257..0e37c15097b3 100644
> > > --- a/meta/recipes-sato/images/core-image-sato.bb
> > > +++ b/meta/recipes-sato/images/core-image-sato.bb
> > > @@ -12,6 +12,8 @@ inherit core-image
> > >  TOOLCHAIN_HOST_TASK:append = " nativesdk-intltool nativesdk-glib-
> > > 2.0"
> > >  TOOLCHAIN_HOST_TASK:remove:task-populate-sdk-ext = " nativesdk-
> > > intltool nativesdk-glib-2.0"
> > >
> > > +IMAGE_INSTALL:append:qemuall = " kernel-module-virtio-input"
> > > +
> > >  QB_MEM = '${@bb.utils.contains("DISTRO_FEATURES", "opengl", "-m
> > > 512", "-m 256", d)}'
> > >  QB_MEM:qemuarmv5 = "-m 256"
> > >  QB_MEM:qemumips = "-m 256"
> > > --
> > > 2.37.3
> > >
> > >
> > >
> > >
>
> --
> Thomas Perrot, Bootlin
> Embedded Linux and kernel engineering
> https://bootlin.com
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#171468): https://lists.openembedded.org/g/openembedded-core/message/171468
> Mute This Topic: https://lists.openembedded.org/mt/94137249/1050810
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>


-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

Re: [OE-core][PATCH] core-image-sato: install virtio input for Qemu targets

[Thomas Perrot]

[-- Attachment #1: Type: text/plain, Size: 3739 bytes --]

Hello Bruce,

On Wed, 2022-10-05 at 13:19 -0400, Bruce Ashfield wrote:
> On Wed, Oct 5, 2022 at 12:51 PM Thomas Perrot via
> lists.openembedded.org
> <thomas.perrot=bootlin.com@lists.openembedded.org> wrote:
> > 
> > Hello Khem,
> > 
> > On Wed, 2022-10-05 at 09:19 -0700, Khem Raj wrote:
> > > On Wed, Oct 5, 2022 at 8:01 AM Thomas Perrot via
> > > lists.openembedded.org
> > > <thomas.perrot=bootlin.com@lists.openembedded.org> wrote:
> > > > 
> > > > Otherwise, it isn't possible to interact with the UI.
> > > 
> > > I wonder if it should be in the MACHINE_EXTRA_RRECOMMENDS in
> > > machine
> > > configs, it will help a wide range of users who may be using
> > > graphical images.
> > 
> > I hesitated to put it in MACHINE_EXTRA_RDEPENDS for Qemu targets.
> > 
> > Currently, kernel-modules are in MACHINE_EXTRA_RRECOMMENDS of Qemu
> > RISC-V and PPC64, which are not installed when
> > NO_RECOMMENDATIONS="1"
> > 
> 
> We don't control the kernel configuration to the point where we can
> guarantee that something is built as a module or not.
> 
> Have you tried assembling the image with that option built-in, versus
> a module ? 

I tried to use a built-in virtio-input on Qemu targets, so the boot
process stalled with the following message: "please wait: booting..."
Then it seems necessary to use this driver as a kernel module on Qemu
targets.

Kind regards,
Thomas

> Last I checked, a kernel-module* dependency won't be
> provided by the built-ins, and this will trigger an error.
> 
> With that option appended, it isn't something that can be overridden
> easily, and the qemu* + core images are used as a starting point for
> demos, etc (whether or not that is a good idea is also debatable). If
> a non-core kernel provider and qemu are used in a scenario like that
> .. they can trigger the error.
> 
> Bruce
> 
> > Kind regards,
> > Thomas
> > 
> > > 
> > > > 
> > > > Signed-off-by: Thomas Perrot <thomas.perrot@bootlin.com>
> > > > ---
> > > >  meta/recipes-sato/images/core-image-sato.bb | 2 ++
> > > >  1 file changed, 2 insertions(+)
> > > > 
> > > > diff --git a/meta/recipes-sato/images/core-image-sato.bb
> > > > b/meta/recipes-sato/images/core-image-sato.bb
> > > > index e63a229d1257..0e37c15097b3 100644
> > > > --- a/meta/recipes-sato/images/core-image-sato.bb
> > > > +++ b/meta/recipes-sato/images/core-image-sato.bb
> > > > @@ -12,6 +12,8 @@ inherit core-image
> > > >  TOOLCHAIN_HOST_TASK:append = " nativesdk-intltool nativesdk-
> > > > glib-
> > > > 2.0"
> > > >  TOOLCHAIN_HOST_TASK:remove:task-populate-sdk-ext = "
> > > > nativesdk-
> > > > intltool nativesdk-glib-2.0"
> > > > 
> > > > +IMAGE_INSTALL:append:qemuall = " kernel-module-virtio-input"
> > > > +
> > > >  QB_MEM = '${@bb.utils.contains("DISTRO_FEATURES", "opengl", "-
> > > > m
> > > > 512", "-m 256", d)}'
> > > >  QB_MEM:qemuarmv5 = "-m 256"
> > > >  QB_MEM:qemumips = "-m 256"
> > > > --
> > > > 2.37.3
> > > > 
> > > > 
> > > > 
> > > > 
> > 
> > --
> > Thomas Perrot, Bootlin
> > Embedded Linux and kernel engineering
> > https://bootlin.com
> > 
> > 
> > 
> > 
> 
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#171473):
> https://lists.openembedded.org/g/openembedded-core/message/171473
> Mute This Topic: https://lists.openembedded.org/mt/94137249/5443093
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe:
> https://lists.openembedded.org/g/openembedded-core/unsub [
> thomas.perrot@bootlin.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 

-- 
Thomas Perrot, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 659 bytes --]