All of lore.kernel.org
 help / color / mirror / Atom feed
From: sh liu <liush.damon@gmail.com>
To: Paul Walmsley <paul.walmsley@sifive.com>
Cc: palmer@sifive.com, sorear2@gmail.com, aou@eecs.berkeley.edu,
	anup.patel@wdc.com, linux-kernel@vger.kernel.org,
	rppt@linux.ibm.com, linux-riscv@lists.infradead.org
Subject: Re: [PATCH] RISC-V: redefine PTRS_PER_PGD/PTRS_PER_PMD/PTRS_PER_PTE
Date: Wed, 24 Jul 2019 20:36:33 +0800	[thread overview]
Message-ID: <CADnCVLwL0DK0Xa8FHhxCyqpJNU3Az=Xvdr3_MqA85ju_nUBZDg@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.9999.1906281147260.3867@viisi.sifive.com>

I think the previous description is unclear, and it is difficult for
readers to understand the meaning of these macros, because I never
understand. So I submitted this patch with reference to the definition
of arm. I think this way can make the reader easier to understand, and
I also think that this definition is more reasonable.

2019-06-29 2:52 GMT+08:00, Paul Walmsley <paul.walmsley@sifive.com>:
> On Wed, 24 Apr 2019, damon wrote:
>
>> Use the number of addresses to define the relevant macros.
>>
>> Signed-off-by: damon <liush.damon@gmail.com>
>
> This patch looks reasonable to me.  But what's missing from the
> description is the motivation.  Is this a prerequisite for another patch
> that you're planning to post?  Or because you think this is clearer than
> the original?  Or something else?  etc.
>
>
> - Paul
>

WARNING: multiple messages have this Message-ID (diff)
From: sh liu <liush.damon@gmail.com>
To: Paul Walmsley <paul.walmsley@sifive.com>
Cc: sorear2@gmail.com, palmer@sifive.com, anup.patel@wdc.com,
	linux-kernel@vger.kernel.org, rppt@linux.ibm.com,
	aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org
Subject: Re: [PATCH] RISC-V: redefine PTRS_PER_PGD/PTRS_PER_PMD/PTRS_PER_PTE
Date: Wed, 24 Jul 2019 20:36:33 +0800	[thread overview]
Message-ID: <CADnCVLwL0DK0Xa8FHhxCyqpJNU3Az=Xvdr3_MqA85ju_nUBZDg@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.9999.1906281147260.3867@viisi.sifive.com>

I think the previous description is unclear, and it is difficult for
readers to understand the meaning of these macros, because I never
understand. So I submitted this patch with reference to the definition
of arm. I think this way can make the reader easier to understand, and
I also think that this definition is more reasonable.

2019-06-29 2:52 GMT+08:00, Paul Walmsley <paul.walmsley@sifive.com>:
> On Wed, 24 Apr 2019, damon wrote:
>
>> Use the number of addresses to define the relevant macros.
>>
>> Signed-off-by: damon <liush.damon@gmail.com>
>
> This patch looks reasonable to me.  But what's missing from the
> description is the motivation.  Is this a prerequisite for another patch
> that you're planning to post?  Or because you think this is clearer than
> the original?  Or something else?  etc.
>
>
> - Paul
>

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2019-07-24 12:36 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-24  8:11 [PATCH] RISC-V: redefine PTRS_PER_PGD/PTRS_PER_PMD/PTRS_PER_PTE damon
2019-04-24  8:11 ` damon
2019-04-24  8:13 ` Anup Patel
2019-04-24  8:13   ` Anup Patel
2019-06-28 18:52 ` Paul Walmsley
2019-06-28 18:52   ` Paul Walmsley
2019-07-24 12:36   ` sh liu [this message]
2019-07-24 12:36     ` sh liu
  -- strict thread matches above, loose matches on Subject: below --
2019-04-24  7:51 damon
2019-04-24  7:51 ` damon
2019-04-24  7:59 ` Anup Patel
2019-04-24  7:59   ` Anup Patel
2019-04-18  0:56 damon
2019-04-18  0:56 ` damon
2019-04-18  6:13 ` Anup Patel
2019-04-18  6:13   ` Anup Patel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADnCVLwL0DK0Xa8FHhxCyqpJNU3Az=Xvdr3_MqA85ju_nUBZDg@mail.gmail.com' \
    --to=liush.damon@gmail.com \
    --cc=anup.patel@wdc.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@sifive.com \
    --cc=paul.walmsley@sifive.com \
    --cc=rppt@linux.ibm.com \
    --cc=sorear2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.