From: Alex Deucher <alexdeucher@gmail.com>
To: "Christian König" <christian.koenig@amd.com>
Cc: "Xℹ Ruoyao" <xry111@mengyan1223.wang>,
"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
"Dan Horák" <dan@danny.cz>, "Huacai Chen" <chenhuacai@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
"David Airlie" <airlied@linux.ie>,
"Alex Deucher" <alexander.deucher@amd.com>
Subject: Re: [PATCH 0/2] ensure alignment on CPU page for bo mapping
Date: Tue, 30 Mar 2021 22:05:49 -0400 [thread overview]
Message-ID: <CADnq5_MrsQfyS6eJdPrJEyHUQCM1=pP=jre7Ur6D8ULQj00P2w@mail.gmail.com> (raw)
In-Reply-To: <7c5e3a40-9889-1cc2-583d-51f8c3294908@amd.com>
Applied. Thanks!
Alex
On Tue, Mar 30, 2021 at 12:21 PM Christian König
<christian.koenig@amd.com> wrote:
>
> Reviewed-by: Christian König <christian.koenig@amd.com> for the entire
> series.
>
> Alex will probably pick them up for the next feature pull request.
>
> Regards,
> Christian.
>
> Am 30.03.21 um 17:33 schrieb Xℹ Ruoyao:
> > In AMDGPU driver, the bo mapping should always align to CPU page or
> > the page table is corrupted.
> >
> > The first patch is cherry-picked from Loongson community, which sets a
> > suitable dev_info.gart_page_size so Mesa will handle the alignment
> > correctly.
> >
> > The second patch is added to ensure an ioctl with unaligned parameter to
> > be rejected -EINVAL, instead of causing page table corruption.
> >
> > The patches should be applied for drm-next.
> >
> > Huacai Chen (1):
> > drm/amdgpu: Set a suitable dev_info.gart_page_size
> >
> > Xℹ Ruoyao (1):
> > drm/amdgpu: check alignment on CPU page for bo map
> >
> > drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 4 ++--
> > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 8 ++++----
> > 2 files changed, 6 insertions(+), 6 deletions(-)
> >
> >
> > base-commit: a0c8b193bfe81cc8e9c7c162bb8d777ba12596f0
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Alex Deucher <alexdeucher@gmail.com>
To: "Christian König" <christian.koenig@amd.com>
Cc: "amd-gfx list" <amd-gfx@lists.freedesktop.org>,
"Dan Horák" <dan@danny.cz>, "Huacai Chen" <chenhuacai@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
"David Airlie" <airlied@linux.ie>,
"Xℹ Ruoyao" <xry111@mengyan1223.wang>,
"Alex Deucher" <alexander.deucher@amd.com>
Subject: Re: [PATCH 0/2] ensure alignment on CPU page for bo mapping
Date: Tue, 30 Mar 2021 22:05:49 -0400 [thread overview]
Message-ID: <CADnq5_MrsQfyS6eJdPrJEyHUQCM1=pP=jre7Ur6D8ULQj00P2w@mail.gmail.com> (raw)
In-Reply-To: <7c5e3a40-9889-1cc2-583d-51f8c3294908@amd.com>
Applied. Thanks!
Alex
On Tue, Mar 30, 2021 at 12:21 PM Christian König
<christian.koenig@amd.com> wrote:
>
> Reviewed-by: Christian König <christian.koenig@amd.com> for the entire
> series.
>
> Alex will probably pick them up for the next feature pull request.
>
> Regards,
> Christian.
>
> Am 30.03.21 um 17:33 schrieb Xℹ Ruoyao:
> > In AMDGPU driver, the bo mapping should always align to CPU page or
> > the page table is corrupted.
> >
> > The first patch is cherry-picked from Loongson community, which sets a
> > suitable dev_info.gart_page_size so Mesa will handle the alignment
> > correctly.
> >
> > The second patch is added to ensure an ioctl with unaligned parameter to
> > be rejected -EINVAL, instead of causing page table corruption.
> >
> > The patches should be applied for drm-next.
> >
> > Huacai Chen (1):
> > drm/amdgpu: Set a suitable dev_info.gart_page_size
> >
> > Xℹ Ruoyao (1):
> > drm/amdgpu: check alignment on CPU page for bo map
> >
> > drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 4 ++--
> > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 8 ++++----
> > 2 files changed, 6 insertions(+), 6 deletions(-)
> >
> >
> > base-commit: a0c8b193bfe81cc8e9c7c162bb8d777ba12596f0
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Alex Deucher <alexdeucher@gmail.com>
To: "Christian König" <christian.koenig@amd.com>
Cc: "amd-gfx list" <amd-gfx@lists.freedesktop.org>,
"Dan Horák" <dan@danny.cz>, "Huacai Chen" <chenhuacai@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
"David Airlie" <airlied@linux.ie>,
"Xℹ Ruoyao" <xry111@mengyan1223.wang>,
"Alex Deucher" <alexander.deucher@amd.com>
Subject: Re: [PATCH 0/2] ensure alignment on CPU page for bo mapping
Date: Tue, 30 Mar 2021 22:05:49 -0400 [thread overview]
Message-ID: <CADnq5_MrsQfyS6eJdPrJEyHUQCM1=pP=jre7Ur6D8ULQj00P2w@mail.gmail.com> (raw)
In-Reply-To: <7c5e3a40-9889-1cc2-583d-51f8c3294908@amd.com>
Applied. Thanks!
Alex
On Tue, Mar 30, 2021 at 12:21 PM Christian König
<christian.koenig@amd.com> wrote:
>
> Reviewed-by: Christian König <christian.koenig@amd.com> for the entire
> series.
>
> Alex will probably pick them up for the next feature pull request.
>
> Regards,
> Christian.
>
> Am 30.03.21 um 17:33 schrieb Xℹ Ruoyao:
> > In AMDGPU driver, the bo mapping should always align to CPU page or
> > the page table is corrupted.
> >
> > The first patch is cherry-picked from Loongson community, which sets a
> > suitable dev_info.gart_page_size so Mesa will handle the alignment
> > correctly.
> >
> > The second patch is added to ensure an ioctl with unaligned parameter to
> > be rejected -EINVAL, instead of causing page table corruption.
> >
> > The patches should be applied for drm-next.
> >
> > Huacai Chen (1):
> > drm/amdgpu: Set a suitable dev_info.gart_page_size
> >
> > Xℹ Ruoyao (1):
> > drm/amdgpu: check alignment on CPU page for bo map
> >
> > drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 4 ++--
> > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 8 ++++----
> > 2 files changed, 6 insertions(+), 6 deletions(-)
> >
> >
> > base-commit: a0c8b193bfe81cc8e9c7c162bb8d777ba12596f0
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2021-03-31 2:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 15:33 [PATCH 0/2] ensure alignment on CPU page for bo mapping Xℹ Ruoyao
2021-03-30 15:33 ` Xℹ Ruoyao
2021-03-30 15:33 ` Xℹ Ruoyao
2021-03-30 15:33 ` [PATCH 1/2] drm/amdgpu: Set a suitable dev_info.gart_page_size Xℹ Ruoyao
2021-03-30 15:33 ` Xℹ Ruoyao
2021-03-30 15:33 ` Xℹ Ruoyao
2021-03-30 15:33 ` [PATCH 2/2] drm/amdgpu: check alignment on CPU page for bo map Xℹ Ruoyao
2021-03-30 15:33 ` Xℹ Ruoyao
2021-03-30 15:33 ` Xℹ Ruoyao
2021-03-30 16:21 ` [PATCH 0/2] ensure alignment on CPU page for bo mapping Christian König
2021-03-30 16:21 ` Christian König
2021-03-30 16:21 ` Christian König
2021-03-31 2:05 ` Alex Deucher [this message]
2021-03-31 2:05 ` Alex Deucher
2021-03-31 2:05 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADnq5_MrsQfyS6eJdPrJEyHUQCM1=pP=jre7Ur6D8ULQj00P2w@mail.gmail.com' \
--to=alexdeucher@gmail.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=chenhuacai@kernel.org \
--cc=christian.koenig@amd.com \
--cc=dan@danny.cz \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xry111@mengyan1223.wang \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.