All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Deucher <alexdeucher@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Tom St Denis" <tom.stdenis@amd.com>,
	"Edward O'Callaghan" <funfunctor@folklore1984.net>,
	kernel-janitors@vger.kernel.org,
	"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
	"Eric Huang" <JinHuiEric.Huang@amd.com>,
	"Huang Rui" <ray.huang@amd.com>,
	"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Rex Zhu" <Rex.Zhu@amd.com>,
	"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH 1/2] drm/amd/powerplay: fix pp_dpm_get_current_power_state()
Date: Mon, 03 Apr 2017 20:28:54 +0000	[thread overview]
Message-ID: <CADnq5_NT+KEAX1w8a4vZdTYfH3eQ_OsmPF2KhfoCVBXA5aeQ_Q@mail.gmail.com> (raw)
In-Reply-To: <20170403184147.GA22462@mwanda>

On Mon, Apr 3, 2017 at 2:41 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> This switch statement is missing breaks.
>
> Fixes: 2a5071056e6a ("drm/amd/powerplay: add global PowerPlay mutex.")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied.  thanks!

>
> diff --git a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
> index dfd4fe6f0578..260b732be7c3 100644
> --- a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
> +++ b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
> @@ -539,10 +539,13 @@ static enum amd_pm_state_type pp_dpm_get_current_power_state(void *handle)
>         switch (state->classification.ui_label) {
>         case PP_StateUILabel_Battery:
>                 pm_type = POWER_STATE_TYPE_BATTERY;
> +               break;
>         case PP_StateUILabel_Balanced:
>                 pm_type = POWER_STATE_TYPE_BALANCED;
> +               break;
>         case PP_StateUILabel_Performance:
>                 pm_type = POWER_STATE_TYPE_PERFORMANCE;
> +               break;
>         default:
>                 if (state->classification.flags & PP_StateClassificationFlag_Boot)
>                         pm_type = POWER_STATE_TYPE_INTERNAL_BOOT;
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Alex Deucher <alexdeucher@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Tom St Denis" <tom.stdenis@amd.com>,
	"Edward O'Callaghan" <funfunctor@folklore1984.net>,
	kernel-janitors@vger.kernel.org,
	"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
	"Eric Huang" <JinHuiEric.Huang@amd.com>,
	"Huang Rui" <ray.huang@amd.com>,
	"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Rex Zhu" <Rex.Zhu@amd.com>,
	"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH 1/2] drm/amd/powerplay: fix pp_dpm_get_current_power_state()
Date: Mon, 3 Apr 2017 16:28:54 -0400	[thread overview]
Message-ID: <CADnq5_NT+KEAX1w8a4vZdTYfH3eQ_OsmPF2KhfoCVBXA5aeQ_Q@mail.gmail.com> (raw)
In-Reply-To: <20170403184147.GA22462@mwanda>

On Mon, Apr 3, 2017 at 2:41 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> This switch statement is missing breaks.
>
> Fixes: 2a5071056e6a ("drm/amd/powerplay: add global PowerPlay mutex.")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied.  thanks!

>
> diff --git a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
> index dfd4fe6f0578..260b732be7c3 100644
> --- a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
> +++ b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
> @@ -539,10 +539,13 @@ static enum amd_pm_state_type pp_dpm_get_current_power_state(void *handle)
>         switch (state->classification.ui_label) {
>         case PP_StateUILabel_Battery:
>                 pm_type = POWER_STATE_TYPE_BATTERY;
> +               break;
>         case PP_StateUILabel_Balanced:
>                 pm_type = POWER_STATE_TYPE_BALANCED;
> +               break;
>         case PP_StateUILabel_Performance:
>                 pm_type = POWER_STATE_TYPE_PERFORMANCE;
> +               break;
>         default:
>                 if (state->classification.flags & PP_StateClassificationFlag_Boot)
>                         pm_type = POWER_STATE_TYPE_INTERNAL_BOOT;
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2017-04-03 20:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-03 18:41 [PATCH 1/2] drm/amd/powerplay: fix pp_dpm_get_current_power_state() Dan Carpenter
2017-04-03 18:41 ` Dan Carpenter
2017-04-03 20:28 ` Alex Deucher [this message]
2017-04-03 20:28   ` Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADnq5_NT+KEAX1w8a4vZdTYfH3eQ_OsmPF2KhfoCVBXA5aeQ_Q@mail.gmail.com \
    --to=alexdeucher@gmail.com \
    --cc=JinHuiEric.Huang@amd.com \
    --cc=Rex.Zhu@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=dan.carpenter@oracle.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=funfunctor@folklore1984.net \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=ray.huang@amd.com \
    --cc=tom.stdenis@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.