All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] drm/amd/powerplay: fix pp_dpm_get_current_power_state()
@ 2017-04-03 18:41 ` Dan Carpenter
  0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2017-04-03 18:41 UTC (permalink / raw)
  To: Alex Deucher, Rex Zhu
  Cc: Tom St Denis, David Airlie,
	kernel-janitors-u79uwXL29TY76Z2rM5mHXA,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Huang Rui,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Eric Huang,
	Edward O'Callaghan, Christian König

This switch statement is missing breaks.

Fixes: 2a5071056e6a ("drm/amd/powerplay: add global PowerPlay mutex.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
index dfd4fe6f0578..260b732be7c3 100644
--- a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
+++ b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
@@ -539,10 +539,13 @@ static enum amd_pm_state_type pp_dpm_get_current_power_state(void *handle)
 	switch (state->classification.ui_label) {
 	case PP_StateUILabel_Battery:
 		pm_type = POWER_STATE_TYPE_BATTERY;
+		break;
 	case PP_StateUILabel_Balanced:
 		pm_type = POWER_STATE_TYPE_BALANCED;
+		break;
 	case PP_StateUILabel_Performance:
 		pm_type = POWER_STATE_TYPE_PERFORMANCE;
+		break;
 	default:
 		if (state->classification.flags & PP_StateClassificationFlag_Boot)
 			pm_type = POWER_STATE_TYPE_INTERNAL_BOOT;

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH 1/2] drm/amd/powerplay: fix pp_dpm_get_current_power_state()
@ 2017-04-03 18:41 ` Dan Carpenter
  0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2017-04-03 18:41 UTC (permalink / raw)
  To: Alex Deucher, Rex Zhu
  Cc: Tom St Denis, David Airlie,
	kernel-janitors-u79uwXL29TY76Z2rM5mHXA,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Huang Rui,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Eric Huang,
	Edward O'Callaghan, Christian König

This switch statement is missing breaks.

Fixes: 2a5071056e6a ("drm/amd/powerplay: add global PowerPlay mutex.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
index dfd4fe6f0578..260b732be7c3 100644
--- a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
+++ b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
@@ -539,10 +539,13 @@ static enum amd_pm_state_type pp_dpm_get_current_power_state(void *handle)
 	switch (state->classification.ui_label) {
 	case PP_StateUILabel_Battery:
 		pm_type = POWER_STATE_TYPE_BATTERY;
+		break;
 	case PP_StateUILabel_Balanced:
 		pm_type = POWER_STATE_TYPE_BALANCED;
+		break;
 	case PP_StateUILabel_Performance:
 		pm_type = POWER_STATE_TYPE_PERFORMANCE;
+		break;
 	default:
 		if (state->classification.flags & PP_StateClassificationFlag_Boot)
 			pm_type = POWER_STATE_TYPE_INTERNAL_BOOT;
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] drm/amd/powerplay: fix pp_dpm_get_current_power_state()
  2017-04-03 18:41 ` Dan Carpenter
@ 2017-04-03 20:28   ` Alex Deucher
  -1 siblings, 0 replies; 4+ messages in thread
From: Alex Deucher @ 2017-04-03 20:28 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: Tom St Denis, Edward O'Callaghan, kernel-janitors,
	amd-gfx list, Eric Huang, Huang Rui,
	Maling list - DRI developers, Alex Deucher, Rex Zhu,
	Christian König

On Mon, Apr 3, 2017 at 2:41 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> This switch statement is missing breaks.
>
> Fixes: 2a5071056e6a ("drm/amd/powerplay: add global PowerPlay mutex.")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied.  thanks!

>
> diff --git a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
> index dfd4fe6f0578..260b732be7c3 100644
> --- a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
> +++ b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
> @@ -539,10 +539,13 @@ static enum amd_pm_state_type pp_dpm_get_current_power_state(void *handle)
>         switch (state->classification.ui_label) {
>         case PP_StateUILabel_Battery:
>                 pm_type = POWER_STATE_TYPE_BATTERY;
> +               break;
>         case PP_StateUILabel_Balanced:
>                 pm_type = POWER_STATE_TYPE_BALANCED;
> +               break;
>         case PP_StateUILabel_Performance:
>                 pm_type = POWER_STATE_TYPE_PERFORMANCE;
> +               break;
>         default:
>                 if (state->classification.flags & PP_StateClassificationFlag_Boot)
>                         pm_type = POWER_STATE_TYPE_INTERNAL_BOOT;
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] drm/amd/powerplay: fix pp_dpm_get_current_power_state()
@ 2017-04-03 20:28   ` Alex Deucher
  0 siblings, 0 replies; 4+ messages in thread
From: Alex Deucher @ 2017-04-03 20:28 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: Tom St Denis, Edward O'Callaghan, kernel-janitors,
	amd-gfx list, Eric Huang, Huang Rui,
	Maling list - DRI developers, Alex Deucher, Rex Zhu,
	Christian König

On Mon, Apr 3, 2017 at 2:41 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> This switch statement is missing breaks.
>
> Fixes: 2a5071056e6a ("drm/amd/powerplay: add global PowerPlay mutex.")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied.  thanks!

>
> diff --git a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
> index dfd4fe6f0578..260b732be7c3 100644
> --- a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
> +++ b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
> @@ -539,10 +539,13 @@ static enum amd_pm_state_type pp_dpm_get_current_power_state(void *handle)
>         switch (state->classification.ui_label) {
>         case PP_StateUILabel_Battery:
>                 pm_type = POWER_STATE_TYPE_BATTERY;
> +               break;
>         case PP_StateUILabel_Balanced:
>                 pm_type = POWER_STATE_TYPE_BALANCED;
> +               break;
>         case PP_StateUILabel_Performance:
>                 pm_type = POWER_STATE_TYPE_PERFORMANCE;
> +               break;
>         default:
>                 if (state->classification.flags & PP_StateClassificationFlag_Boot)
>                         pm_type = POWER_STATE_TYPE_INTERNAL_BOOT;
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-04-03 20:28 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-03 18:41 [PATCH 1/2] drm/amd/powerplay: fix pp_dpm_get_current_power_state() Dan Carpenter
2017-04-03 18:41 ` Dan Carpenter
2017-04-03 20:28 ` Alex Deucher
2017-04-03 20:28   ` Alex Deucher

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.