Re: [PATCH] drm/radeon: add header comment for clarification to vce_v2_0_enable_mgcg()

From: Alex Deucher <alexdeucher@gmail.com>
To: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Cc: "Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"David Airlie" <airlied@linux.ie>,
	"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
	"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/radeon: add header comment for clarification to vce_v2_0_enable_mgcg()
Date: Thu, 29 Jun 2017 15:25:19 -0400	[thread overview]
Message-ID: <CADnq5_NmU1FTFqRO8Ye+DXZrCAvJ0hOsz8YX7uU9SM+LGiMtWA@mail.gmail.com> (raw)
In-Reply-To: <20170629173837.GA3397@embeddedgus>

On Thu, Jun 29, 2017 at 1:38 PM, Gustavo A. R. Silva
<garsilva@embeddedor.com> wrote:
> Add function header comment to make it clear that local variable sw_cg
> is used for debugging and it should not be removed.
>
> Addresses-Coverity-ID: 1198635
> Cc: Alex Deucher <alexdeucher@gmail.com>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>

Applied.  thanks!

Alex

> ---
>  drivers/gpu/drm/radeon/vce_v2_0.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/radeon/vce_v2_0.c b/drivers/gpu/drm/radeon/vce_v2_0.c
> index fce2144..b0a43b6 100644
> --- a/drivers/gpu/drm/radeon/vce_v2_0.c
> +++ b/drivers/gpu/drm/radeon/vce_v2_0.c
> @@ -104,6 +104,10 @@ static void vce_v2_0_disable_cg(struct radeon_device *rdev)
>         WREG32(VCE_CGTT_CLK_OVERRIDE, 7);
>  }
>
> +/*
> + * Local variable sw_cg is used for debugging purposes, in case we
> + * ran into problems with dynamic clock gating. Don't remove it.
> + */
>  void vce_v2_0_enable_mgcg(struct radeon_device *rdev, bool enable)
>  {
>         bool sw_cg = false;
> --
> 2.5.0
>