* Re: [PATCH] drm/radeon: remove redundant assignment to reg
@ 2022-01-24 20:21 ` Nick Desaulniers
0 siblings, 0 replies; 7+ messages in thread
From: Nick Desaulniers @ 2022-01-24 20:21 UTC (permalink / raw)
To: Colin Ian King
Cc: llvm, David Airlie, Xinhui.Pan, kernel-janitors, linux-kernel,
amd-gfx, dri-devel, Daniel Vetter, Alex Deucher,
Christian König
On Wed, Jan 19, 2022 at 2:46 PM Colin Ian King <colin.i.king@gmail.com> wrote:
>
> The pointer reg is being assigned a value that is not read, the
> exit path via label 'out' never accesses it. The assignment is
> redundant and can be removed.
>
> Cleans up clang scan build warning:
> drivers/gpu/drm/radeon/radeon_object.c:570:3: warning: Value
> stored to 'reg' is never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Thanks for the patch!
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
> ---
> drivers/gpu/drm/radeon/radeon_object.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c
> index 56ede9d63b12..87536d205593 100644
> --- a/drivers/gpu/drm/radeon/radeon_object.c
> +++ b/drivers/gpu/drm/radeon/radeon_object.c
> @@ -567,7 +567,6 @@ int radeon_bo_get_surface_reg(struct radeon_bo *bo)
> return 0;
>
> if (bo->surface_reg >= 0) {
> - reg = &rdev->surface_regs[bo->surface_reg];
> i = bo->surface_reg;
> goto out;
> }
> --
> 2.33.1
>
>
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] drm/radeon: remove redundant assignment to reg
@ 2022-01-24 20:21 ` Nick Desaulniers
0 siblings, 0 replies; 7+ messages in thread
From: Nick Desaulniers @ 2022-01-24 20:21 UTC (permalink / raw)
To: Colin Ian King
Cc: Alex Deucher, Christian König, Xinhui.Pan, David Airlie,
Daniel Vetter, amd-gfx, dri-devel, kernel-janitors, linux-kernel,
llvm
On Wed, Jan 19, 2022 at 2:46 PM Colin Ian King <colin.i.king@gmail.com> wrote:
>
> The pointer reg is being assigned a value that is not read, the
> exit path via label 'out' never accesses it. The assignment is
> redundant and can be removed.
>
> Cleans up clang scan build warning:
> drivers/gpu/drm/radeon/radeon_object.c:570:3: warning: Value
> stored to 'reg' is never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Thanks for the patch!
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
> ---
> drivers/gpu/drm/radeon/radeon_object.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c
> index 56ede9d63b12..87536d205593 100644
> --- a/drivers/gpu/drm/radeon/radeon_object.c
> +++ b/drivers/gpu/drm/radeon/radeon_object.c
> @@ -567,7 +567,6 @@ int radeon_bo_get_surface_reg(struct radeon_bo *bo)
> return 0;
>
> if (bo->surface_reg >= 0) {
> - reg = &rdev->surface_regs[bo->surface_reg];
> i = bo->surface_reg;
> goto out;
> }
> --
> 2.33.1
>
>
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] drm/radeon: remove redundant assignment to reg
2022-01-24 20:21 ` Nick Desaulniers
@ 2022-01-24 22:09 ` Alex Deucher
-1 siblings, 0 replies; 7+ messages in thread
From: Alex Deucher @ 2022-01-24 22:09 UTC (permalink / raw)
To: Nick Desaulniers
Cc: llvm, David Airlie, xinhui pan, kernel-janitors, LKML,
amd-gfx list, Maling list - DRI developers, Alex Deucher,
Christian König, Colin Ian King
Applied. Thanks!
Alex
On Mon, Jan 24, 2022 at 3:21 PM Nick Desaulniers
<ndesaulniers@google.com> wrote:
>
> On Wed, Jan 19, 2022 at 2:46 PM Colin Ian King <colin.i.king@gmail.com> wrote:
> >
> > The pointer reg is being assigned a value that is not read, the
> > exit path via label 'out' never accesses it. The assignment is
> > redundant and can be removed.
> >
> > Cleans up clang scan build warning:
> > drivers/gpu/drm/radeon/radeon_object.c:570:3: warning: Value
> > stored to 'reg' is never read [deadcode.DeadStores]
> >
> > Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>
> Thanks for the patch!
> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
>
> > ---
> > drivers/gpu/drm/radeon/radeon_object.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c
> > index 56ede9d63b12..87536d205593 100644
> > --- a/drivers/gpu/drm/radeon/radeon_object.c
> > +++ b/drivers/gpu/drm/radeon/radeon_object.c
> > @@ -567,7 +567,6 @@ int radeon_bo_get_surface_reg(struct radeon_bo *bo)
> > return 0;
> >
> > if (bo->surface_reg >= 0) {
> > - reg = &rdev->surface_regs[bo->surface_reg];
> > i = bo->surface_reg;
> > goto out;
> > }
> > --
> > 2.33.1
> >
> >
>
>
> --
> Thanks,
> ~Nick Desaulniers
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] drm/radeon: remove redundant assignment to reg
@ 2022-01-24 22:09 ` Alex Deucher
0 siblings, 0 replies; 7+ messages in thread
From: Alex Deucher @ 2022-01-24 22:09 UTC (permalink / raw)
To: Nick Desaulniers
Cc: Colin Ian King, llvm, David Airlie, xinhui pan, kernel-janitors,
LKML, amd-gfx list, Maling list - DRI developers, Alex Deucher,
Christian König
Applied. Thanks!
Alex
On Mon, Jan 24, 2022 at 3:21 PM Nick Desaulniers
<ndesaulniers@google.com> wrote:
>
> On Wed, Jan 19, 2022 at 2:46 PM Colin Ian King <colin.i.king@gmail.com> wrote:
> >
> > The pointer reg is being assigned a value that is not read, the
> > exit path via label 'out' never accesses it. The assignment is
> > redundant and can be removed.
> >
> > Cleans up clang scan build warning:
> > drivers/gpu/drm/radeon/radeon_object.c:570:3: warning: Value
> > stored to 'reg' is never read [deadcode.DeadStores]
> >
> > Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>
> Thanks for the patch!
> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
>
> > ---
> > drivers/gpu/drm/radeon/radeon_object.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c
> > index 56ede9d63b12..87536d205593 100644
> > --- a/drivers/gpu/drm/radeon/radeon_object.c
> > +++ b/drivers/gpu/drm/radeon/radeon_object.c
> > @@ -567,7 +567,6 @@ int radeon_bo_get_surface_reg(struct radeon_bo *bo)
> > return 0;
> >
> > if (bo->surface_reg >= 0) {
> > - reg = &rdev->surface_regs[bo->surface_reg];
> > i = bo->surface_reg;
> > goto out;
> > }
> > --
> > 2.33.1
> >
> >
>
>
> --
> Thanks,
> ~Nick Desaulniers
^ permalink raw reply [flat|nested] 7+ messages in thread