* [PATCH] drm/amdgpu: Fix rejecting Tahiti GPUs
@ 2022-01-14 6:51 ` Lukas Fink
0 siblings, 0 replies; 6+ messages in thread
From: Lukas Fink @ 2022-01-14 6:51 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, Xinhui.Pan
Cc: amd-gfx, linux-kernel, Lukas Fink
eb4fd29afd4a ("drm/amdgpu: bind to any 0x1002 PCI diplay class device") added
generic bindings to amdgpu so that that it binds to all display class devices
with VID 0x1002 and then rejects those in amdgpu_pci_probe.
Unfortunately it reuses a driver_data value of 0 to detect those new bindings,
which is already used to denote CHIP_TAHITI ASICs.
The driver_data value given to those new bindings was changed in
dd0761fd24ea1 ("drm/amdgpu: set CHIP_IP_DISCOVERY as the asic type by default")
to CHIP_IP_DISCOVERY (=36), but it seems that the check in amdgpu_pci_probe
was forgotten to be changed. Therefore, it still rejects Tahiti GPUs.
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1860
Fixes: eb4fd29afd4a ("drm/amdgpu: bind to any 0x1002 PCI diplay class device")
Signed-off-by: Lukas Fink <lukas.fink1@gmail.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index 9ec58bf74012..224d073022ac 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
@@ -1903,7 +1903,7 @@ static int amdgpu_pci_probe(struct pci_dev *pdev,
return -ENODEV;
}
- if (flags == 0) {
+ if (flags == CHIP_IP_DISCOVERY) {
DRM_INFO("Unsupported asic. Remove me when IP discovery init is in place.\n");
return -ENODEV;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] drm/amdgpu: Fix rejecting Tahiti GPUs
@ 2022-01-14 6:51 ` Lukas Fink
0 siblings, 0 replies; 6+ messages in thread
From: Lukas Fink @ 2022-01-14 6:51 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, Xinhui.Pan
Cc: linux-kernel, amd-gfx, Lukas Fink
eb4fd29afd4a ("drm/amdgpu: bind to any 0x1002 PCI diplay class device") added
generic bindings to amdgpu so that that it binds to all display class devices
with VID 0x1002 and then rejects those in amdgpu_pci_probe.
Unfortunately it reuses a driver_data value of 0 to detect those new bindings,
which is already used to denote CHIP_TAHITI ASICs.
The driver_data value given to those new bindings was changed in
dd0761fd24ea1 ("drm/amdgpu: set CHIP_IP_DISCOVERY as the asic type by default")
to CHIP_IP_DISCOVERY (=36), but it seems that the check in amdgpu_pci_probe
was forgotten to be changed. Therefore, it still rejects Tahiti GPUs.
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1860
Fixes: eb4fd29afd4a ("drm/amdgpu: bind to any 0x1002 PCI diplay class device")
Signed-off-by: Lukas Fink <lukas.fink1@gmail.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index 9ec58bf74012..224d073022ac 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
@@ -1903,7 +1903,7 @@ static int amdgpu_pci_probe(struct pci_dev *pdev,
return -ENODEV;
}
- if (flags == 0) {
+ if (flags == CHIP_IP_DISCOVERY) {
DRM_INFO("Unsupported asic. Remove me when IP discovery init is in place.\n");
return -ENODEV;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] drm/amdgpu: Fix rejecting Tahiti GPUs
2022-01-14 6:51 ` Lukas Fink
@ 2022-01-14 14:56 ` Alex Deucher
-1 siblings, 0 replies; 6+ messages in thread
From: Alex Deucher @ 2022-01-14 14:56 UTC (permalink / raw)
To: Lukas Fink
Cc: Deucher, Alexander, Christian Koenig, xinhui pan, LKML, amd-gfx list
On Fri, Jan 14, 2022 at 3:27 AM Lukas Fink <lukas.fink1@gmail.com> wrote:
>
> eb4fd29afd4a ("drm/amdgpu: bind to any 0x1002 PCI diplay class device") added
> generic bindings to amdgpu so that that it binds to all display class devices
> with VID 0x1002 and then rejects those in amdgpu_pci_probe.
>
> Unfortunately it reuses a driver_data value of 0 to detect those new bindings,
> which is already used to denote CHIP_TAHITI ASICs.
>
> The driver_data value given to those new bindings was changed in
> dd0761fd24ea1 ("drm/amdgpu: set CHIP_IP_DISCOVERY as the asic type by default")
> to CHIP_IP_DISCOVERY (=36), but it seems that the check in amdgpu_pci_probe
> was forgotten to be changed. Therefore, it still rejects Tahiti GPUs.
>
> Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1860
> Fixes: eb4fd29afd4a ("drm/amdgpu: bind to any 0x1002 PCI diplay class device")
>
> Signed-off-by: Lukas Fink <lukas.fink1@gmail.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index 9ec58bf74012..224d073022ac 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -1903,7 +1903,7 @@ static int amdgpu_pci_probe(struct pci_dev *pdev,
> return -ENODEV;
> }
>
> - if (flags == 0) {
> + if (flags == CHIP_IP_DISCOVERY) {
> DRM_INFO("Unsupported asic. Remove me when IP discovery init is in place.\n");
> return -ENODEV;
> }
Thanks. Actually this entire check can be removed at this point. The
IP discovery support is in place. I'll send a patch.
Alex
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/amdgpu: Fix rejecting Tahiti GPUs
@ 2022-01-14 14:56 ` Alex Deucher
0 siblings, 0 replies; 6+ messages in thread
From: Alex Deucher @ 2022-01-14 14:56 UTC (permalink / raw)
To: Lukas Fink
Cc: Deucher, Alexander, xinhui pan, Christian Koenig, amd-gfx list, LKML
On Fri, Jan 14, 2022 at 3:27 AM Lukas Fink <lukas.fink1@gmail.com> wrote:
>
> eb4fd29afd4a ("drm/amdgpu: bind to any 0x1002 PCI diplay class device") added
> generic bindings to amdgpu so that that it binds to all display class devices
> with VID 0x1002 and then rejects those in amdgpu_pci_probe.
>
> Unfortunately it reuses a driver_data value of 0 to detect those new bindings,
> which is already used to denote CHIP_TAHITI ASICs.
>
> The driver_data value given to those new bindings was changed in
> dd0761fd24ea1 ("drm/amdgpu: set CHIP_IP_DISCOVERY as the asic type by default")
> to CHIP_IP_DISCOVERY (=36), but it seems that the check in amdgpu_pci_probe
> was forgotten to be changed. Therefore, it still rejects Tahiti GPUs.
>
> Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1860
> Fixes: eb4fd29afd4a ("drm/amdgpu: bind to any 0x1002 PCI diplay class device")
>
> Signed-off-by: Lukas Fink <lukas.fink1@gmail.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index 9ec58bf74012..224d073022ac 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -1903,7 +1903,7 @@ static int amdgpu_pci_probe(struct pci_dev *pdev,
> return -ENODEV;
> }
>
> - if (flags == 0) {
> + if (flags == CHIP_IP_DISCOVERY) {
> DRM_INFO("Unsupported asic. Remove me when IP discovery init is in place.\n");
> return -ENODEV;
> }
Thanks. Actually this entire check can be removed at this point. The
IP discovery support is in place. I'll send a patch.
Alex
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/amdgpu: Fix rejecting Tahiti GPUs
2022-01-14 14:56 ` Alex Deucher
@ 2022-01-14 14:58 ` Alex Deucher
-1 siblings, 0 replies; 6+ messages in thread
From: Alex Deucher @ 2022-01-14 14:58 UTC (permalink / raw)
To: Lukas Fink
Cc: Deucher, Alexander, Christian Koenig, xinhui pan, LKML, amd-gfx list
On Fri, Jan 14, 2022 at 9:56 AM Alex Deucher <alexdeucher@gmail.com> wrote:
>
> On Fri, Jan 14, 2022 at 3:27 AM Lukas Fink <lukas.fink1@gmail.com> wrote:
> >
> > eb4fd29afd4a ("drm/amdgpu: bind to any 0x1002 PCI diplay class device") added
> > generic bindings to amdgpu so that that it binds to all display class devices
> > with VID 0x1002 and then rejects those in amdgpu_pci_probe.
> >
> > Unfortunately it reuses a driver_data value of 0 to detect those new bindings,
> > which is already used to denote CHIP_TAHITI ASICs.
> >
> > The driver_data value given to those new bindings was changed in
> > dd0761fd24ea1 ("drm/amdgpu: set CHIP_IP_DISCOVERY as the asic type by default")
> > to CHIP_IP_DISCOVERY (=36), but it seems that the check in amdgpu_pci_probe
> > was forgotten to be changed. Therefore, it still rejects Tahiti GPUs.
> >
> > Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1860
> > Fixes: eb4fd29afd4a ("drm/amdgpu: bind to any 0x1002 PCI diplay class device")
> >
> > Signed-off-by: Lukas Fink <lukas.fink1@gmail.com>
> > ---
> > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> > index 9ec58bf74012..224d073022ac 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> > @@ -1903,7 +1903,7 @@ static int amdgpu_pci_probe(struct pci_dev *pdev,
> > return -ENODEV;
> > }
> >
> > - if (flags == 0) {
> > + if (flags == CHIP_IP_DISCOVERY) {
> > DRM_INFO("Unsupported asic. Remove me when IP discovery init is in place.\n");
> > return -ENODEV;
> > }
>
> Thanks. Actually this entire check can be removed at this point. The
> IP discovery support is in place. I'll send a patch.
Actually, I'll take this patch and then send a patch to remove it on
top of that. Thanks for fixing this.
Alex
>
> Alex
>
>
> > --
> > 2.34.1
> >
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/amdgpu: Fix rejecting Tahiti GPUs
@ 2022-01-14 14:58 ` Alex Deucher
0 siblings, 0 replies; 6+ messages in thread
From: Alex Deucher @ 2022-01-14 14:58 UTC (permalink / raw)
To: Lukas Fink
Cc: Deucher, Alexander, xinhui pan, Christian Koenig, amd-gfx list, LKML
On Fri, Jan 14, 2022 at 9:56 AM Alex Deucher <alexdeucher@gmail.com> wrote:
>
> On Fri, Jan 14, 2022 at 3:27 AM Lukas Fink <lukas.fink1@gmail.com> wrote:
> >
> > eb4fd29afd4a ("drm/amdgpu: bind to any 0x1002 PCI diplay class device") added
> > generic bindings to amdgpu so that that it binds to all display class devices
> > with VID 0x1002 and then rejects those in amdgpu_pci_probe.
> >
> > Unfortunately it reuses a driver_data value of 0 to detect those new bindings,
> > which is already used to denote CHIP_TAHITI ASICs.
> >
> > The driver_data value given to those new bindings was changed in
> > dd0761fd24ea1 ("drm/amdgpu: set CHIP_IP_DISCOVERY as the asic type by default")
> > to CHIP_IP_DISCOVERY (=36), but it seems that the check in amdgpu_pci_probe
> > was forgotten to be changed. Therefore, it still rejects Tahiti GPUs.
> >
> > Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1860
> > Fixes: eb4fd29afd4a ("drm/amdgpu: bind to any 0x1002 PCI diplay class device")
> >
> > Signed-off-by: Lukas Fink <lukas.fink1@gmail.com>
> > ---
> > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> > index 9ec58bf74012..224d073022ac 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> > @@ -1903,7 +1903,7 @@ static int amdgpu_pci_probe(struct pci_dev *pdev,
> > return -ENODEV;
> > }
> >
> > - if (flags == 0) {
> > + if (flags == CHIP_IP_DISCOVERY) {
> > DRM_INFO("Unsupported asic. Remove me when IP discovery init is in place.\n");
> > return -ENODEV;
> > }
>
> Thanks. Actually this entire check can be removed at this point. The
> IP discovery support is in place. I'll send a patch.
Actually, I'll take this patch and then send a patch to remove it on
top of that. Thanks for fixing this.
Alex
>
> Alex
>
>
> > --
> > 2.34.1
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-01-14 14:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-14 6:51 [PATCH] drm/amdgpu: Fix rejecting Tahiti GPUs Lukas Fink
2022-01-14 6:51 ` Lukas Fink
2022-01-14 14:56 ` Alex Deucher
2022-01-14 14:56 ` Alex Deucher
2022-01-14 14:58 ` Alex Deucher
2022-01-14 14:58 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.