All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Deucher <alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Quan, Evan" <Evan.Quan-5C7GfCeVMHo@public.gmane.org>
Cc: "Li, Candice" <Candice.Li-5C7GfCeVMHo@public.gmane.org>,
	"amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
	<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
	"Freehill, Chris" <Chris.Freehill-5C7GfCeVMHo@public.gmane.org>
Subject: Re: [PATCH] drm/amd/powerplay: correct Arcturus OD support
Date: Thu, 7 Nov 2019 08:57:41 -0500	[thread overview]
Message-ID: <CADnq5_PxWYGE1-uL+pey-Rwj6EiP2EuO+Y4N7aYNL85P3QOeUw@mail.gmail.com> (raw)
In-Reply-To: <20191107073817.27624-1-evan.quan-5C7GfCeVMHo@public.gmane.org>

On Thu, Nov 7, 2019 at 2:38 AM Quan, Evan <Evan.Quan@amd.com> wrote:
>
> OD is not supported on Arcturus. Thus the
> pp_od_clk_voltage sysfs interface is also not supported.
>
> Change-Id: Ib70632a55a0980cf04c3432d43dbcf869cd1b4bf
> Signed-off-by: Evan Quan <evan.quan@amd.com>

You might want to check with Chris and Kent about this.  I think there
is a use case for OD on ROCm in some cases.  Assuming they are ok with
it,
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

Alex

> ---
>  drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
> index c21fe7ac5df8..76a4154b3be2 100644
> --- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
> +++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
> @@ -714,6 +714,9 @@ static int smu_set_funcs(struct amdgpu_device *adev)
>  {
>         struct smu_context *smu = &adev->smu;
>
> +       if (adev->pm.pp_feature & PP_OVERDRIVE_MASK)
> +               smu->od_enabled = true;
> +
>         switch (adev->asic_type) {
>         case CHIP_VEGA20:
>                 vega20_set_ppt_funcs(smu);
> @@ -725,6 +728,8 @@ static int smu_set_funcs(struct amdgpu_device *adev)
>                 break;
>         case CHIP_ARCTURUS:
>                 arcturus_set_ppt_funcs(smu);
> +               /* OD is not supported on Arcturus */
> +               smu->od_enabled =false;
>                 break;
>         case CHIP_RENOIR:
>                 renoir_set_ppt_funcs(smu);
> @@ -733,9 +738,6 @@ static int smu_set_funcs(struct amdgpu_device *adev)
>                 return -EINVAL;
>         }
>
> -       if (adev->pm.pp_feature & PP_OVERDRIVE_MASK)
> -               smu->od_enabled = true;
> -
>         return 0;
>  }
>
> --
> 2.23.0
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Alex Deucher <alexdeucher@gmail.com>
To: "Quan, Evan" <Evan.Quan@amd.com>
Cc: "Li, Candice" <Candice.Li@amd.com>,
	"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
	"Freehill, Chris" <Chris.Freehill@amd.com>
Subject: Re: [PATCH] drm/amd/powerplay: correct Arcturus OD support
Date: Thu, 7 Nov 2019 08:57:41 -0500	[thread overview]
Message-ID: <CADnq5_PxWYGE1-uL+pey-Rwj6EiP2EuO+Y4N7aYNL85P3QOeUw@mail.gmail.com> (raw)
Message-ID: <20191107135741.OabBoqErUE05ojhxmfaSzsZ26OYS5TgoQmII-_JthWM@z> (raw)
In-Reply-To: <20191107073817.27624-1-evan.quan@amd.com>

On Thu, Nov 7, 2019 at 2:38 AM Quan, Evan <Evan.Quan@amd.com> wrote:
>
> OD is not supported on Arcturus. Thus the
> pp_od_clk_voltage sysfs interface is also not supported.
>
> Change-Id: Ib70632a55a0980cf04c3432d43dbcf869cd1b4bf
> Signed-off-by: Evan Quan <evan.quan@amd.com>

You might want to check with Chris and Kent about this.  I think there
is a use case for OD on ROCm in some cases.  Assuming they are ok with
it,
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

Alex

> ---
>  drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
> index c21fe7ac5df8..76a4154b3be2 100644
> --- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
> +++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
> @@ -714,6 +714,9 @@ static int smu_set_funcs(struct amdgpu_device *adev)
>  {
>         struct smu_context *smu = &adev->smu;
>
> +       if (adev->pm.pp_feature & PP_OVERDRIVE_MASK)
> +               smu->od_enabled = true;
> +
>         switch (adev->asic_type) {
>         case CHIP_VEGA20:
>                 vega20_set_ppt_funcs(smu);
> @@ -725,6 +728,8 @@ static int smu_set_funcs(struct amdgpu_device *adev)
>                 break;
>         case CHIP_ARCTURUS:
>                 arcturus_set_ppt_funcs(smu);
> +               /* OD is not supported on Arcturus */
> +               smu->od_enabled =false;
>                 break;
>         case CHIP_RENOIR:
>                 renoir_set_ppt_funcs(smu);
> @@ -733,9 +738,6 @@ static int smu_set_funcs(struct amdgpu_device *adev)
>                 return -EINVAL;
>         }
>
> -       if (adev->pm.pp_feature & PP_OVERDRIVE_MASK)
> -               smu->od_enabled = true;
> -
>         return 0;
>  }
>
> --
> 2.23.0
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2019-11-07 13:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-07  7:38 [PATCH] drm/amd/powerplay: correct Arcturus OD support Quan, Evan
2019-11-07  7:38 ` Quan, Evan
     [not found] ` <20191107073817.27624-1-evan.quan-5C7GfCeVMHo@public.gmane.org>
2019-11-07 13:57   ` Alex Deucher [this message]
2019-11-07 13:57     ` Alex Deucher
     [not found]     ` <CADnq5_PxWYGE1-uL+pey-Rwj6EiP2EuO+Y4N7aYNL85P3QOeUw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-11-07 14:05       ` Russell, Kent
2019-11-07 14:05         ` Russell, Kent
     [not found]         ` <CY4PR1201MB2533B1569C97729EA15C8B8085780-1iTaO6aE1DCmssYNuJz6EmrFom/aUZj6nBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2019-11-07 14:14           ` Freehill, Chris
2019-11-07 14:14             ` Freehill, Chris
2019-11-08  2:44   ` Feng, Kenneth
2019-11-08  2:44     ` Feng, Kenneth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADnq5_PxWYGE1-uL+pey-Rwj6EiP2EuO+Y4N7aYNL85P3QOeUw@mail.gmail.com \
    --to=alexdeucher-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=Candice.Li-5C7GfCeVMHo@public.gmane.org \
    --cc=Chris.Freehill-5C7GfCeVMHo@public.gmane.org \
    --cc=Evan.Quan-5C7GfCeVMHo@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.