* [PATCH] drm/amd/powerplay: correct Arcturus OD support @ 2019-11-07 7:38 ` Quan, Evan 0 siblings, 0 replies; 10+ messages in thread From: Quan, Evan @ 2019-11-07 7:38 UTC (permalink / raw) To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW Cc: Li, Candice, Quan, Evan, Freehill, Chris OD is not supported on Arcturus. Thus the pp_od_clk_voltage sysfs interface is also not supported. Change-Id: Ib70632a55a0980cf04c3432d43dbcf869cd1b4bf Signed-off-by: Evan Quan <evan.quan@amd.com> --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c index c21fe7ac5df8..76a4154b3be2 100644 --- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c +++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c @@ -714,6 +714,9 @@ static int smu_set_funcs(struct amdgpu_device *adev) { struct smu_context *smu = &adev->smu; + if (adev->pm.pp_feature & PP_OVERDRIVE_MASK) + smu->od_enabled = true; + switch (adev->asic_type) { case CHIP_VEGA20: vega20_set_ppt_funcs(smu); @@ -725,6 +728,8 @@ static int smu_set_funcs(struct amdgpu_device *adev) break; case CHIP_ARCTURUS: arcturus_set_ppt_funcs(smu); + /* OD is not supported on Arcturus */ + smu->od_enabled =false; break; case CHIP_RENOIR: renoir_set_ppt_funcs(smu); @@ -733,9 +738,6 @@ static int smu_set_funcs(struct amdgpu_device *adev) return -EINVAL; } - if (adev->pm.pp_feature & PP_OVERDRIVE_MASK) - smu->od_enabled = true; - return 0; } -- 2.23.0 _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] drm/amd/powerplay: correct Arcturus OD support @ 2019-11-07 7:38 ` Quan, Evan 0 siblings, 0 replies; 10+ messages in thread From: Quan, Evan @ 2019-11-07 7:38 UTC (permalink / raw) To: amd-gfx; +Cc: Li, Candice, Quan, Evan, Freehill, Chris OD is not supported on Arcturus. Thus the pp_od_clk_voltage sysfs interface is also not supported. Change-Id: Ib70632a55a0980cf04c3432d43dbcf869cd1b4bf Signed-off-by: Evan Quan <evan.quan@amd.com> --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c index c21fe7ac5df8..76a4154b3be2 100644 --- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c +++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c @@ -714,6 +714,9 @@ static int smu_set_funcs(struct amdgpu_device *adev) { struct smu_context *smu = &adev->smu; + if (adev->pm.pp_feature & PP_OVERDRIVE_MASK) + smu->od_enabled = true; + switch (adev->asic_type) { case CHIP_VEGA20: vega20_set_ppt_funcs(smu); @@ -725,6 +728,8 @@ static int smu_set_funcs(struct amdgpu_device *adev) break; case CHIP_ARCTURUS: arcturus_set_ppt_funcs(smu); + /* OD is not supported on Arcturus */ + smu->od_enabled =false; break; case CHIP_RENOIR: renoir_set_ppt_funcs(smu); @@ -733,9 +738,6 @@ static int smu_set_funcs(struct amdgpu_device *adev) return -EINVAL; } - if (adev->pm.pp_feature & PP_OVERDRIVE_MASK) - smu->od_enabled = true; - return 0; } -- 2.23.0 _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply related [flat|nested] 10+ messages in thread
[parent not found: <20191107073817.27624-1-evan.quan-5C7GfCeVMHo@public.gmane.org>]
* Re: [PATCH] drm/amd/powerplay: correct Arcturus OD support @ 2019-11-07 13:57 ` Alex Deucher 0 siblings, 0 replies; 10+ messages in thread From: Alex Deucher @ 2019-11-07 13:57 UTC (permalink / raw) To: Quan, Evan Cc: Li, Candice, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Freehill, Chris On Thu, Nov 7, 2019 at 2:38 AM Quan, Evan <Evan.Quan@amd.com> wrote: > > OD is not supported on Arcturus. Thus the > pp_od_clk_voltage sysfs interface is also not supported. > > Change-Id: Ib70632a55a0980cf04c3432d43dbcf869cd1b4bf > Signed-off-by: Evan Quan <evan.quan@amd.com> You might want to check with Chris and Kent about this. I think there is a use case for OD on ROCm in some cases. Assuming they are ok with it, Reviewed-by: Alex Deucher <alexander.deucher@amd.com> Alex > --- > drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c > index c21fe7ac5df8..76a4154b3be2 100644 > --- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c > +++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c > @@ -714,6 +714,9 @@ static int smu_set_funcs(struct amdgpu_device *adev) > { > struct smu_context *smu = &adev->smu; > > + if (adev->pm.pp_feature & PP_OVERDRIVE_MASK) > + smu->od_enabled = true; > + > switch (adev->asic_type) { > case CHIP_VEGA20: > vega20_set_ppt_funcs(smu); > @@ -725,6 +728,8 @@ static int smu_set_funcs(struct amdgpu_device *adev) > break; > case CHIP_ARCTURUS: > arcturus_set_ppt_funcs(smu); > + /* OD is not supported on Arcturus */ > + smu->od_enabled =false; > break; > case CHIP_RENOIR: > renoir_set_ppt_funcs(smu); > @@ -733,9 +738,6 @@ static int smu_set_funcs(struct amdgpu_device *adev) > return -EINVAL; > } > > - if (adev->pm.pp_feature & PP_OVERDRIVE_MASK) > - smu->od_enabled = true; > - > return 0; > } > > -- > 2.23.0 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] drm/amd/powerplay: correct Arcturus OD support @ 2019-11-07 13:57 ` Alex Deucher 0 siblings, 0 replies; 10+ messages in thread From: Alex Deucher @ 2019-11-07 13:57 UTC (permalink / raw) To: Quan, Evan; +Cc: Li, Candice, amd-gfx, Freehill, Chris On Thu, Nov 7, 2019 at 2:38 AM Quan, Evan <Evan.Quan@amd.com> wrote: > > OD is not supported on Arcturus. Thus the > pp_od_clk_voltage sysfs interface is also not supported. > > Change-Id: Ib70632a55a0980cf04c3432d43dbcf869cd1b4bf > Signed-off-by: Evan Quan <evan.quan@amd.com> You might want to check with Chris and Kent about this. I think there is a use case for OD on ROCm in some cases. Assuming they are ok with it, Reviewed-by: Alex Deucher <alexander.deucher@amd.com> Alex > --- > drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c > index c21fe7ac5df8..76a4154b3be2 100644 > --- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c > +++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c > @@ -714,6 +714,9 @@ static int smu_set_funcs(struct amdgpu_device *adev) > { > struct smu_context *smu = &adev->smu; > > + if (adev->pm.pp_feature & PP_OVERDRIVE_MASK) > + smu->od_enabled = true; > + > switch (adev->asic_type) { > case CHIP_VEGA20: > vega20_set_ppt_funcs(smu); > @@ -725,6 +728,8 @@ static int smu_set_funcs(struct amdgpu_device *adev) > break; > case CHIP_ARCTURUS: > arcturus_set_ppt_funcs(smu); > + /* OD is not supported on Arcturus */ > + smu->od_enabled =false; > break; > case CHIP_RENOIR: > renoir_set_ppt_funcs(smu); > @@ -733,9 +738,6 @@ static int smu_set_funcs(struct amdgpu_device *adev) > return -EINVAL; > } > > - if (adev->pm.pp_feature & PP_OVERDRIVE_MASK) > - smu->od_enabled = true; > - > return 0; > } > > -- > 2.23.0 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 10+ messages in thread
[parent not found: <CADnq5_PxWYGE1-uL+pey-Rwj6EiP2EuO+Y4N7aYNL85P3QOeUw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* RE: [PATCH] drm/amd/powerplay: correct Arcturus OD support @ 2019-11-07 14:05 ` Russell, Kent 0 siblings, 0 replies; 10+ messages in thread From: Russell, Kent @ 2019-11-07 14:05 UTC (permalink / raw) To: Alex Deucher, Quan, Evan Cc: Li, Candice, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Freehill, Chris While we do like OverDrive being available (mostly our open-source community users who are using consumer cards vs server cards), if it's not supported on the HW for whatever reason, we'll adapt. If we get a request later for its enablement (since OverDrive is consumer-card-only in general, and I personally haven't seen any Arcturus consumer cards), we can discuss then. It's fine with Chris and I in that regard. Kent -----Original Message----- From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Alex Deucher Sent: Thursday, November 7, 2019 8:58 AM To: Quan, Evan <Evan.Quan@amd.com> Cc: Li, Candice <Candice.Li@amd.com>; amd-gfx@lists.freedesktop.org; Freehill, Chris <Chris.Freehill@amd.com> Subject: Re: [PATCH] drm/amd/powerplay: correct Arcturus OD support On Thu, Nov 7, 2019 at 2:38 AM Quan, Evan <Evan.Quan@amd.com> wrote: > > OD is not supported on Arcturus. Thus the pp_od_clk_voltage sysfs > interface is also not supported. > > Change-Id: Ib70632a55a0980cf04c3432d43dbcf869cd1b4bf > Signed-off-by: Evan Quan <evan.quan@amd.com> You might want to check with Chris and Kent about this. I think there is a use case for OD on ROCm in some cases. Assuming they are ok with it, Reviewed-by: Alex Deucher <alexander.deucher@amd.com> Alex > --- > drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c > b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c > index c21fe7ac5df8..76a4154b3be2 100644 > --- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c > +++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c > @@ -714,6 +714,9 @@ static int smu_set_funcs(struct amdgpu_device > *adev) { > struct smu_context *smu = &adev->smu; > > + if (adev->pm.pp_feature & PP_OVERDRIVE_MASK) > + smu->od_enabled = true; > + > switch (adev->asic_type) { > case CHIP_VEGA20: > vega20_set_ppt_funcs(smu); @@ -725,6 +728,8 @@ static > int smu_set_funcs(struct amdgpu_device *adev) > break; > case CHIP_ARCTURUS: > arcturus_set_ppt_funcs(smu); > + /* OD is not supported on Arcturus */ > + smu->od_enabled =false; > break; > case CHIP_RENOIR: > renoir_set_ppt_funcs(smu); @@ -733,9 +738,6 @@ static > int smu_set_funcs(struct amdgpu_device *adev) > return -EINVAL; > } > > - if (adev->pm.pp_feature & PP_OVERDRIVE_MASK) > - smu->od_enabled = true; > - > return 0; > } > > -- > 2.23.0 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH] drm/amd/powerplay: correct Arcturus OD support @ 2019-11-07 14:05 ` Russell, Kent 0 siblings, 0 replies; 10+ messages in thread From: Russell, Kent @ 2019-11-07 14:05 UTC (permalink / raw) To: Alex Deucher, Quan, Evan; +Cc: Li, Candice, amd-gfx, Freehill, Chris While we do like OverDrive being available (mostly our open-source community users who are using consumer cards vs server cards), if it's not supported on the HW for whatever reason, we'll adapt. If we get a request later for its enablement (since OverDrive is consumer-card-only in general, and I personally haven't seen any Arcturus consumer cards), we can discuss then. It's fine with Chris and I in that regard. Kent -----Original Message----- From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Alex Deucher Sent: Thursday, November 7, 2019 8:58 AM To: Quan, Evan <Evan.Quan@amd.com> Cc: Li, Candice <Candice.Li@amd.com>; amd-gfx@lists.freedesktop.org; Freehill, Chris <Chris.Freehill@amd.com> Subject: Re: [PATCH] drm/amd/powerplay: correct Arcturus OD support On Thu, Nov 7, 2019 at 2:38 AM Quan, Evan <Evan.Quan@amd.com> wrote: > > OD is not supported on Arcturus. Thus the pp_od_clk_voltage sysfs > interface is also not supported. > > Change-Id: Ib70632a55a0980cf04c3432d43dbcf869cd1b4bf > Signed-off-by: Evan Quan <evan.quan@amd.com> You might want to check with Chris and Kent about this. I think there is a use case for OD on ROCm in some cases. Assuming they are ok with it, Reviewed-by: Alex Deucher <alexander.deucher@amd.com> Alex > --- > drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c > b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c > index c21fe7ac5df8..76a4154b3be2 100644 > --- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c > +++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c > @@ -714,6 +714,9 @@ static int smu_set_funcs(struct amdgpu_device > *adev) { > struct smu_context *smu = &adev->smu; > > + if (adev->pm.pp_feature & PP_OVERDRIVE_MASK) > + smu->od_enabled = true; > + > switch (adev->asic_type) { > case CHIP_VEGA20: > vega20_set_ppt_funcs(smu); @@ -725,6 +728,8 @@ static > int smu_set_funcs(struct amdgpu_device *adev) > break; > case CHIP_ARCTURUS: > arcturus_set_ppt_funcs(smu); > + /* OD is not supported on Arcturus */ > + smu->od_enabled =false; > break; > case CHIP_RENOIR: > renoir_set_ppt_funcs(smu); @@ -733,9 +738,6 @@ static > int smu_set_funcs(struct amdgpu_device *adev) > return -EINVAL; > } > > - if (adev->pm.pp_feature & PP_OVERDRIVE_MASK) > - smu->od_enabled = true; > - > return 0; > } > > -- > 2.23.0 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 10+ messages in thread
[parent not found: <CY4PR1201MB2533B1569C97729EA15C8B8085780-1iTaO6aE1DCmssYNuJz6EmrFom/aUZj6nBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>]
* RE: [PATCH] drm/amd/powerplay: correct Arcturus OD support @ 2019-11-07 14:14 ` Freehill, Chris 0 siblings, 0 replies; 10+ messages in thread From: Freehill, Chris @ 2019-11-07 14:14 UTC (permalink / raw) To: Russell, Kent, Alex Deucher, Quan, Evan Cc: Li, Candice, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW I think Kent has more insight with demand for this feature than I do, so I defer to his opinion. I haven't received any feedback on that API. Main thing is that if it's not supported, don't have the file visible. Thanks, Chris -----Original Message----- From: Russell, Kent <Kent.Russell@amd.com> Sent: Thursday, November 7, 2019 8:05 AM To: Alex Deucher <alexdeucher@gmail.com>; Quan, Evan <Evan.Quan@amd.com> Cc: Li, Candice <Candice.Li@amd.com>; amd-gfx@lists.freedesktop.org; Freehill, Chris <Chris.Freehill@amd.com> Subject: RE: [PATCH] drm/amd/powerplay: correct Arcturus OD support While we do like OverDrive being available (mostly our open-source community users who are using consumer cards vs server cards), if it's not supported on the HW for whatever reason, we'll adapt. If we get a request later for its enablement (since OverDrive is consumer-card-only in general, and I personally haven't seen any Arcturus consumer cards), we can discuss then. It's fine with Chris and I in that regard. Kent -----Original Message----- From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Alex Deucher Sent: Thursday, November 7, 2019 8:58 AM To: Quan, Evan <Evan.Quan@amd.com> Cc: Li, Candice <Candice.Li@amd.com>; amd-gfx@lists.freedesktop.org; Freehill, Chris <Chris.Freehill@amd.com> Subject: Re: [PATCH] drm/amd/powerplay: correct Arcturus OD support On Thu, Nov 7, 2019 at 2:38 AM Quan, Evan <Evan.Quan@amd.com> wrote: > > OD is not supported on Arcturus. Thus the pp_od_clk_voltage sysfs > interface is also not supported. > > Change-Id: Ib70632a55a0980cf04c3432d43dbcf869cd1b4bf > Signed-off-by: Evan Quan <evan.quan@amd.com> You might want to check with Chris and Kent about this. I think there is a use case for OD on ROCm in some cases. Assuming they are ok with it, Reviewed-by: Alex Deucher <alexander.deucher@amd.com> Alex > --- > drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c > b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c > index c21fe7ac5df8..76a4154b3be2 100644 > --- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c > +++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c > @@ -714,6 +714,9 @@ static int smu_set_funcs(struct amdgpu_device > *adev) { > struct smu_context *smu = &adev->smu; > > + if (adev->pm.pp_feature & PP_OVERDRIVE_MASK) > + smu->od_enabled = true; > + > switch (adev->asic_type) { > case CHIP_VEGA20: > vega20_set_ppt_funcs(smu); @@ -725,6 +728,8 @@ static > int smu_set_funcs(struct amdgpu_device *adev) > break; > case CHIP_ARCTURUS: > arcturus_set_ppt_funcs(smu); > + /* OD is not supported on Arcturus */ > + smu->od_enabled =false; > break; > case CHIP_RENOIR: > renoir_set_ppt_funcs(smu); @@ -733,9 +738,6 @@ static > int smu_set_funcs(struct amdgpu_device *adev) > return -EINVAL; > } > > - if (adev->pm.pp_feature & PP_OVERDRIVE_MASK) > - smu->od_enabled = true; > - > return 0; > } > > -- > 2.23.0 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH] drm/amd/powerplay: correct Arcturus OD support @ 2019-11-07 14:14 ` Freehill, Chris 0 siblings, 0 replies; 10+ messages in thread From: Freehill, Chris @ 2019-11-07 14:14 UTC (permalink / raw) To: Russell, Kent, Alex Deucher, Quan, Evan; +Cc: Li, Candice, amd-gfx I think Kent has more insight with demand for this feature than I do, so I defer to his opinion. I haven't received any feedback on that API. Main thing is that if it's not supported, don't have the file visible. Thanks, Chris -----Original Message----- From: Russell, Kent <Kent.Russell@amd.com> Sent: Thursday, November 7, 2019 8:05 AM To: Alex Deucher <alexdeucher@gmail.com>; Quan, Evan <Evan.Quan@amd.com> Cc: Li, Candice <Candice.Li@amd.com>; amd-gfx@lists.freedesktop.org; Freehill, Chris <Chris.Freehill@amd.com> Subject: RE: [PATCH] drm/amd/powerplay: correct Arcturus OD support While we do like OverDrive being available (mostly our open-source community users who are using consumer cards vs server cards), if it's not supported on the HW for whatever reason, we'll adapt. If we get a request later for its enablement (since OverDrive is consumer-card-only in general, and I personally haven't seen any Arcturus consumer cards), we can discuss then. It's fine with Chris and I in that regard. Kent -----Original Message----- From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Alex Deucher Sent: Thursday, November 7, 2019 8:58 AM To: Quan, Evan <Evan.Quan@amd.com> Cc: Li, Candice <Candice.Li@amd.com>; amd-gfx@lists.freedesktop.org; Freehill, Chris <Chris.Freehill@amd.com> Subject: Re: [PATCH] drm/amd/powerplay: correct Arcturus OD support On Thu, Nov 7, 2019 at 2:38 AM Quan, Evan <Evan.Quan@amd.com> wrote: > > OD is not supported on Arcturus. Thus the pp_od_clk_voltage sysfs > interface is also not supported. > > Change-Id: Ib70632a55a0980cf04c3432d43dbcf869cd1b4bf > Signed-off-by: Evan Quan <evan.quan@amd.com> You might want to check with Chris and Kent about this. I think there is a use case for OD on ROCm in some cases. Assuming they are ok with it, Reviewed-by: Alex Deucher <alexander.deucher@amd.com> Alex > --- > drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c > b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c > index c21fe7ac5df8..76a4154b3be2 100644 > --- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c > +++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c > @@ -714,6 +714,9 @@ static int smu_set_funcs(struct amdgpu_device > *adev) { > struct smu_context *smu = &adev->smu; > > + if (adev->pm.pp_feature & PP_OVERDRIVE_MASK) > + smu->od_enabled = true; > + > switch (adev->asic_type) { > case CHIP_VEGA20: > vega20_set_ppt_funcs(smu); @@ -725,6 +728,8 @@ static > int smu_set_funcs(struct amdgpu_device *adev) > break; > case CHIP_ARCTURUS: > arcturus_set_ppt_funcs(smu); > + /* OD is not supported on Arcturus */ > + smu->od_enabled =false; > break; > case CHIP_RENOIR: > renoir_set_ppt_funcs(smu); @@ -733,9 +738,6 @@ static > int smu_set_funcs(struct amdgpu_device *adev) > return -EINVAL; > } > > - if (adev->pm.pp_feature & PP_OVERDRIVE_MASK) > - smu->od_enabled = true; > - > return 0; > } > > -- > 2.23.0 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH] drm/amd/powerplay: correct Arcturus OD support @ 2019-11-08 2:44 ` Feng, Kenneth 0 siblings, 0 replies; 10+ messages in thread From: Feng, Kenneth @ 2019-11-08 2:44 UTC (permalink / raw) To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW Cc: Li, Candice, Quan, Evan, Freehill, Chris Reviewed-by: Kenneth Feng <kenneth.feng@amd.com> -----Original Message----- From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Quan, Evan Sent: Thursday, November 7, 2019 3:39 PM To: amd-gfx@lists.freedesktop.org Cc: Li, Candice <Candice.Li@amd.com>; Quan, Evan <Evan.Quan@amd.com>; Freehill, Chris <Chris.Freehill@amd.com> Subject: [PATCH] drm/amd/powerplay: correct Arcturus OD support [CAUTION: External Email] OD is not supported on Arcturus. Thus the pp_od_clk_voltage sysfs interface is also not supported. Change-Id: Ib70632a55a0980cf04c3432d43dbcf869cd1b4bf Signed-off-by: Evan Quan <evan.quan@amd.com> --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c index c21fe7ac5df8..76a4154b3be2 100644 --- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c +++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c @@ -714,6 +714,9 @@ static int smu_set_funcs(struct amdgpu_device *adev) { struct smu_context *smu = &adev->smu; + if (adev->pm.pp_feature & PP_OVERDRIVE_MASK) + smu->od_enabled = true; + switch (adev->asic_type) { case CHIP_VEGA20: vega20_set_ppt_funcs(smu); @@ -725,6 +728,8 @@ static int smu_set_funcs(struct amdgpu_device *adev) break; case CHIP_ARCTURUS: arcturus_set_ppt_funcs(smu); + /* OD is not supported on Arcturus */ + smu->od_enabled =false; break; case CHIP_RENOIR: renoir_set_ppt_funcs(smu); @@ -733,9 +738,6 @@ static int smu_set_funcs(struct amdgpu_device *adev) return -EINVAL; } - if (adev->pm.pp_feature & PP_OVERDRIVE_MASK) - smu->od_enabled = true; - return 0; } -- 2.23.0 _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply related [flat|nested] 10+ messages in thread
* RE: [PATCH] drm/amd/powerplay: correct Arcturus OD support @ 2019-11-08 2:44 ` Feng, Kenneth 0 siblings, 0 replies; 10+ messages in thread From: Feng, Kenneth @ 2019-11-08 2:44 UTC (permalink / raw) To: Quan, Evan, amd-gfx; +Cc: Li, Candice, Quan, Evan, Freehill, Chris Reviewed-by: Kenneth Feng <kenneth.feng@amd.com> -----Original Message----- From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Quan, Evan Sent: Thursday, November 7, 2019 3:39 PM To: amd-gfx@lists.freedesktop.org Cc: Li, Candice <Candice.Li@amd.com>; Quan, Evan <Evan.Quan@amd.com>; Freehill, Chris <Chris.Freehill@amd.com> Subject: [PATCH] drm/amd/powerplay: correct Arcturus OD support [CAUTION: External Email] OD is not supported on Arcturus. Thus the pp_od_clk_voltage sysfs interface is also not supported. Change-Id: Ib70632a55a0980cf04c3432d43dbcf869cd1b4bf Signed-off-by: Evan Quan <evan.quan@amd.com> --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c index c21fe7ac5df8..76a4154b3be2 100644 --- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c +++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c @@ -714,6 +714,9 @@ static int smu_set_funcs(struct amdgpu_device *adev) { struct smu_context *smu = &adev->smu; + if (adev->pm.pp_feature & PP_OVERDRIVE_MASK) + smu->od_enabled = true; + switch (adev->asic_type) { case CHIP_VEGA20: vega20_set_ppt_funcs(smu); @@ -725,6 +728,8 @@ static int smu_set_funcs(struct amdgpu_device *adev) break; case CHIP_ARCTURUS: arcturus_set_ppt_funcs(smu); + /* OD is not supported on Arcturus */ + smu->od_enabled =false; break; case CHIP_RENOIR: renoir_set_ppt_funcs(smu); @@ -733,9 +738,6 @@ static int smu_set_funcs(struct amdgpu_device *adev) return -EINVAL; } - if (adev->pm.pp_feature & PP_OVERDRIVE_MASK) - smu->od_enabled = true; - return 0; } -- 2.23.0 _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply related [flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-11-08 2:45 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-07 7:38 [PATCH] drm/amd/powerplay: correct Arcturus OD support Quan, Evan
2019-11-07 7:38 ` Quan, Evan
[not found] ` <20191107073817.27624-1-evan.quan-5C7GfCeVMHo@public.gmane.org>
2019-11-07 13:57 ` Alex Deucher
2019-11-07 13:57 ` Alex Deucher
[not found] ` <CADnq5_PxWYGE1-uL+pey-Rwj6EiP2EuO+Y4N7aYNL85P3QOeUw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-11-07 14:05 ` Russell, Kent
2019-11-07 14:05 ` Russell, Kent
[not found] ` <CY4PR1201MB2533B1569C97729EA15C8B8085780-1iTaO6aE1DCmssYNuJz6EmrFom/aUZj6nBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2019-11-07 14:14 ` Freehill, Chris
2019-11-07 14:14 ` Freehill, Chris
2019-11-08 2:44 ` Feng, Kenneth
2019-11-08 2:44 ` Feng, Kenneth
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.