From: Peter Griffin <peter.griffin@linaro.org> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, conor+dt@kernel.org, sboyd@kernel.org, tomasz.figa@gmail.com, s.nawrocki@samsung.com, linus.walleij@linaro.org, wim@linux-watchdog.org, linux@roeck-us.net, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, olof@lixom.net, gregkh@linuxfoundation.org, jirislaby@kernel.org, cw00.choi@samsung.com, alim.akhtar@samsung.com, tudor.ambarus@linaro.org, andre.draszik@linaro.org, semen.protsenko@linaro.org, saravanak@google.com, willmcvicker@google.com, soc@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-watchdog@vger.kernel.org, kernel-team@android.com, linux-serial@vger.kernel.org Subject: Re: [PATCH v6 13/20] pinctrl: samsung: Add gs101 SoC pinctrl configuration Date: Mon, 11 Dec 2023 11:35:39 +0000 [thread overview] Message-ID: <CADrjBPr6k-j=swq8zJfOjaYQW7hvWCTXj2ZZQT6V+QUtjEYOcg@mail.gmail.com> (raw) In-Reply-To: <46c9c8b4-942d-4f6f-a6cc-00158314d5e5@linaro.org> Hi Krzysztof, Thanks for the review. On Sun, 10 Dec 2023 at 13:56, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 10/12/2023 00:30, Peter Griffin wrote: > > Add support for the pin-controller found on the gs101 SoC used in > > Pixel 6 phones. > > > > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > > --- > > > > diff --git a/drivers/pinctrl/samsung/pinctrl-exynos.c b/drivers/pinctrl/samsung/pinctrl-exynos.c > > index 6b58ec84e34b..3834bf953178 100644 > > --- a/drivers/pinctrl/samsung/pinctrl-exynos.c > > +++ b/drivers/pinctrl/samsung/pinctrl-exynos.c > > @@ -468,6 +468,8 @@ static const struct of_device_id exynos_wkup_irq_ids[] = { > > .data = &exynos7_wkup_irq_chip }, > > { .compatible = "samsung,exynosautov9-wakeup-eint", > > .data = &exynos7_wkup_irq_chip }, > > + { .compatible = "google,gs101-wakeup-eint", > > + .data = &exynos7_wkup_irq_chip }, > > You don't need it. OK will drop > > > { } > > }; > > > > diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c > > index 79babbb39ced..b8d549fe38cb 100644 > > --- a/drivers/pinctrl/samsung/pinctrl-samsung.c > > +++ b/drivers/pinctrl/samsung/pinctrl-samsung.c > > @@ -1321,6 +1321,8 @@ static const struct of_device_id samsung_pinctrl_dt_match[] = { > > .data = &exynosautov9_of_data }, > > { .compatible = "tesla,fsd-pinctrl", > > .data = &fsd_of_data }, > > + { .compatible = "google,gs101-pinctrl", > > + .data = &gs101_of_data }, > > Place it somewhere alphabetically. Probably before tesla. Will fix. FYI I was intending to put it at the top ('g' before 's') that also matches the ordering everywhere else e.g. in the YAML docs etc. regards, Peter
WARNING: multiple messages have this Message-ID (diff)
From: Peter Griffin <peter.griffin@linaro.org> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, conor+dt@kernel.org, sboyd@kernel.org, tomasz.figa@gmail.com, s.nawrocki@samsung.com, linus.walleij@linaro.org, wim@linux-watchdog.org, linux@roeck-us.net, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, olof@lixom.net, gregkh@linuxfoundation.org, jirislaby@kernel.org, cw00.choi@samsung.com, alim.akhtar@samsung.com, tudor.ambarus@linaro.org, andre.draszik@linaro.org, semen.protsenko@linaro.org, saravanak@google.com, willmcvicker@google.com, soc@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-watchdog@vger.kernel.org, kernel-team@android.com, linux-serial@vger.kernel.org Subject: Re: [PATCH v6 13/20] pinctrl: samsung: Add gs101 SoC pinctrl configuration Date: Mon, 11 Dec 2023 11:35:39 +0000 [thread overview] Message-ID: <CADrjBPr6k-j=swq8zJfOjaYQW7hvWCTXj2ZZQT6V+QUtjEYOcg@mail.gmail.com> (raw) In-Reply-To: <46c9c8b4-942d-4f6f-a6cc-00158314d5e5@linaro.org> Hi Krzysztof, Thanks for the review. On Sun, 10 Dec 2023 at 13:56, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 10/12/2023 00:30, Peter Griffin wrote: > > Add support for the pin-controller found on the gs101 SoC used in > > Pixel 6 phones. > > > > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > > --- > > > > diff --git a/drivers/pinctrl/samsung/pinctrl-exynos.c b/drivers/pinctrl/samsung/pinctrl-exynos.c > > index 6b58ec84e34b..3834bf953178 100644 > > --- a/drivers/pinctrl/samsung/pinctrl-exynos.c > > +++ b/drivers/pinctrl/samsung/pinctrl-exynos.c > > @@ -468,6 +468,8 @@ static const struct of_device_id exynos_wkup_irq_ids[] = { > > .data = &exynos7_wkup_irq_chip }, > > { .compatible = "samsung,exynosautov9-wakeup-eint", > > .data = &exynos7_wkup_irq_chip }, > > + { .compatible = "google,gs101-wakeup-eint", > > + .data = &exynos7_wkup_irq_chip }, > > You don't need it. OK will drop > > > { } > > }; > > > > diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c > > index 79babbb39ced..b8d549fe38cb 100644 > > --- a/drivers/pinctrl/samsung/pinctrl-samsung.c > > +++ b/drivers/pinctrl/samsung/pinctrl-samsung.c > > @@ -1321,6 +1321,8 @@ static const struct of_device_id samsung_pinctrl_dt_match[] = { > > .data = &exynosautov9_of_data }, > > { .compatible = "tesla,fsd-pinctrl", > > .data = &fsd_of_data }, > > + { .compatible = "google,gs101-pinctrl", > > + .data = &gs101_of_data }, > > Place it somewhere alphabetically. Probably before tesla. Will fix. FYI I was intending to put it at the top ('g' before 's') that also matches the ordering everywhere else e.g. in the YAML docs etc. regards, Peter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-12-11 11:35 UTC|newest] Thread overview: 99+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-12-09 23:30 [PATCH v6 00/20] Add minimal Tensor/GS101 SoC support and Oriole/Pixel6 board Peter Griffin 2023-12-09 23:30 ` Peter Griffin 2023-12-09 23:30 ` [PATCH v6 01/20] dt-bindings: soc: samsung: exynos-pmu: Add gs101 compatible Peter Griffin 2023-12-09 23:30 ` Peter Griffin 2023-12-10 14:01 ` (subset) " Krzysztof Kozlowski 2023-12-10 14:01 ` Krzysztof Kozlowski 2023-12-09 23:30 ` [PATCH v6 02/20] dt-bindings: clock: Add Google gs101 clock management unit bindings Peter Griffin 2023-12-09 23:30 ` Peter Griffin 2023-12-10 13:44 ` Krzysztof Kozlowski 2023-12-10 13:44 ` Krzysztof Kozlowski 2023-12-10 14:01 ` (subset) " Krzysztof Kozlowski 2023-12-10 14:01 ` Krzysztof Kozlowski 2023-12-09 23:30 ` [PATCH v6 03/20] dt-bindings: soc: google: exynos-sysreg: add dedicated SYSREG compatibles to GS101 Peter Griffin 2023-12-09 23:30 ` Peter Griffin 2023-12-10 13:49 ` Krzysztof Kozlowski 2023-12-10 13:49 ` Krzysztof Kozlowski 2023-12-11 9:17 ` Peter Griffin 2023-12-11 9:17 ` Peter Griffin 2023-12-10 14:01 ` (subset) " Krzysztof Kozlowski 2023-12-10 14:01 ` Krzysztof Kozlowski 2023-12-09 23:30 ` [PATCH v6 04/20] dt-bindings: watchdog: Document Google gs101 watchdog bindings Peter Griffin 2023-12-09 23:30 ` Peter Griffin 2023-12-10 14:23 ` Krzysztof Kozlowski 2023-12-10 14:23 ` Krzysztof Kozlowski 2023-12-11 9:24 ` Peter Griffin 2023-12-11 9:24 ` Peter Griffin 2023-12-09 23:30 ` [PATCH v6 05/20] dt-bindings: arm: google: Add bindings for Google ARM platforms Peter Griffin 2023-12-09 23:30 ` Peter Griffin 2023-12-10 13:52 ` Krzysztof Kozlowski 2023-12-10 13:52 ` Krzysztof Kozlowski 2023-12-09 23:30 ` [PATCH v6 06/20] dt-bindings: pinctrl: samsung: add google,gs101-pinctrl compatible Peter Griffin 2023-12-09 23:30 ` Peter Griffin 2023-12-10 13:57 ` (subset) " Krzysztof Kozlowski 2023-12-10 13:57 ` Krzysztof Kozlowski 2023-12-09 23:30 ` [PATCH v6 07/20] dt-bindings: pinctrl: samsung: add gs101-wakeup-eint compatible Peter Griffin 2023-12-09 23:30 ` Peter Griffin 2023-12-10 13:57 ` (subset) " Krzysztof Kozlowski 2023-12-10 13:57 ` Krzysztof Kozlowski 2023-12-09 23:30 ` [PATCH v6 08/20] dt-bindings: serial: samsung: Add google-gs101-uart compatible Peter Griffin 2023-12-09 23:30 ` Peter Griffin 2023-12-09 23:30 ` [PATCH v6 09/20] dt-bindings: serial: samsung: Make samsung,uart-fifosize a required property Peter Griffin 2023-12-09 23:30 ` Peter Griffin 2023-12-10 23:34 ` Sam Protsenko 2023-12-10 23:34 ` Sam Protsenko 2023-12-09 23:30 ` [PATCH v6 10/20] dt-bindings: soc: samsung: usi: add google,gs101-usi compatible Peter Griffin 2023-12-09 23:30 ` Peter Griffin 2023-12-10 23:34 ` Sam Protsenko 2023-12-10 23:34 ` Sam Protsenko 2023-12-09 23:30 ` [PATCH v6 11/20] clk: samsung: clk-pll: Add support for pll_{0516,0517,518} Peter Griffin 2023-12-09 23:30 ` Peter Griffin 2023-12-09 23:30 ` [PATCH v6 12/20] clk: samsung: clk-gs101: Add cmu_top, cmu_misc and cmu_apm support Peter Griffin 2023-12-10 23:36 ` Sam Protsenko 2023-12-10 23:36 ` Sam Protsenko 2023-12-11 10:04 ` André Draszik 2023-12-11 10:04 ` André Draszik 2023-12-09 23:30 ` [PATCH v6 13/20] pinctrl: samsung: Add gs101 SoC pinctrl configuration Peter Griffin 2023-12-09 23:30 ` Peter Griffin 2023-12-10 13:55 ` Krzysztof Kozlowski 2023-12-10 13:55 ` Krzysztof Kozlowski 2023-12-10 23:44 ` Sam Protsenko 2023-12-10 23:44 ` Sam Protsenko 2023-12-11 11:35 ` Peter Griffin [this message] 2023-12-11 11:35 ` Peter Griffin 2023-12-09 23:31 ` [PATCH v6 14/20] watchdog: s3c2410_wdt: Add support for WTCON register DBGACK_MASK bit Peter Griffin 2023-12-09 23:31 ` Peter Griffin 2023-12-10 14:24 ` Krzysztof Kozlowski 2023-12-10 14:24 ` Krzysztof Kozlowski 2023-12-11 10:22 ` Peter Griffin 2023-12-11 10:22 ` Peter Griffin 2023-12-09 23:31 ` [PATCH v6 15/20] watchdog: s3c2410_wdt: Update QUIRK macros to use BIT macro Peter Griffin 2023-12-09 23:31 ` Peter Griffin 2023-12-10 23:37 ` Sam Protsenko 2023-12-10 23:37 ` Sam Protsenko 2023-12-09 23:31 ` [PATCH v6 16/20] watchdog: s3c2410_wdt: Add support for Google gs101 SoC Peter Griffin 2023-12-09 23:31 ` Peter Griffin 2023-12-10 14:26 ` Krzysztof Kozlowski 2023-12-10 14:26 ` Krzysztof Kozlowski 2023-12-11 10:26 ` Peter Griffin 2023-12-11 10:26 ` Peter Griffin 2023-12-09 23:31 ` [PATCH v6 17/20] tty: serial: samsung: Add gs101 compatible and common fifoszdt_serial_drv_data Peter Griffin 2023-12-09 23:31 ` Peter Griffin 2023-12-09 23:31 ` [PATCH v6 18/20] arm64: dts: exynos: google: Add initial Google gs101 SoC support Peter Griffin 2023-12-09 23:31 ` Peter Griffin 2023-12-10 14:38 ` Krzysztof Kozlowski 2023-12-10 14:38 ` Krzysztof Kozlowski 2023-12-10 23:47 ` Sam Protsenko 2023-12-10 23:47 ` Sam Protsenko 2023-12-11 12:17 ` Peter Griffin 2023-12-11 12:17 ` Peter Griffin 2023-12-09 23:31 ` [PATCH v6 19/20] arm64: dts: exynos: google: Add initial Oriole/pixel 6 board support Peter Griffin 2023-12-09 23:31 ` Peter Griffin 2023-12-10 14:39 ` Krzysztof Kozlowski 2023-12-10 14:39 ` Krzysztof Kozlowski 2023-12-11 12:45 ` Peter Griffin 2023-12-11 12:45 ` Peter Griffin 2023-12-09 23:31 ` [PATCH v6 20/20] MAINTAINERS: add entry for Google Tensor SoC Peter Griffin 2023-12-09 23:31 ` Peter Griffin 2023-12-10 14:38 ` [PATCH v6 00/20] Add minimal Tensor/GS101 SoC support and Oriole/Pixel6 board Krzysztof Kozlowski 2023-12-10 14:38 ` Krzysztof Kozlowski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CADrjBPr6k-j=swq8zJfOjaYQW7hvWCTXj2ZZQT6V+QUtjEYOcg@mail.gmail.com' \ --to=peter.griffin@linaro.org \ --cc=alim.akhtar@samsung.com \ --cc=andre.draszik@linaro.org \ --cc=arnd@arndb.de \ --cc=catalin.marinas@arm.com \ --cc=conor+dt@kernel.org \ --cc=cw00.choi@samsung.com \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=jirislaby@kernel.org \ --cc=kernel-team@android.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=krzysztof.kozlowski@linaro.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=linux-serial@vger.kernel.org \ --cc=linux-watchdog@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=mturquette@baylibre.com \ --cc=olof@lixom.net \ --cc=robh+dt@kernel.org \ --cc=s.nawrocki@samsung.com \ --cc=saravanak@google.com \ --cc=sboyd@kernel.org \ --cc=semen.protsenko@linaro.org \ --cc=soc@kernel.org \ --cc=tomasz.figa@gmail.com \ --cc=tudor.ambarus@linaro.org \ --cc=will@kernel.org \ --cc=willmcvicker@google.com \ --cc=wim@linux-watchdog.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.