All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xin Long <lucien.xin@gmail.com>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: network dev <netdev@vger.kernel.org>,
	linux-sctp@vger.kernel.org, davem <davem@davemloft.net>,
	Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
	Vlad Yasevich <vyasevich@gmail.com>,
	daniel@iogearbox.net
Subject: Re: [PATCH net 2/2] sctp: not copying duplicate addrs to the assoc's bind address list
Date: Fri, 19 Aug 2016 23:16:41 +0800	[thread overview]
Message-ID: <CADvbK_fo8o1nOvo58PdrkkT6ffGv7r5NhDUazBw67mwwfcwitA@mail.gmail.com> (raw)
In-Reply-To: <20160819133001.GA3578@hmsreliant.think-freely.org>

> Under what valid use case will multiple interfaces have the same network
> address?
>
Hi, Neil.
I'm not sure the specific valid use case.

The point is, do we trust the sctp global addr list has no duplicate
address ? In one of users' computer, he found hundreds of duplicate
addresses in INIT_ACK packets.
(https://bugzilla.redhat.com/show_bug.cgi?id=1308362)

If we think NETDEV_UP/DOWN event in addrs chain always come
in pairs, I can not explain how come this issue happened.

But from sctp end, we can avoid it with this patch. after all
binding any duplicate addresses is illegal, just like what
sctp_bind does.

what do you think ?

WARNING: multiple messages have this Message-ID (diff)
From: Xin Long <lucien.xin@gmail.com>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: network dev <netdev@vger.kernel.org>,
	linux-sctp@vger.kernel.org, davem <davem@davemloft.net>,
	Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
	Vlad Yasevich <vyasevich@gmail.com>,
	daniel@iogearbox.net
Subject: Re: [PATCH net 2/2] sctp: not copying duplicate addrs to the assoc's bind address list
Date: Fri, 19 Aug 2016 15:16:41 +0000	[thread overview]
Message-ID: <CADvbK_fo8o1nOvo58PdrkkT6ffGv7r5NhDUazBw67mwwfcwitA@mail.gmail.com> (raw)
In-Reply-To: <20160819133001.GA3578@hmsreliant.think-freely.org>

> Under what valid use case will multiple interfaces have the same network
> address?
>
Hi, Neil.
I'm not sure the specific valid use case.

The point is, do we trust the sctp global addr list has no duplicate
address ? In one of users' computer, he found hundreds of duplicate
addresses in INIT_ACK packets.
(https://bugzilla.redhat.com/show_bug.cgi?id\x1308362)

If we think NETDEV_UP/DOWN event in addrs chain always come
in pairs, I can not explain how come this issue happened.

But from sctp end, we can avoid it with this patch. after all
binding any duplicate addresses is illegal, just like what
sctp_bind does.

what do you think ?

  reply	other threads:[~2016-08-19 15:16 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-19 11:30 [PATCH net 0/2] sctp: not copying duplicate addrs to the assoc's bind address list Xin Long
2016-08-19 11:30 ` Xin Long
2016-08-19 11:30 ` [PATCH net 1/2] sctp: reduce indent level in sctp_copy_local_addr_list Xin Long
2016-08-19 11:30   ` Xin Long
2016-08-19 11:30   ` [PATCH net 2/2] sctp: not copying duplicate addrs to the assoc's bind address list Xin Long
2016-08-19 11:30     ` Xin Long
2016-08-19 13:30     ` Neil Horman
2016-08-19 13:30       ` Neil Horman
2016-08-19 15:16       ` Xin Long [this message]
2016-08-19 15:16         ` Xin Long
2016-08-19 17:50     ` Neil Horman
2016-08-19 17:50       ` Neil Horman
2016-08-20  6:41       ` Xin Long
2016-08-20  6:41         ` Xin Long
2016-08-22 14:25         ` Neil Horman
2016-08-22 14:25           ` Neil Horman
2016-08-24  5:14           ` Xin Long
2016-08-24  5:14             ` Xin Long
2016-08-24 10:38             ` Neil Horman
2016-08-24 10:38               ` Neil Horman
2016-12-17  9:56               ` Xin Long
2016-12-17  9:56                 ` Xin Long
2016-12-19 12:35                 ` Neil Horman
2016-12-19 12:35                   ` Neil Horman
2016-08-24 11:23           ` Marcelo Ricardo Leitner
2016-08-24 11:23             ` Marcelo Ricardo Leitner
2016-08-25  4:03             ` Xin Long
2016-08-25  4:03               ` Xin Long
2016-08-25 12:10               ` Marcelo Ricardo Leitner
2016-08-25 12:10                 ` Marcelo Ricardo Leitner
2016-09-02 13:22               ` David Laight
2016-09-02 13:22                 ` David Laight
2016-09-02 13:46                 ` Marcelo Ricardo Leitner
2016-09-02 13:46                   ` Marcelo Ricardo Leitner
2016-09-02 14:25                   ` David Laight
2016-09-02 14:25                     ` David Laight
2016-09-02 14:44                     ` 'Marcelo Ricardo Leitner'
2016-09-02 14:44                       ` 'Marcelo Ricardo Leitner'

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADvbK_fo8o1nOvo58PdrkkT6ffGv7r5NhDUazBw67mwwfcwitA@mail.gmail.com \
    --to=lucien.xin@gmail.com \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=linux-sctp@vger.kernel.org \
    --cc=marcelo.leitner@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=vyasevich@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.