From: Stephen Boyd <swboyd@chromium.org> To: Prashant Malani <pmalani@chromium.org>, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Cc: heikki.krogerus@linux.intel.com, "Andrzej Hajda" <andrzej.hajda@intel.com>, "Neil Armstrong" <narmstrong@baylibre.com>, "David Airlie" <airlied@linux.ie>, dri-devel@lists.freedesktop.org, "Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, "Sam Ravnborg" <sam@ravnborg.org>, "Jernej Skrabec" <jernej.skrabec@gmail.com>, devicetree@vger.kernel.org, "Thomas Zimmermann" <tzimmermann@suse.de>, "Nícolas F . R . A . Prado" <nfraprado@collabora.com>, "Jonas Karlman" <jonas@kwiboo.se>, "Allen Chen" <allen.chen@ite.com.tw>, "Pin-Yen Lin" <treapking@chromium.org>, "Rob Herring" <robh+dt@kernel.org>, "Maxime Ripard" <maxime@cerno.tech>, "Hsin-Yi Wang" <hsinyi@chromium.org>, "Xin Ji" <xji@analogixsemi.com>, "AngeloGioacchino Del Regno" <angelogioacchino.delregno@collabora.com>, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, "Robert Foss" <robert.foss@linaro.org>, "José Expósito" <jose.exposito89@gmail.com> Subject: Re: [PATCH v5 5/9] drm/bridge: anx7625: Add typec_mux_set callback function Date: Tue, 28 Jun 2022 14:25:39 -0500 [thread overview] Message-ID: <CAE-0n517BB8YbN5AZG6M3ZrZGOJDV=+t0R9d8wD+gVqO1aD1Xg@mail.gmail.com> (raw) In-Reply-To: <20220622173605.1168416-6-pmalani@chromium.org> Quoting Prashant Malani (2022-06-22 10:34:34) > From: Pin-Yen Lin <treapking@chromium.org> > > Add the callback function when the driver receives state > changes of the Type-C port. The callback function configures the > crosspoint switch of the anx7625 bridge chip, which can change the > output pins of the signals according to the port state. Can this be combined with the previous two patches? They really don't stand alone because the previous two patches are adding stubs that are filled out later. > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c > index bd21f159b973..5992fc8beeeb 100644 > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > @@ -15,6 +15,7 @@ > #include <linux/regulator/consumer.h> > #include <linux/slab.h> > #include <linux/types.h> > +#include <linux/usb/typec_dp.h> > #include <linux/usb/typec_mux.h> > #include <linux/workqueue.h> > > @@ -2582,9 +2583,64 @@ static void anx7625_runtime_disable(void *data) > pm_runtime_disable(data); > } > > +static void anx7625_set_crosspoint_switch(struct anx7625_data *ctx, > + enum typec_orientation orientation) > +{ > + if (orientation == TYPEC_ORIENTATION_NORMAL) { > + anx7625_reg_write(ctx, ctx->i2c.tcpc_client, TCPC_SWITCH_0, > + SW_SEL1_SSRX_RX1 | SW_SEL1_DPTX0_RX2); > + anx7625_reg_write(ctx, ctx->i2c.tcpc_client, TCPC_SWITCH_1, > + SW_SEL2_SSTX_TX1 | SW_SEL2_DPTX1_TX2); > + } else if (orientation == TYPEC_ORIENTATION_REVERSE) { > + anx7625_reg_write(ctx, ctx->i2c.tcpc_client, TCPC_SWITCH_0, > + SW_SEL1_SSRX_RX2 | SW_SEL1_DPTX0_RX1); > + anx7625_reg_write(ctx, ctx->i2c.tcpc_client, TCPC_SWITCH_1, > + SW_SEL2_SSTX_TX2 | SW_SEL2_DPTX1_TX1); > + } > +} > + > +static void anx7625_typec_two_ports_update(struct anx7625_data *ctx) > +{ > + if (ctx->typec_ports[0].dp_connected && ctx->typec_ports[1].dp_connected) > + /* Both ports available, do nothing to retain the current one. */ > + return; > + else if (ctx->typec_ports[0].dp_connected) > + anx7625_set_crosspoint_switch(ctx, TYPEC_ORIENTATION_NORMAL); > + else if (ctx->typec_ports[1].dp_connected) > + anx7625_set_crosspoint_switch(ctx, TYPEC_ORIENTATION_REVERSE); > +} > + > static int anx7625_typec_mux_set(struct typec_mux_dev *mux, > struct typec_mux_state *state) > { > + struct anx7625_port_data *data = typec_mux_get_drvdata(mux); > + struct anx7625_data *ctx = data->ctx; > + struct device *dev = &ctx->client->dev; > + bool new_dp_connected, old_dp_connected; > + > + if (ctx->num_typec_switches == 1) How do we handle the case where the usb-c-connector is directly connected to the RX1/TX1 and RX2/TX2 pins? This device would be an orientation (normal/reverse) and mode switch (usb/dp) in that scenario, but this code is written in a way that the orientation switch isn't going to flip the crosspoint switch for the different pin assignments.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <swboyd@chromium.org> To: Prashant Malani <pmalani@chromium.org>, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Cc: bleung@chromium.org, heikki.krogerus@linux.intel.com, "Pin-Yen Lin" <treapking@chromium.org>, "AngeloGioacchino Del Regno" <angelogioacchino.delregno@collabora.com>, "Nícolas F . R . A . Prado" <nfraprado@collabora.com>, "Allen Chen" <allen.chen@ite.com.tw>, "Andrzej Hajda" <andrzej.hajda@intel.com>, "Daniel Vetter" <daniel@ffwll.ch>, "David Airlie" <airlied@linux.ie>, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, "Hsin-Yi Wang" <hsinyi@chromium.org>, "Jernej Skrabec" <jernej.skrabec@gmail.com>, "Jonas Karlman" <jonas@kwiboo.se>, "José Expósito" <jose.exposito89@gmail.com>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, "Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>, "Maxime Ripard" <maxime@cerno.tech>, "Neil Armstrong" <narmstrong@baylibre.com>, "Robert Foss" <robert.foss@linaro.org>, "Rob Herring" <robh+dt@kernel.org>, "Sam Ravnborg" <sam@ravnborg.org>, "Thomas Zimmermann" <tzimmermann@suse.de>, "Xin Ji" <xji@analogixsemi.com> Subject: Re: [PATCH v5 5/9] drm/bridge: anx7625: Add typec_mux_set callback function Date: Tue, 28 Jun 2022 14:25:39 -0500 [thread overview] Message-ID: <CAE-0n517BB8YbN5AZG6M3ZrZGOJDV=+t0R9d8wD+gVqO1aD1Xg@mail.gmail.com> (raw) In-Reply-To: <20220622173605.1168416-6-pmalani@chromium.org> Quoting Prashant Malani (2022-06-22 10:34:34) > From: Pin-Yen Lin <treapking@chromium.org> > > Add the callback function when the driver receives state > changes of the Type-C port. The callback function configures the > crosspoint switch of the anx7625 bridge chip, which can change the > output pins of the signals according to the port state. Can this be combined with the previous two patches? They really don't stand alone because the previous two patches are adding stubs that are filled out later. > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c > index bd21f159b973..5992fc8beeeb 100644 > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > @@ -15,6 +15,7 @@ > #include <linux/regulator/consumer.h> > #include <linux/slab.h> > #include <linux/types.h> > +#include <linux/usb/typec_dp.h> > #include <linux/usb/typec_mux.h> > #include <linux/workqueue.h> > > @@ -2582,9 +2583,64 @@ static void anx7625_runtime_disable(void *data) > pm_runtime_disable(data); > } > > +static void anx7625_set_crosspoint_switch(struct anx7625_data *ctx, > + enum typec_orientation orientation) > +{ > + if (orientation == TYPEC_ORIENTATION_NORMAL) { > + anx7625_reg_write(ctx, ctx->i2c.tcpc_client, TCPC_SWITCH_0, > + SW_SEL1_SSRX_RX1 | SW_SEL1_DPTX0_RX2); > + anx7625_reg_write(ctx, ctx->i2c.tcpc_client, TCPC_SWITCH_1, > + SW_SEL2_SSTX_TX1 | SW_SEL2_DPTX1_TX2); > + } else if (orientation == TYPEC_ORIENTATION_REVERSE) { > + anx7625_reg_write(ctx, ctx->i2c.tcpc_client, TCPC_SWITCH_0, > + SW_SEL1_SSRX_RX2 | SW_SEL1_DPTX0_RX1); > + anx7625_reg_write(ctx, ctx->i2c.tcpc_client, TCPC_SWITCH_1, > + SW_SEL2_SSTX_TX2 | SW_SEL2_DPTX1_TX1); > + } > +} > + > +static void anx7625_typec_two_ports_update(struct anx7625_data *ctx) > +{ > + if (ctx->typec_ports[0].dp_connected && ctx->typec_ports[1].dp_connected) > + /* Both ports available, do nothing to retain the current one. */ > + return; > + else if (ctx->typec_ports[0].dp_connected) > + anx7625_set_crosspoint_switch(ctx, TYPEC_ORIENTATION_NORMAL); > + else if (ctx->typec_ports[1].dp_connected) > + anx7625_set_crosspoint_switch(ctx, TYPEC_ORIENTATION_REVERSE); > +} > + > static int anx7625_typec_mux_set(struct typec_mux_dev *mux, > struct typec_mux_state *state) > { > + struct anx7625_port_data *data = typec_mux_get_drvdata(mux); > + struct anx7625_data *ctx = data->ctx; > + struct device *dev = &ctx->client->dev; > + bool new_dp_connected, old_dp_connected; > + > + if (ctx->num_typec_switches == 1) How do we handle the case where the usb-c-connector is directly connected to the RX1/TX1 and RX2/TX2 pins? This device would be an orientation (normal/reverse) and mode switch (usb/dp) in that scenario, but this code is written in a way that the orientation switch isn't going to flip the crosspoint switch for the different pin assignments.
next prev parent reply other threads:[~2022-06-28 19:25 UTC|newest] Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-22 17:34 [PATCH v5 0/9] usb: typec: Introduce typec-switch binding Prashant Malani 2022-06-22 17:34 ` Prashant Malani 2022-06-22 17:34 ` [PATCH v5 1/9] dt-bindings: usb: Add Type-C switch binding Prashant Malani 2022-06-22 17:34 ` Prashant Malani 2022-06-23 18:30 ` Stephen Boyd 2022-06-23 18:30 ` Stephen Boyd 2022-06-23 19:08 ` Prashant Malani 2022-06-23 19:08 ` Prashant Malani 2022-06-23 23:14 ` Stephen Boyd 2022-06-23 23:14 ` Stephen Boyd 2022-06-24 0:35 ` Prashant Malani 2022-06-24 0:35 ` Prashant Malani 2022-06-24 1:24 ` Prashant Malani 2022-06-24 1:24 ` Prashant Malani 2022-06-24 2:13 ` Stephen Boyd 2022-06-24 2:13 ` Stephen Boyd 2022-06-24 2:48 ` Prashant Malani 2022-06-24 2:48 ` Prashant Malani 2022-06-24 19:50 ` Stephen Boyd 2022-06-24 19:50 ` Stephen Boyd 2022-06-24 21:41 ` Prashant Malani 2022-06-24 21:41 ` Prashant Malani 2022-06-25 1:21 ` Stephen Boyd 2022-06-25 1:21 ` Stephen Boyd 2022-06-25 20:13 ` Krzysztof Kozlowski 2022-06-25 20:13 ` Krzysztof Kozlowski 2022-06-27 21:04 ` Rob Herring 2022-06-27 21:04 ` Rob Herring 2022-06-27 21:43 ` Prashant Malani 2022-06-27 21:43 ` Prashant Malani 2022-06-28 18:23 ` Rob Herring 2022-06-28 18:23 ` Rob Herring 2022-06-29 14:33 ` Pin-yen Lin 2022-06-29 14:33 ` Pin-yen Lin 2022-06-29 15:00 ` Pin-yen Lin 2022-06-29 15:00 ` Pin-yen Lin 2022-06-29 17:58 ` Rob Herring 2022-06-29 17:58 ` Rob Herring 2022-06-29 21:58 ` Stephen Boyd 2022-06-29 21:58 ` Stephen Boyd 2022-06-29 22:55 ` Prashant Malani 2022-06-29 22:55 ` Prashant Malani 2022-06-29 23:55 ` Stephen Boyd 2022-06-29 23:55 ` Stephen Boyd 2022-06-30 17:10 ` Prashant Malani 2022-06-30 17:10 ` Prashant Malani 2022-07-12 17:45 ` Rob Herring 2022-07-12 17:45 ` Rob Herring 2022-07-13 21:58 ` Prashant Malani 2022-07-13 21:58 ` Prashant Malani 2022-09-02 7:41 ` Prashant Malani 2022-09-02 7:41 ` Prashant Malani 2022-09-16 18:21 ` Prashant Malani 2022-09-16 18:21 ` Prashant Malani 2022-10-03 3:42 ` Pin-yen Lin 2022-10-03 3:42 ` Pin-yen Lin 2022-06-22 17:34 ` [PATCH v5 2/9] dt-bindings: drm/bridge: anx7625: Add mode-switch support Prashant Malani 2022-06-22 17:34 ` Prashant Malani 2022-06-22 17:34 ` [PATCH v5 3/9] drm/bridge: anx7625: Register number of Type C switches Prashant Malani 2022-06-22 17:34 ` Prashant Malani 2022-06-22 17:34 ` [PATCH v5 4/9] drm/bridge: anx7625: Register Type-C mode switches Prashant Malani 2022-06-22 17:34 ` Prashant Malani 2022-06-22 17:34 ` [PATCH v5 5/9] drm/bridge: anx7625: Add typec_mux_set callback function Prashant Malani 2022-06-22 17:34 ` Prashant Malani 2022-06-28 19:25 ` Stephen Boyd [this message] 2022-06-28 19:25 ` Stephen Boyd 2022-06-28 19:48 ` Prashant Malani 2022-06-28 19:48 ` Prashant Malani 2022-06-28 20:40 ` Stephen Boyd 2022-06-28 20:40 ` Stephen Boyd 2022-06-28 20:56 ` Prashant Malani 2022-06-28 20:56 ` Prashant Malani 2022-06-30 23:21 ` Stephen Boyd 2022-06-30 23:21 ` Stephen Boyd 2022-06-30 23:38 ` Prashant Malani 2022-06-30 23:38 ` Prashant Malani 2022-07-06 18:26 ` Prashant Malani 2022-07-06 18:26 ` Prashant Malani 2022-07-07 0:17 ` Stephen Boyd 2022-07-07 0:17 ` Stephen Boyd 2022-07-12 10:22 ` Pin-yen Lin 2022-07-12 10:22 ` Pin-yen Lin 2022-06-22 17:34 ` [PATCH v5 6/9] dt/bindings: drm/bridge: it6505: Add mode-switch support Prashant Malani 2022-06-22 17:34 ` Prashant Malani 2022-06-23 18:24 ` Stephen Boyd 2022-06-23 18:24 ` Stephen Boyd 2022-06-23 18:37 ` Prashant Malani 2022-06-23 18:37 ` Prashant Malani 2022-06-23 19:08 ` Stephen Boyd 2022-06-23 19:08 ` Stephen Boyd 2022-06-23 19:15 ` Prashant Malani 2022-06-23 19:15 ` Prashant Malani 2022-06-22 17:34 ` [PATCH v5 7/9] drm/bridge: it6505: Register number of Type C switches Prashant Malani 2022-06-22 17:34 ` Prashant Malani 2022-06-27 21:05 ` Rob Herring 2022-06-27 21:05 ` Rob Herring 2022-06-22 17:34 ` [PATCH v5 8/9] drm/bridge: it6505: Register Type-C mode switches Prashant Malani 2022-06-22 17:34 ` Prashant Malani 2022-06-22 17:34 ` [PATCH v5 9/9] drm/bridge: it6505: Add typec_mux_set callback function Prashant Malani 2022-06-22 17:34 ` Prashant Malani
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAE-0n517BB8YbN5AZG6M3ZrZGOJDV=+t0R9d8wD+gVqO1aD1Xg@mail.gmail.com' \ --to=swboyd@chromium.org \ --cc=Laurent.pinchart@ideasonboard.com \ --cc=airlied@linux.ie \ --cc=allen.chen@ite.com.tw \ --cc=andrzej.hajda@intel.com \ --cc=angelogioacchino.delregno@collabora.com \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=gregkh@linuxfoundation.org \ --cc=heikki.krogerus@linux.intel.com \ --cc=hsinyi@chromium.org \ --cc=jernej.skrabec@gmail.com \ --cc=jonas@kwiboo.se \ --cc=jose.exposito89@gmail.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=maxime@cerno.tech \ --cc=narmstrong@baylibre.com \ --cc=nfraprado@collabora.com \ --cc=pmalani@chromium.org \ --cc=robert.foss@linaro.org \ --cc=robh+dt@kernel.org \ --cc=sam@ravnborg.org \ --cc=treapking@chromium.org \ --cc=tzimmermann@suse.de \ --cc=xji@analogixsemi.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.