From: Stephen Boyd <swboyd@chromium.org>
To: Akhil P Oommen <quic_akhilpo@quicinc.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Rob Clark <robdclark@gmail.com>
Cc: freedreno@lists.freedesktop.org,
"Jonathan Marek" <jonathan@marek.ca>,
"David Airlie" <airlied@linux.ie>,
linux-arm-msm@vger.kernel.org, kernel-janitors@vger.kernel.org,
"Abhinav Kumar" <quic_abhinavk@quicinc.com>,
dri-devel@lists.freedesktop.org,
"Jordan Crouse" <jordan@cosmicpenguin.net>,
"Sean Paul" <sean@poorly.run>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH] drm/msm/adreno: fix cast in adreno_get_param()
Date: Tue, 8 Mar 2022 12:25:16 -0800 [thread overview]
Message-ID: <CAE-0n51by--BL=+12LtVKRY500Y_c4tZHai--bVvMERGNaUg-g@mail.gmail.com> (raw)
In-Reply-To: <20220307133105.GA17534@kili>
Quoting Dan Carpenter (2022-03-07 05:31:05)
> These casts need to happen before the shift. The only time it would
> matter would be if "rev.core" is >= 128. In that case the sign bit
> would be extended and we do not want that.
>
> Fixes: afab9d91d872 ("drm/msm/adreno: Expose speedbin to userspace")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <swboyd@chromium.org>
To: Akhil P Oommen <quic_akhilpo@quicinc.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Rob Clark <robdclark@gmail.com>
Cc: "Sean Paul" <sean@poorly.run>,
"Abhinav Kumar" <quic_abhinavk@quicinc.com>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Jordan Crouse" <jordan@cosmicpenguin.net>,
"Jonathan Marek" <jonathan@marek.ca>,
"Christian König" <christian.koenig@amd.com>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] drm/msm/adreno: fix cast in adreno_get_param()
Date: Tue, 8 Mar 2022 12:25:16 -0800 [thread overview]
Message-ID: <CAE-0n51by--BL=+12LtVKRY500Y_c4tZHai--bVvMERGNaUg-g@mail.gmail.com> (raw)
In-Reply-To: <20220307133105.GA17534@kili>
Quoting Dan Carpenter (2022-03-07 05:31:05)
> These casts need to happen before the shift. The only time it would
> matter would be if "rev.core" is >= 128. In that case the sign bit
> would be extended and we do not want that.
>
> Fixes: afab9d91d872 ("drm/msm/adreno: Expose speedbin to userspace")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
next prev parent reply other threads:[~2022-03-08 20:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 13:31 [PATCH] drm/msm/adreno: fix cast in adreno_get_param() Dan Carpenter
2022-03-07 13:31 ` Dan Carpenter
2022-03-07 15:01 ` [Freedreno] " Akhil P Oommen
2022-03-07 15:01 ` Akhil P Oommen
2022-03-08 20:25 ` Stephen Boyd [this message]
2022-03-08 20:25 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE-0n51by--BL=+12LtVKRY500Y_c4tZHai--bVvMERGNaUg-g@mail.gmail.com' \
--to=swboyd@chromium.org \
--cc=airlied@linux.ie \
--cc=christian.koenig@amd.com \
--cc=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jonathan@marek.ca \
--cc=jordan@cosmicpenguin.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_akhilpo@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.