* [PATCH] Net: ethernet: rocker: fixed a space coding style issue
@ 2015-03-21 18:02 Andrei Maresu
2015-03-22 3:20 ` Scott Feldman
2015-03-23 13:18 ` Jiri Pirko
0 siblings, 2 replies; 4+ messages in thread
From: Andrei Maresu @ 2015-03-21 18:02 UTC (permalink / raw)
To: Scott Feldman; +Cc: linux-kernel, netdev, Andrei Maresu
Fixed a space coding style issue found by checkpatch.pl in rocker.c
Signed-off-by: Andrei Maresu <andreimaresu@gmail.com>
---
drivers/net/ethernet/rocker/rocker.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/rocker/rocker.c b/drivers/net/ethernet/rocker/rocker.c
index 9fb6948..d364b12 100644
--- a/drivers/net/ethernet/rocker/rocker.c
+++ b/drivers/net/ethernet/rocker/rocker.c
@@ -812,7 +812,7 @@ static void *rocker_desc_cookie_ptr_get(struct rocker_desc_info *desc_info)
static void rocker_desc_cookie_ptr_set(struct rocker_desc_info *desc_info,
void *ptr)
{
- desc_info->desc->cookie = (uintptr_t) ptr;
+ desc_info->desc->cookie = (uintptr_t)ptr;
}
static struct rocker_desc_info *
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Net: ethernet: rocker: fixed a space coding style issue
2015-03-21 18:02 [PATCH] Net: ethernet: rocker: fixed a space coding style issue Andrei Maresu
@ 2015-03-22 3:20 ` Scott Feldman
2015-03-23 13:18 ` Jiri Pirko
1 sibling, 0 replies; 4+ messages in thread
From: Scott Feldman @ 2015-03-22 3:20 UTC (permalink / raw)
To: Andrei Maresu; +Cc: linux-kernel, Netdev
On Sat, Mar 21, 2015 at 11:02 AM, Andrei Maresu <andreimaresu@gmail.com> wrote:
> Fixed a space coding style issue found by checkpatch.pl in rocker.c
>
> Signed-off-by: Andrei Maresu <andreimaresu@gmail.com>
Signed-off-by: Scott Feldman <sfeldma@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Net: ethernet: rocker: fixed a space coding style issue
2015-03-21 18:02 [PATCH] Net: ethernet: rocker: fixed a space coding style issue Andrei Maresu
2015-03-22 3:20 ` Scott Feldman
@ 2015-03-23 13:18 ` Jiri Pirko
2015-03-23 17:20 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Jiri Pirko @ 2015-03-23 13:18 UTC (permalink / raw)
To: Andrei Maresu; +Cc: Scott Feldman, linux-kernel, netdev
Sat, Mar 21, 2015 at 07:02:40PM CET, andreimaresu@gmail.com wrote:
>Fixed a space coding style issue found by checkpatch.pl in rocker.c
>
>Signed-off-by: Andrei Maresu <andreimaresu@gmail.com>
>---
> drivers/net/ethernet/rocker/rocker.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/ethernet/rocker/rocker.c b/drivers/net/ethernet/rocker/rocker.c
>index 9fb6948..d364b12 100644
>--- a/drivers/net/ethernet/rocker/rocker.c
>+++ b/drivers/net/ethernet/rocker/rocker.c
>@@ -812,7 +812,7 @@ static void *rocker_desc_cookie_ptr_get(struct rocker_desc_info *desc_info)
> static void rocker_desc_cookie_ptr_set(struct rocker_desc_info *desc_info,
> void *ptr)
> {
>- desc_info->desc->cookie = (uintptr_t) ptr;
>+ desc_info->desc->cookie = (uintptr_t)ptr;
Checkpatch does not mark this as an error, not even as a warning:
"CHECK: No space is necessary after a cast". I personally like the
notation with space better.
> }
>
> static struct rocker_desc_info *
>--
>1.9.1
>
>--
>To unsubscribe from this list: send the line "unsubscribe netdev" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Net: ethernet: rocker: fixed a space coding style issue
2015-03-23 13:18 ` Jiri Pirko
@ 2015-03-23 17:20 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2015-03-23 17:20 UTC (permalink / raw)
To: jiri; +Cc: andreimaresu, sfeldma, linux-kernel, netdev
From: Jiri Pirko <jiri@resnulli.us>
Date: Mon, 23 Mar 2015 14:18:39 +0100
> Sat, Mar 21, 2015 at 07:02:40PM CET, andreimaresu@gmail.com wrote:
>>Fixed a space coding style issue found by checkpatch.pl in rocker.c
>>
>>Signed-off-by: Andrei Maresu <andreimaresu@gmail.com>
>>---
>> drivers/net/ethernet/rocker/rocker.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>diff --git a/drivers/net/ethernet/rocker/rocker.c b/drivers/net/ethernet/rocker/rocker.c
>>index 9fb6948..d364b12 100644
>>--- a/drivers/net/ethernet/rocker/rocker.c
>>+++ b/drivers/net/ethernet/rocker/rocker.c
>>@@ -812,7 +812,7 @@ static void *rocker_desc_cookie_ptr_get(struct rocker_desc_info *desc_info)
>> static void rocker_desc_cookie_ptr_set(struct rocker_desc_info *desc_info,
>> void *ptr)
>> {
>>- desc_info->desc->cookie = (uintptr_t) ptr;
>>+ desc_info->desc->cookie = (uintptr_t)ptr;
>
> Checkpatch does not mark this as an error, not even as a warning:
> "CHECK: No space is necessary after a cast". I personally like the
> notation with space better.
Me too, I'm not applying this.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-23 17:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-21 18:02 [PATCH] Net: ethernet: rocker: fixed a space coding style issue Andrei Maresu
2015-03-22 3:20 ` Scott Feldman
2015-03-23 13:18 ` Jiri Pirko
2015-03-23 17:20 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.