[PATCH v2 1/2] x86: Add an enum name for the GNVS firmware type

[PATCH v2 1/2] x86: Add an enum name for the GNVS firmware type

[Simon Glass]

This enum is currently anonymous. Add a name so it can be used in the
code.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
---

Changes in v2:
- Add some comments for the enum

 arch/x86/include/asm/intel_gnvs.h | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/arch/x86/include/asm/intel_gnvs.h b/arch/x86/include/asm/intel_gnvs.h
index fc743dc9285..0b69530edbf 100644
--- a/arch/x86/include/asm/intel_gnvs.h
+++ b/arch/x86/include/asm/intel_gnvs.h
@@ -47,7 +47,13 @@ enum {
 	BINF_RW_B = 2
 };
 
-enum {
+/**
+ * enum cros_fw_type_t - Used to indicate Chromium OS firmware type
+ *
+ * Chromium OS uses a region of the GNVS starting at offset 0x100 to store
+ * various bits of information, including the type of firmware being booted
+ */
+enum cros_fw_type_t {
 	FIRMWARE_TYPE_AUTO_DETECT = -1,
 	FIRMWARE_TYPE_RECOVERY = 0,
 	FIRMWARE_TYPE_NORMAL = 1,
-- 
2.35.1.723.g4982287a31-goog

[PATCH v2 2/2] x86: Correct the coreboot header file in MAINTAINERS

[Simon Glass]

This board has its own config header file. Correct it.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
---

(no changes since v1)

 board/coreboot/coreboot/MAINTAINERS | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/board/coreboot/coreboot/MAINTAINERS b/board/coreboot/coreboot/MAINTAINERS
index a05673bb0be..ee12d32ce7c 100644
--- a/board/coreboot/coreboot/MAINTAINERS
+++ b/board/coreboot/coreboot/MAINTAINERS
@@ -2,12 +2,12 @@ COREBOOT BOARD
 M:	Simon Glass <sjg@chromium.org>
 S:	Maintained
 F:	board/coreboot/coreboot/
-F:	include/configs/chromebook_link.h
+F:	include/configs/coreboot.h
 F:	configs/coreboot_defconfig
 
 COREBOOT64 BOARD
 M:	Simon Glass <sjg@chromium.org>
 S:	Maintained
 F:	board/coreboot/coreboot/
-F:	include/configs/chromebook_link.h
+F:	include/configs/coreboot.h
 F:	configs/coreboot64_defconfig
-- 
2.35.1.723.g4982287a31-goog

Re: [PATCH v2 1/2] x86: Add an enum name for the GNVS firmware type

[Bin Meng]

On Sun, Mar 13, 2022 at 2:03 PM Simon Glass <sjg@chromium.org> wrote:
>
> This enum is currently anonymous. Add a name so it can be used in the
> code.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
> Changes in v2:
> - Add some comments for the enum
>
>  arch/x86/include/asm/intel_gnvs.h | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>

applied to u-boot-x86, thanks!

Re: [PATCH v2 2/2] x86: Correct the coreboot header file in MAINTAINERS

[Bin Meng]

On Sun, Mar 13, 2022 at 2:04 PM Simon Glass <sjg@chromium.org> wrote:
>
> This board has its own config header file. Correct it.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
> (no changes since v1)
>
>  board/coreboot/coreboot/MAINTAINERS | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>

applied to u-boot-x86, thanks!