* [PATCH v2 1/2] x86: Add an enum name for the GNVS firmware type
@ 2022-03-13 6:03 Simon Glass
2022-03-13 6:03 ` [PATCH v2 2/2] x86: Correct the coreboot header file in MAINTAINERS Simon Glass
2022-03-14 7:18 ` [PATCH v2 1/2] x86: Add an enum name for the GNVS firmware type Bin Meng
0 siblings, 2 replies; 4+ messages in thread
From: Simon Glass @ 2022-03-13 6:03 UTC (permalink / raw)
To: U-Boot Mailing List; +Cc: Bin Meng, Simon Glass
This enum is currently anonymous. Add a name so it can be used in the
code.
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
---
Changes in v2:
- Add some comments for the enum
arch/x86/include/asm/intel_gnvs.h | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/arch/x86/include/asm/intel_gnvs.h b/arch/x86/include/asm/intel_gnvs.h
index fc743dc9285..0b69530edbf 100644
--- a/arch/x86/include/asm/intel_gnvs.h
+++ b/arch/x86/include/asm/intel_gnvs.h
@@ -47,7 +47,13 @@ enum {
BINF_RW_B = 2
};
-enum {
+/**
+ * enum cros_fw_type_t - Used to indicate Chromium OS firmware type
+ *
+ * Chromium OS uses a region of the GNVS starting at offset 0x100 to store
+ * various bits of information, including the type of firmware being booted
+ */
+enum cros_fw_type_t {
FIRMWARE_TYPE_AUTO_DETECT = -1,
FIRMWARE_TYPE_RECOVERY = 0,
FIRMWARE_TYPE_NORMAL = 1,
--
2.35.1.723.g4982287a31-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2 2/2] x86: Correct the coreboot header file in MAINTAINERS
2022-03-13 6:03 [PATCH v2 1/2] x86: Add an enum name for the GNVS firmware type Simon Glass
@ 2022-03-13 6:03 ` Simon Glass
2022-03-14 7:18 ` Bin Meng
2022-03-14 7:18 ` [PATCH v2 1/2] x86: Add an enum name for the GNVS firmware type Bin Meng
1 sibling, 1 reply; 4+ messages in thread
From: Simon Glass @ 2022-03-13 6:03 UTC (permalink / raw)
To: U-Boot Mailing List; +Cc: Bin Meng, Simon Glass
This board has its own config header file. Correct it.
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
---
(no changes since v1)
board/coreboot/coreboot/MAINTAINERS | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/board/coreboot/coreboot/MAINTAINERS b/board/coreboot/coreboot/MAINTAINERS
index a05673bb0be..ee12d32ce7c 100644
--- a/board/coreboot/coreboot/MAINTAINERS
+++ b/board/coreboot/coreboot/MAINTAINERS
@@ -2,12 +2,12 @@ COREBOOT BOARD
M: Simon Glass <sjg@chromium.org>
S: Maintained
F: board/coreboot/coreboot/
-F: include/configs/chromebook_link.h
+F: include/configs/coreboot.h
F: configs/coreboot_defconfig
COREBOOT64 BOARD
M: Simon Glass <sjg@chromium.org>
S: Maintained
F: board/coreboot/coreboot/
-F: include/configs/chromebook_link.h
+F: include/configs/coreboot.h
F: configs/coreboot64_defconfig
--
2.35.1.723.g4982287a31-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2 1/2] x86: Add an enum name for the GNVS firmware type
2022-03-13 6:03 [PATCH v2 1/2] x86: Add an enum name for the GNVS firmware type Simon Glass
2022-03-13 6:03 ` [PATCH v2 2/2] x86: Correct the coreboot header file in MAINTAINERS Simon Glass
@ 2022-03-14 7:18 ` Bin Meng
1 sibling, 0 replies; 4+ messages in thread
From: Bin Meng @ 2022-03-14 7:18 UTC (permalink / raw)
To: Simon Glass; +Cc: U-Boot Mailing List
On Sun, Mar 13, 2022 at 2:03 PM Simon Glass <sjg@chromium.org> wrote:
>
> This enum is currently anonymous. Add a name so it can be used in the
> code.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
> Changes in v2:
> - Add some comments for the enum
>
> arch/x86/include/asm/intel_gnvs.h | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
applied to u-boot-x86, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 2/2] x86: Correct the coreboot header file in MAINTAINERS
2022-03-13 6:03 ` [PATCH v2 2/2] x86: Correct the coreboot header file in MAINTAINERS Simon Glass
@ 2022-03-14 7:18 ` Bin Meng
0 siblings, 0 replies; 4+ messages in thread
From: Bin Meng @ 2022-03-14 7:18 UTC (permalink / raw)
To: Simon Glass; +Cc: U-Boot Mailing List
On Sun, Mar 13, 2022 at 2:04 PM Simon Glass <sjg@chromium.org> wrote:
>
> This board has its own config header file. Correct it.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
> (no changes since v1)
>
> board/coreboot/coreboot/MAINTAINERS | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
applied to u-boot-x86, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-03-14 7:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-13 6:03 [PATCH v2 1/2] x86: Add an enum name for the GNVS firmware type Simon Glass
2022-03-13 6:03 ` [PATCH v2 2/2] x86: Correct the coreboot header file in MAINTAINERS Simon Glass
2022-03-14 7:18 ` Bin Meng
2022-03-14 7:18 ` [PATCH v2 1/2] x86: Add an enum name for the GNVS firmware type Bin Meng
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.