* [U-Boot] [PATCH 1/1] x86: enable DISTRO_DEFAULTS for qemu
@ 2017-11-19 17:30 Heinrich Schuchardt
2017-11-20 7:07 ` Bin Meng
0 siblings, 1 reply; 7+ messages in thread
From: Heinrich Schuchardt @ 2017-11-19 17:30 UTC (permalink / raw)
To: u-boot
Enable CONFIG_DISTRO_DEFAULTS in qemu-x86_64_defconfig
and qemu-x86_defconfig.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
configs/qemu-x86_64_defconfig | 1 +
configs/qemu-x86_defconfig | 1 +
2 files changed, 2 insertions(+)
diff --git a/configs/qemu-x86_64_defconfig b/configs/qemu-x86_64_defconfig
index 0cea3694d0..4ebf062156 100644
--- a/configs/qemu-x86_64_defconfig
+++ b/configs/qemu-x86_64_defconfig
@@ -14,6 +14,7 @@ CONFIG_SMP=y
CONFIG_GENERATE_PIRQ_TABLE=y
CONFIG_GENERATE_MP_TABLE=y
CONFIG_GENERATE_ACPI_TABLE=y
+CONFIG_DISTRO_DEFAULTS=y
CONFIG_BUILD_ROM=y
CONFIG_FIT=y
CONFIG_SPL_LOAD_FIT=y
diff --git a/configs/qemu-x86_defconfig b/configs/qemu-x86_defconfig
index bf7fbc723d..5dfc8307b3 100644
--- a/configs/qemu-x86_defconfig
+++ b/configs/qemu-x86_defconfig
@@ -5,6 +5,7 @@ CONFIG_SMP=y
CONFIG_GENERATE_PIRQ_TABLE=y
CONFIG_GENERATE_MP_TABLE=y
CONFIG_GENERATE_ACPI_TABLE=y
+CONFIG_DISTRO_DEFAULTS=y
CONFIG_BUILD_ROM=y
CONFIG_FIT=y
CONFIG_BOOTSTAGE=y
--
2.15.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH 1/1] x86: enable DISTRO_DEFAULTS for qemu
2017-11-19 17:30 [U-Boot] [PATCH 1/1] x86: enable DISTRO_DEFAULTS for qemu Heinrich Schuchardt
@ 2017-11-20 7:07 ` Bin Meng
2017-11-20 9:20 ` Bin Meng
0 siblings, 1 reply; 7+ messages in thread
From: Bin Meng @ 2017-11-20 7:07 UTC (permalink / raw)
To: u-boot
On Mon, Nov 20, 2017 at 1:30 AM, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> Enable CONFIG_DISTRO_DEFAULTS in qemu-x86_64_defconfig
> and qemu-x86_defconfig.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> configs/qemu-x86_64_defconfig | 1 +
> configs/qemu-x86_defconfig | 1 +
> 2 files changed, 2 insertions(+)
>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH 1/1] x86: enable DISTRO_DEFAULTS for qemu
2017-11-20 7:07 ` Bin Meng
@ 2017-11-20 9:20 ` Bin Meng
2017-11-24 8:12 ` Bin Meng
0 siblings, 1 reply; 7+ messages in thread
From: Bin Meng @ 2017-11-20 9:20 UTC (permalink / raw)
To: u-boot
On Mon, Nov 20, 2017 at 3:07 PM, Bin Meng <bmeng.cn@gmail.com> wrote:
> On Mon, Nov 20, 2017 at 1:30 AM, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>> Enable CONFIG_DISTRO_DEFAULTS in qemu-x86_64_defconfig
>> and qemu-x86_defconfig.
>>
>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>> ---
>> configs/qemu-x86_64_defconfig | 1 +
>> configs/qemu-x86_defconfig | 1 +
>> 2 files changed, 2 insertions(+)
>>
>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
applied to u-boot-x86, thanks!
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH 1/1] x86: enable DISTRO_DEFAULTS for qemu
2017-11-20 9:20 ` Bin Meng
@ 2017-11-24 8:12 ` Bin Meng
2017-11-29 9:00 ` Bin Meng
0 siblings, 1 reply; 7+ messages in thread
From: Bin Meng @ 2017-11-24 8:12 UTC (permalink / raw)
To: u-boot
Hi Heinrich,
On Mon, Nov 20, 2017 at 5:20 PM, Bin Meng <bmeng.cn@gmail.com> wrote:
> On Mon, Nov 20, 2017 at 3:07 PM, Bin Meng <bmeng.cn@gmail.com> wrote:
>> On Mon, Nov 20, 2017 at 1:30 AM, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>>> Enable CONFIG_DISTRO_DEFAULTS in qemu-x86_64_defconfig
>>> and qemu-x86_defconfig.
>>>
>>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>>> ---
>>> configs/qemu-x86_64_defconfig | 1 +
>>> configs/qemu-x86_defconfig | 1 +
>>> 2 files changed, 2 insertions(+)
>>>
>>
>> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
>
> applied to u-boot-x86, thanks!
Unfortunately, this creates build warnings on QEMU.
include/configs/x86-common.h:70:0: warning: "CONFIG_BOOTCOMMAND" redefined
#define CONFIG_BOOTCOMMAND \
^
Can you please post your new patch against u-boot-x86/master that
fixes this issue?
Regards,
Bin
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH 1/1] x86: enable DISTRO_DEFAULTS for qemu
2017-11-24 8:12 ` Bin Meng
@ 2017-11-29 9:00 ` Bin Meng
2017-11-29 18:46 ` Heinrich Schuchardt
0 siblings, 1 reply; 7+ messages in thread
From: Bin Meng @ 2017-11-29 9:00 UTC (permalink / raw)
To: u-boot
Hi Heinrich,
On Fri, Nov 24, 2017 at 4:12 PM, Bin Meng <bmeng.cn@gmail.com> wrote:
> Hi Heinrich,
>
> On Mon, Nov 20, 2017 at 5:20 PM, Bin Meng <bmeng.cn@gmail.com> wrote:
>> On Mon, Nov 20, 2017 at 3:07 PM, Bin Meng <bmeng.cn@gmail.com> wrote:
>>> On Mon, Nov 20, 2017 at 1:30 AM, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>>>> Enable CONFIG_DISTRO_DEFAULTS in qemu-x86_64_defconfig
>>>> and qemu-x86_defconfig.
>>>>
>>>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>>>> ---
>>>> configs/qemu-x86_64_defconfig | 1 +
>>>> configs/qemu-x86_defconfig | 1 +
>>>> 2 files changed, 2 insertions(+)
>>>>
>>>
>>> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
>>
>> applied to u-boot-x86, thanks!
>
> Unfortunately, this creates build warnings on QEMU.
>
> include/configs/x86-common.h:70:0: warning: "CONFIG_BOOTCOMMAND" redefined
> #define CONFIG_BOOTCOMMAND \
> ^
>
> Can you please post your new patch against u-boot-x86/master that
> fixes this issue?
Did you get a chance to look at this?
Regards,
Bin
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH 1/1] x86: enable DISTRO_DEFAULTS for qemu
2017-11-29 9:00 ` Bin Meng
@ 2017-11-29 18:46 ` Heinrich Schuchardt
2017-11-30 3:01 ` Bin Meng
0 siblings, 1 reply; 7+ messages in thread
From: Heinrich Schuchardt @ 2017-11-29 18:46 UTC (permalink / raw)
To: u-boot
On 11/29/2017 10:00 AM, Bin Meng wrote:
> Hi Heinrich,
>
> On Fri, Nov 24, 2017 at 4:12 PM, Bin Meng <bmeng.cn@gmail.com> wrote:
>> Hi Heinrich,
>>
>> On Mon, Nov 20, 2017 at 5:20 PM, Bin Meng <bmeng.cn@gmail.com> wrote:
>>> On Mon, Nov 20, 2017 at 3:07 PM, Bin Meng <bmeng.cn@gmail.com> wrote:
>>>> On Mon, Nov 20, 2017 at 1:30 AM, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>>>>> Enable CONFIG_DISTRO_DEFAULTS in qemu-x86_64_defconfig
>>>>> and qemu-x86_defconfig.
>>>>>
>>>>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>>>>> ---
>>>>> configs/qemu-x86_64_defconfig | 1 +
>>>>> configs/qemu-x86_defconfig | 1 +
>>>>> 2 files changed, 2 insertions(+)
>>>>>
>>>>
>>>> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
>>>
>>> applied to u-boot-x86, thanks!
>>
>> Unfortunately, this creates build warnings on QEMU.
>>
>> include/configs/x86-common.h:70:0: warning: "CONFIG_BOOTCOMMAND" redefined
>> #define CONFIG_BOOTCOMMAND \
>> ^
>>
>> Can you please post your new patch against u-boot-x86/master that
>> fixes this issue?
>
> Did you get a chance to look at this?
>
> Regards,
> Bin
>
Hello Bin,
there seem quite a lot of changes needed to get DISTRO_DEFAUlTS running
on x86. It's not only the double definition.
Please, remove the patch from your queue.
Best regards
Heinrich
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH 1/1] x86: enable DISTRO_DEFAULTS for qemu
2017-11-29 18:46 ` Heinrich Schuchardt
@ 2017-11-30 3:01 ` Bin Meng
0 siblings, 0 replies; 7+ messages in thread
From: Bin Meng @ 2017-11-30 3:01 UTC (permalink / raw)
To: u-boot
Hi Heinrich,
On Thu, Nov 30, 2017 at 2:46 AM, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
>
> On 11/29/2017 10:00 AM, Bin Meng wrote:
>>
>> Hi Heinrich,
>>
>> On Fri, Nov 24, 2017 at 4:12 PM, Bin Meng <bmeng.cn@gmail.com> wrote:
>>>
>>> Hi Heinrich,
>>>
>>> On Mon, Nov 20, 2017 at 5:20 PM, Bin Meng <bmeng.cn@gmail.com> wrote:
>>>>
>>>> On Mon, Nov 20, 2017 at 3:07 PM, Bin Meng <bmeng.cn@gmail.com> wrote:
>>>>>
>>>>> On Mon, Nov 20, 2017 at 1:30 AM, Heinrich Schuchardt
>>>>> <xypron.glpk@gmx.de> wrote:
>>>>>>
>>>>>> Enable CONFIG_DISTRO_DEFAULTS in qemu-x86_64_defconfig
>>>>>> and qemu-x86_defconfig.
>>>>>>
>>>>>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>>>>>> ---
>>>>>> configs/qemu-x86_64_defconfig | 1 +
>>>>>> configs/qemu-x86_defconfig | 1 +
>>>>>> 2 files changed, 2 insertions(+)
>>>>>>
>>>>>
>>>>> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
>>>>
>>>>
>>>> applied to u-boot-x86, thanks!
>>>
>>>
>>> Unfortunately, this creates build warnings on QEMU.
>>>
>>> include/configs/x86-common.h:70:0: warning: "CONFIG_BOOTCOMMAND"
>>> redefined
>>> #define CONFIG_BOOTCOMMAND \
>>> ^
>>>
>>> Can you please post your new patch against u-boot-x86/master that
>>> fixes this issue?
>>
>>
>> Did you get a chance to look at this?
>>
>> Regards,
>> Bin
>>
> Hello Bin,
>
> there seem quite a lot of changes needed to get DISTRO_DEFAUlTS running on
> x86. It's not only the double definition.
>
> Please, remove the patch from your queue.
>
Thanks for your confirmation.
Regards,
Bin
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-11-30 3:01 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-19 17:30 [U-Boot] [PATCH 1/1] x86: enable DISTRO_DEFAULTS for qemu Heinrich Schuchardt
2017-11-20 7:07 ` Bin Meng
2017-11-20 9:20 ` Bin Meng
2017-11-24 8:12 ` Bin Meng
2017-11-29 9:00 ` Bin Meng
2017-11-29 18:46 ` Heinrich Schuchardt
2017-11-30 3:01 ` Bin Meng
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.