From: Pin-yen Lin <treapking@chromium.org> To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Cc: Matthias Brugger <matthias.bgg@gmail.com>, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Hsin-Yi Wang <hsinyi@chromium.org>, Evan Benn <evanbenn@chromium.org>, Eizan Miyamoto <eizan@chromium.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org Subject: Re: [PATCH v4] arm64: dts: mt8173-elm: Switch to SMC watchdog Date: Fri, 29 Jul 2022 16:26:35 +0800 [thread overview] Message-ID: <CAEXTbpfRWX_RfR6DU31NweLrGTOZTi_hCs-515xaW6x_McnJ5Q@mail.gmail.com> (raw) In-Reply-To: <2719519a-4690-4cc8-42c3-f6089d888cce@collabora.com> On Fri, Jul 29, 2022 at 4:01 PM AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> wrote: > > Il 29/07/22 05:24, Pin-yen Lin ha scritto: > > Switch to SMC watchdog because we need direct control of HW watchdog > > registers from kernel. The corresponding firmware was uploaded in > > https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/3405. > > > > Signed-off-by: Pin-yen Lin <treapking@chromium.org> > > --- > > > > Changes in v4: > > - Rename the watchdog node (smc_watchdog -> watchdog) > > - Correct the patch summary (mt8173-oak -> mt8173-elm) > > > > Changes in v3: > > - Remove /delete-node/ and create a new node for SMC watchdog. > > > > Changes in v2: > > - Move the modifications to mt8173-elm.dtsi and add some comments. > > > > arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 13 +++++++++++++ > > 1 file changed, 13 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > > index e21feb85d822..421bb2945135 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > > @@ -161,6 +161,19 @@ hdmi_connector_in: endpoint { > > }; > > }; > > }; > > + > > + > > You don't need two blank lines, just one is enough (please fix). This is already addressed in v5. Thanks for the review though. > > After which: > > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > > > + watchdog { > > + compatible = "arm,smc-wdt"; > > + }; > > +}; > > + > > +/* > > + * Disable the original MMIO watch dog and switch to the SMC watchdog, which > > + * operates on the same MMIO. > > + */ > > +&watchdog { > > + status = "disabled"; > > }; > > > > &mfg_async { > > > >
WARNING: multiple messages have this Message-ID (diff)
From: Pin-yen Lin <treapking@chromium.org> To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Cc: Matthias Brugger <matthias.bgg@gmail.com>, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Hsin-Yi Wang <hsinyi@chromium.org>, Evan Benn <evanbenn@chromium.org>, Eizan Miyamoto <eizan@chromium.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org Subject: Re: [PATCH v4] arm64: dts: mt8173-elm: Switch to SMC watchdog Date: Fri, 29 Jul 2022 16:26:35 +0800 [thread overview] Message-ID: <CAEXTbpfRWX_RfR6DU31NweLrGTOZTi_hCs-515xaW6x_McnJ5Q@mail.gmail.com> (raw) In-Reply-To: <2719519a-4690-4cc8-42c3-f6089d888cce@collabora.com> On Fri, Jul 29, 2022 at 4:01 PM AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> wrote: > > Il 29/07/22 05:24, Pin-yen Lin ha scritto: > > Switch to SMC watchdog because we need direct control of HW watchdog > > registers from kernel. The corresponding firmware was uploaded in > > https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/3405. > > > > Signed-off-by: Pin-yen Lin <treapking@chromium.org> > > --- > > > > Changes in v4: > > - Rename the watchdog node (smc_watchdog -> watchdog) > > - Correct the patch summary (mt8173-oak -> mt8173-elm) > > > > Changes in v3: > > - Remove /delete-node/ and create a new node for SMC watchdog. > > > > Changes in v2: > > - Move the modifications to mt8173-elm.dtsi and add some comments. > > > > arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 13 +++++++++++++ > > 1 file changed, 13 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > > index e21feb85d822..421bb2945135 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > > @@ -161,6 +161,19 @@ hdmi_connector_in: endpoint { > > }; > > }; > > }; > > + > > + > > You don't need two blank lines, just one is enough (please fix). This is already addressed in v5. Thanks for the review though. > > After which: > > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > > > + watchdog { > > + compatible = "arm,smc-wdt"; > > + }; > > +}; > > + > > +/* > > + * Disable the original MMIO watch dog and switch to the SMC watchdog, which > > + * operates on the same MMIO. > > + */ > > +&watchdog { > > + status = "disabled"; > > }; > > > > &mfg_async { > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-29 8:28 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-07-29 3:24 [PATCH v4] arm64: dts: mt8173-elm: Switch to SMC watchdog Pin-yen Lin 2022-07-29 3:24 ` Pin-yen Lin 2022-07-29 8:01 ` AngeloGioacchino Del Regno 2022-07-29 8:01 ` AngeloGioacchino Del Regno 2022-07-29 8:26 ` Pin-yen Lin [this message] 2022-07-29 8:26 ` Pin-yen Lin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAEXTbpfRWX_RfR6DU31NweLrGTOZTi_hCs-515xaW6x_McnJ5Q@mail.gmail.com \ --to=treapking@chromium.org \ --cc=angelogioacchino.delregno@collabora.com \ --cc=devicetree@vger.kernel.org \ --cc=eizan@chromium.org \ --cc=evanbenn@chromium.org \ --cc=hsinyi@chromium.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=matthias.bgg@gmail.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.