* [PATCH v4] arm64: dts: mt8173-elm: Switch to SMC watchdog
@ 2022-07-29 3:24 ` Pin-yen Lin
0 siblings, 0 replies; 6+ messages in thread
From: Pin-yen Lin @ 2022-07-29 3:24 UTC (permalink / raw)
To: Matthias Brugger, linux-arm-kernel, linux-mediatek, linux-kernel
Cc: Hsin-Yi Wang, Evan Benn, Eizan Miyamoto, Pin-yen Lin,
Krzysztof Kozlowski, Rob Herring, devicetree
Switch to SMC watchdog because we need direct control of HW watchdog
registers from kernel. The corresponding firmware was uploaded in
https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/3405.
Signed-off-by: Pin-yen Lin <treapking@chromium.org>
---
Changes in v4:
- Rename the watchdog node (smc_watchdog -> watchdog)
- Correct the patch summary (mt8173-oak -> mt8173-elm)
Changes in v3:
- Remove /delete-node/ and create a new node for SMC watchdog.
Changes in v2:
- Move the modifications to mt8173-elm.dtsi and add some comments.
arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
index e21feb85d822..421bb2945135 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
@@ -161,6 +161,19 @@ hdmi_connector_in: endpoint {
};
};
};
+
+
+ watchdog {
+ compatible = "arm,smc-wdt";
+ };
+};
+
+/*
+ * Disable the original MMIO watch dog and switch to the SMC watchdog, which
+ * operates on the same MMIO.
+ */
+&watchdog {
+ status = "disabled";
};
&mfg_async {
--
2.37.1.455.g008518b4e5-goog
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v4] arm64: dts: mt8173-elm: Switch to SMC watchdog
@ 2022-07-29 3:24 ` Pin-yen Lin
0 siblings, 0 replies; 6+ messages in thread
From: Pin-yen Lin @ 2022-07-29 3:24 UTC (permalink / raw)
To: Matthias Brugger, linux-arm-kernel, linux-mediatek, linux-kernel
Cc: Hsin-Yi Wang, Evan Benn, Eizan Miyamoto, Pin-yen Lin,
Krzysztof Kozlowski, Rob Herring, devicetree
Switch to SMC watchdog because we need direct control of HW watchdog
registers from kernel. The corresponding firmware was uploaded in
https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/3405.
Signed-off-by: Pin-yen Lin <treapking@chromium.org>
---
Changes in v4:
- Rename the watchdog node (smc_watchdog -> watchdog)
- Correct the patch summary (mt8173-oak -> mt8173-elm)
Changes in v3:
- Remove /delete-node/ and create a new node for SMC watchdog.
Changes in v2:
- Move the modifications to mt8173-elm.dtsi and add some comments.
arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
index e21feb85d822..421bb2945135 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
@@ -161,6 +161,19 @@ hdmi_connector_in: endpoint {
};
};
};
+
+
+ watchdog {
+ compatible = "arm,smc-wdt";
+ };
+};
+
+/*
+ * Disable the original MMIO watch dog and switch to the SMC watchdog, which
+ * operates on the same MMIO.
+ */
+&watchdog {
+ status = "disabled";
};
&mfg_async {
--
2.37.1.455.g008518b4e5-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v4] arm64: dts: mt8173-elm: Switch to SMC watchdog
2022-07-29 3:24 ` Pin-yen Lin
@ 2022-07-29 8:01 ` AngeloGioacchino Del Regno
-1 siblings, 0 replies; 6+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-07-29 8:01 UTC (permalink / raw)
To: Pin-yen Lin, Matthias Brugger, linux-arm-kernel, linux-mediatek,
linux-kernel
Cc: Hsin-Yi Wang, Evan Benn, Eizan Miyamoto, Krzysztof Kozlowski,
Rob Herring, devicetree
Il 29/07/22 05:24, Pin-yen Lin ha scritto:
> Switch to SMC watchdog because we need direct control of HW watchdog
> registers from kernel. The corresponding firmware was uploaded in
> https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/3405.
>
> Signed-off-by: Pin-yen Lin <treapking@chromium.org>
> ---
>
> Changes in v4:
> - Rename the watchdog node (smc_watchdog -> watchdog)
> - Correct the patch summary (mt8173-oak -> mt8173-elm)
>
> Changes in v3:
> - Remove /delete-node/ and create a new node for SMC watchdog.
>
> Changes in v2:
> - Move the modifications to mt8173-elm.dtsi and add some comments.
>
> arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> index e21feb85d822..421bb2945135 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> @@ -161,6 +161,19 @@ hdmi_connector_in: endpoint {
> };
> };
> };
> +
> +
You don't need two blank lines, just one is enough (please fix).
After which:
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> + watchdog {
> + compatible = "arm,smc-wdt";
> + };
> +};
> +
> +/*
> + * Disable the original MMIO watch dog and switch to the SMC watchdog, which
> + * operates on the same MMIO.
> + */
> +&watchdog {
> + status = "disabled";
> };
>
> &mfg_async {
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v4] arm64: dts: mt8173-elm: Switch to SMC watchdog
@ 2022-07-29 8:01 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 6+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-07-29 8:01 UTC (permalink / raw)
To: Pin-yen Lin, Matthias Brugger, linux-arm-kernel, linux-mediatek,
linux-kernel
Cc: Hsin-Yi Wang, Evan Benn, Eizan Miyamoto, Krzysztof Kozlowski,
Rob Herring, devicetree
Il 29/07/22 05:24, Pin-yen Lin ha scritto:
> Switch to SMC watchdog because we need direct control of HW watchdog
> registers from kernel. The corresponding firmware was uploaded in
> https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/3405.
>
> Signed-off-by: Pin-yen Lin <treapking@chromium.org>
> ---
>
> Changes in v4:
> - Rename the watchdog node (smc_watchdog -> watchdog)
> - Correct the patch summary (mt8173-oak -> mt8173-elm)
>
> Changes in v3:
> - Remove /delete-node/ and create a new node for SMC watchdog.
>
> Changes in v2:
> - Move the modifications to mt8173-elm.dtsi and add some comments.
>
> arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> index e21feb85d822..421bb2945135 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> @@ -161,6 +161,19 @@ hdmi_connector_in: endpoint {
> };
> };
> };
> +
> +
You don't need two blank lines, just one is enough (please fix).
After which:
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> + watchdog {
> + compatible = "arm,smc-wdt";
> + };
> +};
> +
> +/*
> + * Disable the original MMIO watch dog and switch to the SMC watchdog, which
> + * operates on the same MMIO.
> + */
> +&watchdog {
> + status = "disabled";
> };
>
> &mfg_async {
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v4] arm64: dts: mt8173-elm: Switch to SMC watchdog
2022-07-29 8:01 ` AngeloGioacchino Del Regno
@ 2022-07-29 8:26 ` Pin-yen Lin
-1 siblings, 0 replies; 6+ messages in thread
From: Pin-yen Lin @ 2022-07-29 8:26 UTC (permalink / raw)
To: AngeloGioacchino Del Regno
Cc: Matthias Brugger, linux-arm-kernel, linux-mediatek, linux-kernel,
Hsin-Yi Wang, Evan Benn, Eizan Miyamoto, Krzysztof Kozlowski,
Rob Herring, devicetree
On Fri, Jul 29, 2022 at 4:01 PM AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> wrote:
>
> Il 29/07/22 05:24, Pin-yen Lin ha scritto:
> > Switch to SMC watchdog because we need direct control of HW watchdog
> > registers from kernel. The corresponding firmware was uploaded in
> > https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/3405.
> >
> > Signed-off-by: Pin-yen Lin <treapking@chromium.org>
> > ---
> >
> > Changes in v4:
> > - Rename the watchdog node (smc_watchdog -> watchdog)
> > - Correct the patch summary (mt8173-oak -> mt8173-elm)
> >
> > Changes in v3:
> > - Remove /delete-node/ and create a new node for SMC watchdog.
> >
> > Changes in v2:
> > - Move the modifications to mt8173-elm.dtsi and add some comments.
> >
> > arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 13 +++++++++++++
> > 1 file changed, 13 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> > index e21feb85d822..421bb2945135 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> > @@ -161,6 +161,19 @@ hdmi_connector_in: endpoint {
> > };
> > };
> > };
> > +
> > +
>
> You don't need two blank lines, just one is enough (please fix).
This is already addressed in v5. Thanks for the review though.
>
> After which:
>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>
> > + watchdog {
> > + compatible = "arm,smc-wdt";
> > + };
> > +};
> > +
> > +/*
> > + * Disable the original MMIO watch dog and switch to the SMC watchdog, which
> > + * operates on the same MMIO.
> > + */
> > +&watchdog {
> > + status = "disabled";
> > };
> >
> > &mfg_async {
> >
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v4] arm64: dts: mt8173-elm: Switch to SMC watchdog
@ 2022-07-29 8:26 ` Pin-yen Lin
0 siblings, 0 replies; 6+ messages in thread
From: Pin-yen Lin @ 2022-07-29 8:26 UTC (permalink / raw)
To: AngeloGioacchino Del Regno
Cc: Matthias Brugger, linux-arm-kernel, linux-mediatek, linux-kernel,
Hsin-Yi Wang, Evan Benn, Eizan Miyamoto, Krzysztof Kozlowski,
Rob Herring, devicetree
On Fri, Jul 29, 2022 at 4:01 PM AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> wrote:
>
> Il 29/07/22 05:24, Pin-yen Lin ha scritto:
> > Switch to SMC watchdog because we need direct control of HW watchdog
> > registers from kernel. The corresponding firmware was uploaded in
> > https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/3405.
> >
> > Signed-off-by: Pin-yen Lin <treapking@chromium.org>
> > ---
> >
> > Changes in v4:
> > - Rename the watchdog node (smc_watchdog -> watchdog)
> > - Correct the patch summary (mt8173-oak -> mt8173-elm)
> >
> > Changes in v3:
> > - Remove /delete-node/ and create a new node for SMC watchdog.
> >
> > Changes in v2:
> > - Move the modifications to mt8173-elm.dtsi and add some comments.
> >
> > arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 13 +++++++++++++
> > 1 file changed, 13 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> > index e21feb85d822..421bb2945135 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> > @@ -161,6 +161,19 @@ hdmi_connector_in: endpoint {
> > };
> > };
> > };
> > +
> > +
>
> You don't need two blank lines, just one is enough (please fix).
This is already addressed in v5. Thanks for the review though.
>
> After which:
>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>
> > + watchdog {
> > + compatible = "arm,smc-wdt";
> > + };
> > +};
> > +
> > +/*
> > + * Disable the original MMIO watch dog and switch to the SMC watchdog, which
> > + * operates on the same MMIO.
> > + */
> > +&watchdog {
> > + status = "disabled";
> > };
> >
> > &mfg_async {
> >
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-07-29 8:39 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-29 3:24 [PATCH v4] arm64: dts: mt8173-elm: Switch to SMC watchdog Pin-yen Lin
2022-07-29 3:24 ` Pin-yen Lin
2022-07-29 8:01 ` AngeloGioacchino Del Regno
2022-07-29 8:01 ` AngeloGioacchino Del Regno
2022-07-29 8:26 ` Pin-yen Lin
2022-07-29 8:26 ` Pin-yen Lin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.