From: Djalal Harouni <tixxdz@gmail.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Kees Cook <keescook@chromium.org>,
Alexey Gladkov <gladkov.alexey@gmail.com>,
Andy Lutomirski <luto@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux FS Devel <linux-fsdevel@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
kernel-hardening@lists.openwall.com,
LSM List <linux-security-module@vger.kernel.org>,
Linux API <linux-api@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Akinobu Mita <akinobu.mita@gmail.com>,
"Tobin C. Harding" <me@tobin.cc>, Oleg Nesterov <oleg@redhat.com>,
Jeff Layton <jlayton@poochiereds.net>,
Ingo Molnar <mingo@kernel.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Daniel Micay <danielmicay@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
"J. Bruce Fields" <bfields@fieldses.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Solar Designer <solar@openwall.com>
Subject: Re: [PATCH RFC v3 1/7] proc: add proc_fs_info struct to store proc information
Date: Fri, 10 Nov 2017 11:32:55 +0100 [thread overview]
Message-ID: <CAEiveUdj=PbJ6pGAX-wr3Fz+4=y6QbiDSE=mU6yKwxn11OU_gw@mail.gmail.com> (raw)
In-Reply-To: <CACVxJT88zLoekiwFxq1rdDEnFxPnpZeDYHOWEVQEwHZvFdOy4A@mail.gmail.com>
On Fri, Nov 10, 2017 at 11:26 AM, Alexey Dobriyan <adobriyan@gmail.com> wrote:
> On 11/9/17, Djalal Harouni <tixxdz@gmail.com> wrote:
>
>> +struct proc_fs_info {
>> + struct pid_namespace *pid_ns;
>> +};
>
>> +static inline struct proc_fs_info *proc_sb(struct super_block *sb)
>> +{
>> + return sb->s_fs_info;
>> +}
>
> Can you rename this to "struct proc_super_block *" then?
> That "info" suffix all over filesystems doesn't add much info itself
> just more typing.
> Ditto for "fs_info" identifiers.
Ok, will do.
>> +extern inline struct proc_fs_info *proc_sb(struct super_block *sb)
>> { return NULL;}
>
> extern inline?
Oups, sorry will fix it and try to compile without proc.
Thank you!
--
tixxdz
WARNING: multiple messages have this Message-ID (diff)
From: Djalal Harouni <tixxdz@gmail.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Kees Cook <keescook@chromium.org>,
Alexey Gladkov <gladkov.alexey@gmail.com>,
Andy Lutomirski <luto@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux FS Devel <linux-fsdevel@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
kernel-hardening@lists.openwall.com,
LSM List <linux-security-module@vger.kernel.org>,
Linux API <linux-api@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Akinobu Mita <akinobu.mita@gmail.com>,
"Tobin C. Harding" <me@tobin.cc>, Oleg Nesterov <oleg@redhat.com>,
Jeff Layton <jlayton@poochiereds.net>,
Ingo Molnar <mingo@kernel.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Daniel Micay <danielmica>
Subject: Re: [PATCH RFC v3 1/7] proc: add proc_fs_info struct to store proc information
Date: Fri, 10 Nov 2017 11:32:55 +0100 [thread overview]
Message-ID: <CAEiveUdj=PbJ6pGAX-wr3Fz+4=y6QbiDSE=mU6yKwxn11OU_gw@mail.gmail.com> (raw)
In-Reply-To: <CACVxJT88zLoekiwFxq1rdDEnFxPnpZeDYHOWEVQEwHZvFdOy4A@mail.gmail.com>
On Fri, Nov 10, 2017 at 11:26 AM, Alexey Dobriyan <adobriyan@gmail.com> wrote:
> On 11/9/17, Djalal Harouni <tixxdz@gmail.com> wrote:
>
>> +struct proc_fs_info {
>> + struct pid_namespace *pid_ns;
>> +};
>
>> +static inline struct proc_fs_info *proc_sb(struct super_block *sb)
>> +{
>> + return sb->s_fs_info;
>> +}
>
> Can you rename this to "struct proc_super_block *" then?
> That "info" suffix all over filesystems doesn't add much info itself
> just more typing.
> Ditto for "fs_info" identifiers.
Ok, will do.
>> +extern inline struct proc_fs_info *proc_sb(struct super_block *sb)
>> { return NULL;}
>
> extern inline?
Oups, sorry will fix it and try to compile without proc.
Thank you!
--
tixxdz
WARNING: multiple messages have this Message-ID (diff)
From: tixxdz@gmail.com (Djalal Harouni)
To: linux-security-module@vger.kernel.org
Subject: [PATCH RFC v3 1/7] proc: add proc_fs_info struct to store proc information
Date: Fri, 10 Nov 2017 11:32:55 +0100 [thread overview]
Message-ID: <CAEiveUdj=PbJ6pGAX-wr3Fz+4=y6QbiDSE=mU6yKwxn11OU_gw@mail.gmail.com> (raw)
In-Reply-To: <CACVxJT88zLoekiwFxq1rdDEnFxPnpZeDYHOWEVQEwHZvFdOy4A@mail.gmail.com>
On Fri, Nov 10, 2017 at 11:26 AM, Alexey Dobriyan <adobriyan@gmail.com> wrote:
> On 11/9/17, Djalal Harouni <tixxdz@gmail.com> wrote:
>
>> +struct proc_fs_info {
>> + struct pid_namespace *pid_ns;
>> +};
>
>> +static inline struct proc_fs_info *proc_sb(struct super_block *sb)
>> +{
>> + return sb->s_fs_info;
>> +}
>
> Can you rename this to "struct proc_super_block *" then?
> That "info" suffix all over filesystems doesn't add much info itself
> just more typing.
> Ditto for "fs_info" identifiers.
Ok, will do.
>> +extern inline struct proc_fs_info *proc_sb(struct super_block *sb)
>> { return NULL;}
>
> extern inline?
Oups, sorry will fix it and try to compile without proc.
Thank you!
--
tixxdz
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Djalal Harouni <tixxdz@gmail.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Kees Cook <keescook@chromium.org>,
Alexey Gladkov <gladkov.alexey@gmail.com>,
Andy Lutomirski <luto@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux FS Devel <linux-fsdevel@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
kernel-hardening@lists.openwall.com,
LSM List <linux-security-module@vger.kernel.org>,
Linux API <linux-api@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Akinobu Mita <akinobu.mita@gmail.com>,
"Tobin C. Harding" <me@tobin.cc>, Oleg Nesterov <oleg@redhat.com>,
Jeff Layton <jlayton@poochiereds.net>,
Ingo Molnar <mingo@kernel.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Daniel Micay <danielmicay@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
"J. Bruce Fields" <bfields@fieldses.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Solar Designer <solar@openwall.com>
Subject: [kernel-hardening] Re: [PATCH RFC v3 1/7] proc: add proc_fs_info struct to store proc information
Date: Fri, 10 Nov 2017 11:32:55 +0100 [thread overview]
Message-ID: <CAEiveUdj=PbJ6pGAX-wr3Fz+4=y6QbiDSE=mU6yKwxn11OU_gw@mail.gmail.com> (raw)
In-Reply-To: <CACVxJT88zLoekiwFxq1rdDEnFxPnpZeDYHOWEVQEwHZvFdOy4A@mail.gmail.com>
On Fri, Nov 10, 2017 at 11:26 AM, Alexey Dobriyan <adobriyan@gmail.com> wrote:
> On 11/9/17, Djalal Harouni <tixxdz@gmail.com> wrote:
>
>> +struct proc_fs_info {
>> + struct pid_namespace *pid_ns;
>> +};
>
>> +static inline struct proc_fs_info *proc_sb(struct super_block *sb)
>> +{
>> + return sb->s_fs_info;
>> +}
>
> Can you rename this to "struct proc_super_block *" then?
> That "info" suffix all over filesystems doesn't add much info itself
> just more typing.
> Ditto for "fs_info" identifiers.
Ok, will do.
>> +extern inline struct proc_fs_info *proc_sb(struct super_block *sb)
>> { return NULL;}
>
> extern inline?
Oups, sorry will fix it and try to compile without proc.
Thank you!
--
tixxdz
next prev parent reply other threads:[~2017-11-10 10:32 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-09 16:13 [PATCH RFC v3 0/7] proc: modernize proc to support multiple private instances Djalal Harouni
2017-11-09 16:13 ` [kernel-hardening] " Djalal Harouni
2017-11-09 16:13 ` Djalal Harouni
2017-11-09 16:14 ` [PATCH RFC v3 1/7] proc: add proc_fs_info struct to store proc information Djalal Harouni
2017-11-09 16:14 ` [kernel-hardening] " Djalal Harouni
2017-11-09 16:14 ` Djalal Harouni
2017-11-10 10:26 ` Alexey Dobriyan
2017-11-10 10:26 ` [kernel-hardening] " Alexey Dobriyan
2017-11-10 10:26 ` Alexey Dobriyan
2017-11-10 10:26 ` Alexey Dobriyan
2017-11-10 10:32 ` Djalal Harouni [this message]
2017-11-10 10:32 ` [kernel-hardening] " Djalal Harouni
2017-11-10 10:32 ` Djalal Harouni
2017-11-10 10:32 ` Djalal Harouni
2017-11-09 16:14 ` [PATCH RFC v3 2/7] proc: move /proc/{self|thread-self} dentries to proc_fs_info Djalal Harouni
2017-11-09 16:14 ` [kernel-hardening] " Djalal Harouni
2017-11-09 16:14 ` Djalal Harouni
2017-11-10 10:31 ` Alexey Dobriyan
2017-11-10 10:31 ` [kernel-hardening] " Alexey Dobriyan
2017-11-10 10:31 ` Alexey Dobriyan
2017-11-10 10:31 ` Alexey Dobriyan
2017-11-10 10:45 ` Djalal Harouni
2017-11-10 10:45 ` [kernel-hardening] " Djalal Harouni
2017-11-10 10:45 ` Djalal Harouni
2017-11-10 10:45 ` Djalal Harouni
2017-11-09 16:14 ` [PATCH RFC v3 3/7] proc: add helpers to set and get proc hidepid and gid mount options Djalal Harouni
2017-11-09 16:14 ` [kernel-hardening] " Djalal Harouni
2017-11-09 16:14 ` Djalal Harouni
2017-11-10 10:36 ` Alexey Dobriyan
2017-11-10 10:36 ` [kernel-hardening] " Alexey Dobriyan
2017-11-10 10:36 ` Alexey Dobriyan
2017-11-10 10:36 ` Alexey Dobriyan
2017-11-10 10:41 ` Djalal Harouni
2017-11-10 10:41 ` [kernel-hardening] " Djalal Harouni
2017-11-10 10:41 ` Djalal Harouni
2017-11-10 10:41 ` Djalal Harouni
2017-11-09 16:14 ` [PATCH RFC v3 4/7] proc: support mounting private procfs instances inside same pid namespace Djalal Harouni
2017-11-09 16:14 ` [kernel-hardening] " Djalal Harouni
2017-11-09 16:14 ` Djalal Harouni
2017-11-10 2:53 ` James Morris
2017-11-10 2:53 ` [kernel-hardening] " James Morris
2017-11-10 2:53 ` James Morris
2017-11-10 2:53 ` James Morris
2017-11-10 10:33 ` Djalal Harouni
2017-11-10 10:33 ` [kernel-hardening] " Djalal Harouni
2017-11-10 10:33 ` Djalal Harouni
2017-11-10 10:33 ` Djalal Harouni
2017-11-09 16:14 ` [PATCH RFC v3 5/7] proc: move hidepid definitions to proc files Djalal Harouni
2017-11-09 16:14 ` [kernel-hardening] " Djalal Harouni
2017-11-09 16:14 ` Djalal Harouni
2017-11-09 16:14 ` [PATCH RFC v3 6/7] proc: support new 'pids=all|ptraceable' mount option Djalal Harouni
2017-11-09 16:14 ` [kernel-hardening] " Djalal Harouni
2017-11-09 16:14 ` Djalal Harouni
2017-11-10 2:38 ` Andy Lutomirski
2017-11-10 2:38 ` [kernel-hardening] " Andy Lutomirski
2017-11-10 2:38 ` Andy Lutomirski
2017-11-10 2:38 ` Andy Lutomirski
2017-11-10 2:38 ` Andy Lutomirski
2017-11-10 10:38 ` Djalal Harouni
2017-11-10 10:38 ` [kernel-hardening] " Djalal Harouni
2017-11-10 10:38 ` Djalal Harouni
2017-11-10 10:38 ` Djalal Harouni
2017-11-10 10:38 ` Djalal Harouni
2017-11-10 2:56 ` James Morris
2017-11-10 2:56 ` [kernel-hardening] " James Morris
2017-11-10 2:56 ` James Morris
2017-11-10 2:56 ` James Morris
2017-11-09 16:14 ` [PATCH RFC v3 7/7] proc: flush dcache entries from all procfs instances Djalal Harouni
2017-11-09 16:14 ` [kernel-hardening] " Djalal Harouni
2017-11-09 16:14 ` Djalal Harouni
2017-11-09 16:14 ` Djalal Harouni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEiveUdj=PbJ6pGAX-wr3Fz+4=y6QbiDSE=mU6yKwxn11OU_gw@mail.gmail.com' \
--to=tixxdz@gmail.com \
--cc=adobriyan@gmail.com \
--cc=akinobu.mita@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bfields@fieldses.org \
--cc=corbet@lwn.net \
--cc=danielmicay@gmail.com \
--cc=ebiederm@xmission.com \
--cc=gladkov.alexey@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jlayton@poochiereds.net \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=luto@kernel.org \
--cc=me@tobin.cc \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=sfr@canb.auug.org.au \
--cc=solar@openwall.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.