From: Vincent Legoll <vincent.legoll@gmail.com>
To: christian@kohlschutter.com
Cc: broonie@kernel.org, heiko@sntech.de, lgirdwood@gmail.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-rockchip@lists.infradead.org, m.reichl@fivetechno.de,
robin.murphy@arm.com, wens@kernel.org
Subject: Re: [PATCH v2] regulator: core: Resolve supply name earlier to prevent double-init
Date: Wed, 3 Aug 2022 16:33:23 +0200 [thread overview]
Message-ID: <CAEwRq=qe+Frwpe=Zr4n_8A6vjOJnV3noegdnHSN7NTazkKejBA@mail.gmail.com> (raw)
Hello,
it looks like you left a test for '&& rdev->constraints' in the if after you
moved the 'if (!rdev->constraints) {' above it.
--
Vincent Legoll
next reply other threads:[~2022-08-03 14:33 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 14:33 Vincent Legoll [this message]
2022-08-04 10:44 ` [PATCH v3] regulator: core: Resolve supply name earlier to prevent double-init Christian Kohlschütter
2022-08-04 10:44 ` Christian Kohlschütter
2022-08-04 10:44 ` Christian Kohlschütter
2022-08-15 11:17 ` Mark Brown
2022-08-15 11:17 ` Mark Brown
2022-08-15 11:17 ` Mark Brown
2022-08-18 12:46 ` [PATCH v4] " Christian Kohlschütter
2022-08-18 12:46 ` Christian Kohlschütter
2022-08-18 12:46 ` Christian Kohlschütter
2022-08-18 15:23 ` Mark Brown
2022-08-18 15:23 ` Mark Brown
[not found] ` <CGME20220825113251eucas1p247c3d57de823da148ca4790975a4aba8@eucas1p2.samsung.com>
2022-08-25 11:32 ` Marek Szyprowski
2022-08-25 11:32 ` Marek Szyprowski
2022-08-25 11:32 ` Marek Szyprowski
2022-08-25 12:21 ` Mark Brown
2022-08-25 12:21 ` Mark Brown
2022-08-25 12:21 ` Mark Brown
2022-08-25 14:23 ` Marek Szyprowski
2022-08-25 14:23 ` Marek Szyprowski
2022-08-25 14:23 ` Marek Szyprowski
2022-08-25 15:18 ` Christian Kohlschütter
2022-08-25 15:18 ` Christian Kohlschütter
2022-08-25 15:18 ` Christian Kohlschütter
2022-08-25 21:28 ` [PATCH v5] " Christian Kohlschütter
2022-08-25 21:28 ` Christian Kohlschütter
2022-08-25 21:28 ` Christian Kohlschütter
2022-08-25 21:35 ` Christian Kohlschütter
2022-08-25 21:35 ` Christian Kohlschütter
2022-08-25 21:35 ` Christian Kohlschütter
2022-08-26 5:55 ` Marek Szyprowski
2022-08-26 5:55 ` Marek Szyprowski
2022-08-26 5:55 ` Marek Szyprowski
2022-08-29 15:43 ` Mark Brown
2022-08-29 15:43 ` Mark Brown
2022-08-29 15:43 ` Mark Brown
2022-08-29 17:01 ` Christian Kohlschütter
2022-08-29 17:01 ` Christian Kohlschütter
2022-08-29 17:01 ` Christian Kohlschütter
2023-02-17 23:22 ` Saravana Kannan
2023-02-17 23:22 ` Saravana Kannan
2023-02-17 23:22 ` Saravana Kannan
2023-02-17 23:33 ` Christian Kohlschütter
2023-02-17 23:33 ` Christian Kohlschütter
2023-02-17 23:33 ` Christian Kohlschütter
2023-02-17 23:46 ` Saravana Kannan
2023-02-17 23:46 ` Saravana Kannan
2023-02-17 23:46 ` Saravana Kannan
2023-02-18 0:01 ` Christian Kohlschütter
2023-02-18 0:01 ` Christian Kohlschütter
2023-02-18 0:01 ` Christian Kohlschütter
2023-02-18 0:05 ` Saravana Kannan
2023-02-18 0:05 ` Saravana Kannan
2023-02-18 0:05 ` Saravana Kannan
2022-08-18 15:22 ` [PATCH v3] " Mark Brown
2022-08-18 15:22 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2022-07-15 20:32 [PATCH] " Christian Kohlschütter
2022-07-21 15:01 ` Mark Brown
2022-07-22 17:42 ` [PATCH v2] " Christian Kohlschütter
2022-07-22 17:42 ` Christian Kohlschütter
2022-07-22 17:42 ` Christian Kohlschütter
2022-08-18 15:22 ` Mark Brown
2022-08-18 15:22 ` Mark Brown
2022-10-28 16:59 ` Christian Kohlschütter
2022-10-28 16:59 ` Christian Kohlschütter
2022-10-28 16:59 ` Christian Kohlschütter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEwRq=qe+Frwpe=Zr4n_8A6vjOJnV3noegdnHSN7NTazkKejBA@mail.gmail.com' \
--to=vincent.legoll@gmail.com \
--cc=broonie@kernel.org \
--cc=christian@kohlschutter.com \
--cc=heiko@sntech.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=m.reichl@fivetechno.de \
--cc=robin.murphy@arm.com \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.