From: Mike Rapoport <mike.rapoport@ravellosystems.com>
To: Cong Wang <cwang@twopensource.com>
Cc: David Miller <davem@davemloft.net>,
David Stevens <dlstevens@us.ibm.com>,
netdev <netdev@vger.kernel.org>,
stable@vger.kernel.org
Subject: Re: [PATCH net] net: vxlan: fix crash when interface is created with no group
Date: Wed, 2 Apr 2014 08:51:51 +0300 [thread overview]
Message-ID: <CAF1J0HOyAaAnMU+Eb-SLdy8CzmOiueSr7K-cc6TbfCf5hm_66A@mail.gmail.com> (raw)
In-Reply-To: <CAHA+R7OO9Cc-vVzeQ4dozj1HyBgU9pHZL-aJL9KxYKx+SVaLVA@mail.gmail.com>
On Tue, Apr 1, 2014 at 10:22 PM, Cong Wang <cwang@twopensource.com> wrote:
> On Mon, Mar 31, 2014 at 11:23 PM, Mike Rapoport
> <mike.rapoport@ravellosystems.com> wrote:
>> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
>> index 1236812..d091e52 100644
>> --- a/drivers/net/vxlan.c
>> +++ b/drivers/net/vxlan.c
>> @@ -871,6 +871,9 @@ static int vxlan_fdb_add(struct ndmsg *ndm, struct nlattr *tb[],
>> if (err)
>> return err;
>>
>> + if (vxlan->default_dst.remote_ip.sa.sa_family != ip.sa.sa_family)
>> + return -EAFNOSUPPORT;
>> +
>
> Or move this check into vxlan_fdb_parse() so that vxlan_fdb_delete()
> could also catch this error?
The vxlan_fdb_delete will fail to find an entry with address from
incompatible family, and will return -ENOENT.
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2014-04-02 5:51 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-01 6:23 [PATCH net] net: vxlan: fix crash when interface is created with no group Mike Rapoport
2014-04-01 19:22 ` Cong Wang
2014-04-02 5:51 ` Mike Rapoport [this message]
2014-04-03 15:19 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2014-03-17 11:17 Mike Rapoport
2014-03-17 16:34 ` Stephen Hemminger
2014-03-18 15:10 ` Or Gerlitz
2014-03-18 15:51 ` Mike Rapoport
2014-03-19 3:20 ` David Miller
2014-03-19 6:56 ` Mike Rapoport
2014-03-18 16:41 ` Cong Wang
2014-03-18 16:55 ` David Stevens
2014-03-18 18:07 ` Cong Wang
2014-03-19 7:14 ` Mike Rapoport
2014-03-19 19:46 ` David Miller
2014-03-19 19:52 ` Mike Rapoport
2014-03-19 22:29 ` David Miller
2014-03-19 20:28 ` David Stevens
2014-03-20 3:40 ` David Miller
2014-03-19 14:08 ` David Stevens
2014-03-19 14:32 ` Mike Rapoport
2014-03-19 14:40 ` David Stevens
2014-03-20 20:02 ` David Miller
2014-03-21 5:06 ` Mike Rapoport
2014-03-20 20:47 ` David Stevens
2014-03-21 10:22 ` Mike Rapoport
2014-03-21 11:22 ` David Stevens
2014-03-21 15:31 ` Mike Rapoport
2014-03-23 9:27 ` Mike Rapoport
2014-03-23 14:43 ` Or Gerlitz
2014-03-26 0:53 ` David Miller
2014-03-26 9:47 ` Mike Rapoport
2014-03-26 14:47 ` David Stevens
2014-03-26 17:50 ` Mike Rapoport
2014-03-27 20:20 ` Cong Wang
2014-03-28 9:05 ` Mike Rapoport
2014-03-29 8:29 ` Mike Rapoport
2014-03-31 20:18 ` David Miller
2014-03-24 5:09 ` Pravin Shelar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAF1J0HOyAaAnMU+Eb-SLdy8CzmOiueSr7K-cc6TbfCf5hm_66A@mail.gmail.com \
--to=mike.rapoport@ravellosystems.com \
--cc=cwang@twopensource.com \
--cc=davem@davemloft.net \
--cc=dlstevens@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.