From: David Stevens <dlstevens@us.ibm.com>
To: David Miller <davem@davemloft.net>
Cc: mike.rapoport@ravellosystems.com, netdev@vger.kernel.org
Subject: Re: [PATCH net] net: vxlan: fix crash when interface is created with no group
Date: Thu, 20 Mar 2014 14:47:25 -0600 [thread overview]
Message-ID: <OFA209BE80.4610C3E5-ON87257CA1.00723468-87257CA1.0072346C@us.ibm.com> (raw)
In-Reply-To: <20140320.160229.857536522237793124.davem@davemloft.net>
>From: David Miller
>Any objections to this? I think it maintains the pre-ipv6-support
>behavior. I know there may be some concerns about supporting
>multiple
>families on the same socket, but I'm not so sure the code is able to
>support that right now anyways.
I'm ok with the idea of determining the AF from the socket -- mixed
support, if useful, can be added later. But the patch needs to then
check and drop packets encapsulated with the wrong address family.
And it still shouldn't assume !v4 means v6.
[apologies for spacing; doing this from a web browser...]
So, I think we need something like:
if (vs->family == AF_INET && skb->protocol == ntohs(ETH_P_IP)) {
....
} else if (vs->family == AF_INET6 && skb->protocol == ntohs(ETH_P_IPV6)) {
...
} else
goto drop
+-DLS
next prev parent reply other threads:[~2014-03-20 20:47 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 11:17 [PATCH net] net: vxlan: fix crash when interface is created with no group Mike Rapoport
2014-03-17 16:34 ` Stephen Hemminger
2014-03-18 15:10 ` Or Gerlitz
2014-03-18 15:51 ` Mike Rapoport
2014-03-19 3:20 ` David Miller
2014-03-19 6:56 ` Mike Rapoport
2014-03-18 16:41 ` Cong Wang
2014-03-18 16:55 ` David Stevens
2014-03-18 18:07 ` Cong Wang
2014-03-19 7:14 ` Mike Rapoport
2014-03-19 19:46 ` David Miller
2014-03-19 19:52 ` Mike Rapoport
2014-03-19 22:29 ` David Miller
2014-03-19 20:28 ` David Stevens
2014-03-20 3:40 ` David Miller
2014-03-19 14:08 ` David Stevens
2014-03-19 14:32 ` Mike Rapoport
2014-03-19 14:40 ` David Stevens
2014-03-20 20:02 ` David Miller
2014-03-21 5:06 ` Mike Rapoport
2014-03-20 20:47 ` David Stevens [this message]
2014-03-21 10:22 ` Mike Rapoport
2014-03-21 11:22 ` David Stevens
2014-03-21 15:31 ` Mike Rapoport
2014-03-23 9:27 ` Mike Rapoport
2014-03-23 14:43 ` Or Gerlitz
2014-03-26 0:53 ` David Miller
2014-03-26 9:47 ` Mike Rapoport
2014-03-26 14:47 ` David Stevens
2014-03-26 17:50 ` Mike Rapoport
2014-03-27 20:20 ` Cong Wang
2014-03-28 9:05 ` Mike Rapoport
2014-03-29 8:29 ` Mike Rapoport
2014-03-31 20:18 ` David Miller
2014-03-24 5:09 ` Pravin Shelar
2014-04-01 6:23 Mike Rapoport
2014-04-01 19:22 ` Cong Wang
2014-04-02 5:51 ` Mike Rapoport
2014-04-03 15:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OFA209BE80.4610C3E5-ON87257CA1.00723468-87257CA1.0072346C@us.ibm.com \
--to=dlstevens@us.ibm.com \
--cc=davem@davemloft.net \
--cc=mike.rapoport@ravellosystems.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.