All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Clark <robdclark@gmail.com>
To: Nicolas Dechesne <nicolas.dechesne@linaro.org>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	Andy Gross <andy.gross@linaro.org>,
	David Brown <david.brown@linaro.org>,
	Stephen Boyd <sboyd@codeaurora.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	linux-soc@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: qcom: Rename SBC to DragonBoard 410c
Date: Tue, 3 Oct 2017 14:54:33 -0400	[thread overview]
Message-ID: <CAF6AEGvRB_SGQ_Xv33FiPZRyp+Wf29aG_Ex6rVk2Czov-Gjj9Q@mail.gmail.com> (raw)
In-Reply-To: <CAP71Wjy2gEn=sGz5kN++=TdZ4S1cmE-3fdw-5__tdtR-M9RDGQ@mail.gmail.com>

On Tue, Oct 3, 2017 at 1:49 PM, Nicolas Dechesne
<nicolas.dechesne@linaro.org> wrote:
> On Tue, Oct 3, 2017 at 6:37 PM, Rob Clark <robdclark@gmail.com> wrote:
>> On Tue, Oct 3, 2017 at 8:25 AM, Srinivas Kandagatla
>> <srinivas.kandagatla@linaro.org> wrote:
>>>
>>>
>>> On 03/10/17 10:11, Linus Walleij wrote:
>>>>
>>>> Naming the DragonBoard 410c "SBC" (I guess "single board computer")
>>>> is not very helpful for users looking for their device tree in
>>>> the kernel. Also the db820c is named properly.
>>>>
>>>> Rectify this, simply, do not change the compatible strings but name
>>>> the DTS files in a consistent manner.
>>>>
>>>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>>>
>>> I did not like the sbc naming convention too, This was primarily done due to
>>> some legacy build tools + bootloaders which have used sbc compatible to
>>> identify boards from multiple dtb blobs. Now that we can append dtb to
>>> kernel with new LK, this should not be a issue anymore.
>>
>> maybe it would be an idea to update skales/dbttool first to look for
>> the new name, and then give people some time to upgrade, before
>> changing this in the kernel.  Otherwise I expect you'll cause some
>> confusion..
>
> iirc, skale is using the compatible name, not the filename.
>

ahh, yes, I think you are right.. u-boot is using a different filename.

So in this case, no issue to pick a saner name :-)

BR,
-R

WARNING: multiple messages have this Message-ID (diff)
From: robdclark@gmail.com (Rob Clark)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] arm64: dts: qcom: Rename SBC to DragonBoard 410c
Date: Tue, 3 Oct 2017 14:54:33 -0400	[thread overview]
Message-ID: <CAF6AEGvRB_SGQ_Xv33FiPZRyp+Wf29aG_Ex6rVk2Czov-Gjj9Q@mail.gmail.com> (raw)
In-Reply-To: <CAP71Wjy2gEn=sGz5kN++=TdZ4S1cmE-3fdw-5__tdtR-M9RDGQ@mail.gmail.com>

On Tue, Oct 3, 2017 at 1:49 PM, Nicolas Dechesne
<nicolas.dechesne@linaro.org> wrote:
> On Tue, Oct 3, 2017 at 6:37 PM, Rob Clark <robdclark@gmail.com> wrote:
>> On Tue, Oct 3, 2017 at 8:25 AM, Srinivas Kandagatla
>> <srinivas.kandagatla@linaro.org> wrote:
>>>
>>>
>>> On 03/10/17 10:11, Linus Walleij wrote:
>>>>
>>>> Naming the DragonBoard 410c "SBC" (I guess "single board computer")
>>>> is not very helpful for users looking for their device tree in
>>>> the kernel. Also the db820c is named properly.
>>>>
>>>> Rectify this, simply, do not change the compatible strings but name
>>>> the DTS files in a consistent manner.
>>>>
>>>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>>>
>>> I did not like the sbc naming convention too, This was primarily done due to
>>> some legacy build tools + bootloaders which have used sbc compatible to
>>> identify boards from multiple dtb blobs. Now that we can append dtb to
>>> kernel with new LK, this should not be a issue anymore.
>>
>> maybe it would be an idea to update skales/dbttool first to look for
>> the new name, and then give people some time to upgrade, before
>> changing this in the kernel.  Otherwise I expect you'll cause some
>> confusion..
>
> iirc, skale is using the compatible name, not the filename.
>

ahh, yes, I think you are right.. u-boot is using a different filename.

So in this case, no issue to pick a saner name :-)

BR,
-R

  reply	other threads:[~2017-10-03 18:54 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-03  9:11 [PATCH 1/2] arm64: qcom: sbc: Name GPIO lines Linus Walleij
2017-10-03  9:11 ` Linus Walleij
2017-10-03  9:11 ` [PATCH 2/2] arm64: dts: qcom: Rename SBC to DragonBoard 410c Linus Walleij
2017-10-03  9:11   ` Linus Walleij
2017-10-03 12:25   ` Srinivas Kandagatla
2017-10-03 12:25     ` Srinivas Kandagatla
2017-10-03 16:37     ` Rob Clark
2017-10-03 16:37       ` Rob Clark
2017-10-03 17:49       ` Nicolas Dechesne
2017-10-03 17:49         ` Nicolas Dechesne
2017-10-03 18:54         ` Rob Clark [this message]
2017-10-03 18:54           ` Rob Clark
2017-10-04 21:23           ` Rob Clark
2017-10-04 21:23             ` Rob Clark
2017-10-04 22:09             ` Stephen Boyd
2017-10-04 22:09               ` Stephen Boyd
2017-10-04 22:12               ` Rob Clark
2017-10-04 22:12                 ` Rob Clark
2017-10-04 23:21                 ` Stephen Boyd
2017-10-04 23:21                   ` Stephen Boyd
2017-10-04 23:49                   ` Rob Clark
2017-10-04 23:49                     ` Rob Clark
2017-10-05 12:54             ` Riku Voipio
2017-10-05 12:54               ` Riku Voipio
2017-10-05 13:06               ` Alexander Graf
2017-10-05 13:06                 ` Alexander Graf
2017-10-06  4:41                 ` Andy Gross
2017-10-06  4:41                   ` Andy Gross
2017-10-03 20:58   ` Bjorn Andersson
2017-10-03 20:58     ` Bjorn Andersson
2017-10-04 21:45 ` [PATCH 1/2] arm64: qcom: sbc: Name GPIO lines Stephen Boyd
2017-10-04 21:45   ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAF6AEGvRB_SGQ_Xv33FiPZRyp+Wf29aG_Ex6rVk2Czov-Gjj9Q@mail.gmail.com \
    --to=robdclark@gmail.com \
    --cc=andy.gross@linaro.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=david.brown@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-soc@vger.kernel.org \
    --cc=nicolas.dechesne@linaro.org \
    --cc=sboyd@codeaurora.org \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.