From: Sumit Garg <sumit.garg@linaro.org> To: Doug Anderson <dianders@chromium.org> Cc: Daniel Thompson <daniel.thompson@linaro.org>, Will Deacon <will@kernel.org>, Wei Li <liwei391@huawei.com>, Catalin Marinas <catalin.marinas@arm.com>, Mark Rutland <mark.rutland@arm.com>, Masami Hiramatsu <mhiramat@kernel.org>, Jason Wessel <jason.wessel@windriver.com>, Marc Zyngier <maz@kernel.org>, Linux ARM <linux-arm-kernel@lists.infradead.org>, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v3 0/2] arm64: Fix pending single-step debugging issues Date: Thu, 4 Aug 2022 14:48:41 +0530 [thread overview] Message-ID: <CAFA6WYNnb2szmP7_V-W=LrBS1sD+zwV8VrieSp-sQM7B1E4wqA@mail.gmail.com> (raw) In-Reply-To: <CAFA6WYP_C7fOkgNw8n0OAaT92fr4UdBnCqAn_du6BT_sQB2KzQ@mail.gmail.com> On Mon, 11 Jul 2022 at 19:21, Sumit Garg <sumit.garg@linaro.org> wrote: > > On Mon, 11 Jul 2022 at 19:17, Doug Anderson <dianders@chromium.org> wrote: > > > > Hi, > > > > On Mon, Jul 11, 2022 at 5:44 AM Sumit Garg <sumit.garg@linaro.org> wrote: > > > > > > > I'll also note that I _think_ I remember that with Wei's series that > > > > the gdb function "call" started working. I tried that here and it > > > > didn't seem so happy. To keep things simple, I created a dummy > > > > function in my kernel that looked like: > > > > > > > > void doug_test(void) > > > > { > > > > pr_info("testing, 1 2 3\n"); > > > > } > > > > > > > > I broke into the debugger by echoing "g" to /proc/sysrq-trigger and > > > > then tried "call doug_test()". I guess my printout actually printed > > > > but it wasn't so happy after that. Seems like it somehow ended up > > > > returning to a bogus address after the call which then caused a crash. > > > > > > > > > > I am able to reproduce this issue on my setup as well. But it doesn't > > > seem to be a regression caused by this patch-set over Wei's series. As > > > I could reproduce this issue with v1 [1] patch-set as well which was > > > just a forward port of pending patches from Wei's series to the latest > > > upstream. > > > > > > Maybe it's a different regression caused by other changes? BTW, do you > > > remember the kernel version you tested with Wei's series applied? > > > > Sorry, I don't remember! :( I can't even be 100% sure that I'm > > remembering correctly that I tested it back in the day, so it's > > possible that it simply never worked... > > Okay, no worries. Let me see if I can come up with a separate fix for this. > After digging deep into GDB call function operations for aarch64, it is certain that function calls simply never worked due to below reasons: 1. On aarch64, GDB call function inserts a breakpoint at the entrypoint of kernel (which is ffffffc008000000 from your dump) as return address from function called. And since it refers to the "_text" symbol which is marked non-executable as the actual text section starts with the "_stext" symbol. I did a following hack that makes it executable: diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c index 626ec32873c6..e39ad1a5f5d6 100644 --- a/arch/arm64/mm/mmu.c +++ b/arch/arm64/mm/mmu.c @@ -700,7 +700,7 @@ static bool arm64_early_this_cpu_has_bti(void) static void __init map_kernel(pgd_t *pgdp) { static struct vm_struct vmlinux_text, vmlinux_rodata, vmlinux_inittext, - vmlinux_initdata, vmlinux_data; + vmlinux_initdata, vmlinux_data, vmlinux_htext; /* * External debuggers may need to write directly to the text @@ -721,6 +721,8 @@ static void __init map_kernel(pgd_t *pgdp) * Only rodata will be remapped with different permissions later on, * all other segments are allowed to use contiguous mappings. */ + map_kernel_segment(pgdp, _text, _stext, text_prot, &vmlinux_htext, 0, + VM_NO_GUARD); map_kernel_segment(pgdp, _stext, _etext, text_prot, &vmlinux_text, 0, VM_NO_GUARD); map_kernel_segment(pgdp, __start_rodata, __inittext_begin, PAGE_KERNEL, 2. For the GDB function "call" to work, GDB inserts a dummy stack frame. But in case of kernel on aarch64, the stack used is common among the exception handler and the kernel threads. So it's not trivial to insert a dummy stack frame and requires rework of exception entry code as it pushes pt_regs onto the stack. -Sumit > > > > > -Doug
WARNING: multiple messages have this Message-ID (diff)
From: Sumit Garg <sumit.garg@linaro.org> To: Doug Anderson <dianders@chromium.org> Cc: Daniel Thompson <daniel.thompson@linaro.org>, Will Deacon <will@kernel.org>, Wei Li <liwei391@huawei.com>, Catalin Marinas <catalin.marinas@arm.com>, Mark Rutland <mark.rutland@arm.com>, Masami Hiramatsu <mhiramat@kernel.org>, Jason Wessel <jason.wessel@windriver.com>, Marc Zyngier <maz@kernel.org>, Linux ARM <linux-arm-kernel@lists.infradead.org>, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v3 0/2] arm64: Fix pending single-step debugging issues Date: Thu, 4 Aug 2022 14:48:41 +0530 [thread overview] Message-ID: <CAFA6WYNnb2szmP7_V-W=LrBS1sD+zwV8VrieSp-sQM7B1E4wqA@mail.gmail.com> (raw) In-Reply-To: <CAFA6WYP_C7fOkgNw8n0OAaT92fr4UdBnCqAn_du6BT_sQB2KzQ@mail.gmail.com> On Mon, 11 Jul 2022 at 19:21, Sumit Garg <sumit.garg@linaro.org> wrote: > > On Mon, 11 Jul 2022 at 19:17, Doug Anderson <dianders@chromium.org> wrote: > > > > Hi, > > > > On Mon, Jul 11, 2022 at 5:44 AM Sumit Garg <sumit.garg@linaro.org> wrote: > > > > > > > I'll also note that I _think_ I remember that with Wei's series that > > > > the gdb function "call" started working. I tried that here and it > > > > didn't seem so happy. To keep things simple, I created a dummy > > > > function in my kernel that looked like: > > > > > > > > void doug_test(void) > > > > { > > > > pr_info("testing, 1 2 3\n"); > > > > } > > > > > > > > I broke into the debugger by echoing "g" to /proc/sysrq-trigger and > > > > then tried "call doug_test()". I guess my printout actually printed > > > > but it wasn't so happy after that. Seems like it somehow ended up > > > > returning to a bogus address after the call which then caused a crash. > > > > > > > > > > I am able to reproduce this issue on my setup as well. But it doesn't > > > seem to be a regression caused by this patch-set over Wei's series. As > > > I could reproduce this issue with v1 [1] patch-set as well which was > > > just a forward port of pending patches from Wei's series to the latest > > > upstream. > > > > > > Maybe it's a different regression caused by other changes? BTW, do you > > > remember the kernel version you tested with Wei's series applied? > > > > Sorry, I don't remember! :( I can't even be 100% sure that I'm > > remembering correctly that I tested it back in the day, so it's > > possible that it simply never worked... > > Okay, no worries. Let me see if I can come up with a separate fix for this. > After digging deep into GDB call function operations for aarch64, it is certain that function calls simply never worked due to below reasons: 1. On aarch64, GDB call function inserts a breakpoint at the entrypoint of kernel (which is ffffffc008000000 from your dump) as return address from function called. And since it refers to the "_text" symbol which is marked non-executable as the actual text section starts with the "_stext" symbol. I did a following hack that makes it executable: diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c index 626ec32873c6..e39ad1a5f5d6 100644 --- a/arch/arm64/mm/mmu.c +++ b/arch/arm64/mm/mmu.c @@ -700,7 +700,7 @@ static bool arm64_early_this_cpu_has_bti(void) static void __init map_kernel(pgd_t *pgdp) { static struct vm_struct vmlinux_text, vmlinux_rodata, vmlinux_inittext, - vmlinux_initdata, vmlinux_data; + vmlinux_initdata, vmlinux_data, vmlinux_htext; /* * External debuggers may need to write directly to the text @@ -721,6 +721,8 @@ static void __init map_kernel(pgd_t *pgdp) * Only rodata will be remapped with different permissions later on, * all other segments are allowed to use contiguous mappings. */ + map_kernel_segment(pgdp, _text, _stext, text_prot, &vmlinux_htext, 0, + VM_NO_GUARD); map_kernel_segment(pgdp, _stext, _etext, text_prot, &vmlinux_text, 0, VM_NO_GUARD); map_kernel_segment(pgdp, __start_rodata, __inittext_begin, PAGE_KERNEL, 2. For the GDB function "call" to work, GDB inserts a dummy stack frame. But in case of kernel on aarch64, the stack used is common among the exception handler and the kernel threads. So it's not trivial to insert a dummy stack frame and requires rework of exception entry code as it pushes pt_regs onto the stack. -Sumit > > > > > -Doug _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-08-04 9:18 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-11 6:05 [PATCH v3 0/2] arm64: Fix pending single-step debugging issues Sumit Garg 2022-05-11 6:05 ` Sumit Garg 2022-05-11 6:05 ` [PATCH v3 1/2] arm64: entry: Skip single stepping into interrupt handlers Sumit Garg 2022-05-11 6:05 ` Sumit Garg 2022-05-11 6:05 ` [PATCH v3 2/2] arm64: kgdb: Set PSTATE.SS to 1 to re-enable single-step Sumit Garg 2022-05-11 6:05 ` Sumit Garg 2022-07-01 22:14 ` [PATCH v3 0/2] arm64: Fix pending single-step debugging issues Doug Anderson 2022-07-01 22:14 ` Doug Anderson 2022-07-08 16:31 ` Will Deacon 2022-07-08 16:31 ` Will Deacon 2022-07-08 16:44 ` Doug Anderson 2022-07-08 16:44 ` Doug Anderson 2022-07-11 12:48 ` Sumit Garg 2022-07-11 12:48 ` Sumit Garg 2022-07-11 12:43 ` Sumit Garg 2022-07-11 12:43 ` Sumit Garg 2022-07-11 13:47 ` Doug Anderson 2022-07-11 13:47 ` Doug Anderson 2022-07-11 13:51 ` Sumit Garg 2022-07-11 13:51 ` Sumit Garg 2022-08-04 9:18 ` Sumit Garg [this message] 2022-08-04 9:18 ` Sumit Garg
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAFA6WYNnb2szmP7_V-W=LrBS1sD+zwV8VrieSp-sQM7B1E4wqA@mail.gmail.com' \ --to=sumit.garg@linaro.org \ --cc=catalin.marinas@arm.com \ --cc=daniel.thompson@linaro.org \ --cc=dianders@chromium.org \ --cc=jason.wessel@windriver.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=liwei391@huawei.com \ --cc=mark.rutland@arm.com \ --cc=maz@kernel.org \ --cc=mhiramat@kernel.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.