From: Sumit Garg <sumit.garg@linaro.org> To: Will Deacon <will@kernel.org> Cc: Doug Anderson <dianders@chromium.org>, Daniel Thompson <daniel.thompson@linaro.org>, Wei Li <liwei391@huawei.com>, Catalin Marinas <catalin.marinas@arm.com>, Mark Rutland <mark.rutland@arm.com>, Masami Hiramatsu <mhiramat@kernel.org>, Jason Wessel <jason.wessel@windriver.com>, Marc Zyngier <maz@kernel.org>, Linux ARM <linux-arm-kernel@lists.infradead.org>, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v3 0/2] arm64: Fix pending single-step debugging issues Date: Mon, 11 Jul 2022 18:18:29 +0530 [thread overview] Message-ID: <CAFA6WYNu=rJ=Vbs7TFFXzOh57ezum5FqFomCV8fLvAB02dxLug@mail.gmail.com> (raw) In-Reply-To: <20220708163134.GB6286@willie-the-truck> Hi Will, On Fri, 8 Jul 2022 at 22:01, Will Deacon <will@kernel.org> wrote: > > On Fri, Jul 01, 2022 at 03:14:16PM -0700, Doug Anderson wrote: > > Hi, > > > > On Tue, May 10, 2022 at 11:05 PM Sumit Garg <sumit.garg@linaro.org> wrote: > > > > > > This patch-set reworks pending fixes from Wei's series [1] to make > > > single-step debugging via kgdb/kdb on arm64 work as expected. There was > > > a prior discussion on ML [2] regarding if we should keep the interrupts > > > enabled during single-stepping. So patch #1 follows suggestion from Will > > > [3] to not disable interrupts during single stepping but rather skip > > > single stepping within interrupt handler. > > > > > > [1] https://lore.kernel.org/all/20200509214159.19680-1-liwei391@huawei.com/ > > > [2] https://lore.kernel.org/all/CAD=FV=Voyfq3Qz0T3RY+aYWYJ0utdH=P_AweB=13rcV8GDBeyQ@mail.gmail.com/ > > > [3] https://lore.kernel.org/all/20200626095551.GA9312@willie-the-truck/ > > > > > > Changes in v3: > > > - Reword commit descriptions as per Daniel's suggestions. > > > > > > Changes in v2: > > > - Replace patch #1 to rather follow Will's suggestion. > > > > > > Sumit Garg (2): > > > arm64: entry: Skip single stepping into interrupt handlers > > > arm64: kgdb: Set PSTATE.SS to 1 to re-enable single-step > > > > > > arch/arm64/include/asm/debug-monitors.h | 1 + > > > arch/arm64/kernel/debug-monitors.c | 5 +++++ > > > arch/arm64/kernel/entry-common.c | 18 +++++++++++++++++- > > > arch/arm64/kernel/kgdb.c | 2 ++ > > > 4 files changed, 25 insertions(+), 1 deletion(-) > > > > Sorry it took so long for me to respond. I kept dreaming that I'd find > > the time to really dig deep into this to understand it fully and I'm > > finally giving up on it. I'm going to hope that Will and/or Catalin > > knows this area of the code well and can give it a good review. If not > > then I'll strive harder to make the time... > > So the good news is that I spent a couple of days on this last week. > Thanks for spending time to review this. > The bad news is that I'm nowhere done and about to disappear on holiday > for a week! > > But anyway, I might be able to give this a review when I'm back. Failing > that, I wonder if enough of us have a little bit of time each that we > could hack on an agreed design together which covers the debug exception > behaviour beyond kgdb? Sure I will be happy to contribute to improving overall debug exception behaviour. I look forward to any further comments/suggestions. -Sumit > > Will
WARNING: multiple messages have this Message-ID (diff)
From: Sumit Garg <sumit.garg@linaro.org> To: Will Deacon <will@kernel.org> Cc: Doug Anderson <dianders@chromium.org>, Daniel Thompson <daniel.thompson@linaro.org>, Wei Li <liwei391@huawei.com>, Catalin Marinas <catalin.marinas@arm.com>, Mark Rutland <mark.rutland@arm.com>, Masami Hiramatsu <mhiramat@kernel.org>, Jason Wessel <jason.wessel@windriver.com>, Marc Zyngier <maz@kernel.org>, Linux ARM <linux-arm-kernel@lists.infradead.org>, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v3 0/2] arm64: Fix pending single-step debugging issues Date: Mon, 11 Jul 2022 18:18:29 +0530 [thread overview] Message-ID: <CAFA6WYNu=rJ=Vbs7TFFXzOh57ezum5FqFomCV8fLvAB02dxLug@mail.gmail.com> (raw) In-Reply-To: <20220708163134.GB6286@willie-the-truck> Hi Will, On Fri, 8 Jul 2022 at 22:01, Will Deacon <will@kernel.org> wrote: > > On Fri, Jul 01, 2022 at 03:14:16PM -0700, Doug Anderson wrote: > > Hi, > > > > On Tue, May 10, 2022 at 11:05 PM Sumit Garg <sumit.garg@linaro.org> wrote: > > > > > > This patch-set reworks pending fixes from Wei's series [1] to make > > > single-step debugging via kgdb/kdb on arm64 work as expected. There was > > > a prior discussion on ML [2] regarding if we should keep the interrupts > > > enabled during single-stepping. So patch #1 follows suggestion from Will > > > [3] to not disable interrupts during single stepping but rather skip > > > single stepping within interrupt handler. > > > > > > [1] https://lore.kernel.org/all/20200509214159.19680-1-liwei391@huawei.com/ > > > [2] https://lore.kernel.org/all/CAD=FV=Voyfq3Qz0T3RY+aYWYJ0utdH=P_AweB=13rcV8GDBeyQ@mail.gmail.com/ > > > [3] https://lore.kernel.org/all/20200626095551.GA9312@willie-the-truck/ > > > > > > Changes in v3: > > > - Reword commit descriptions as per Daniel's suggestions. > > > > > > Changes in v2: > > > - Replace patch #1 to rather follow Will's suggestion. > > > > > > Sumit Garg (2): > > > arm64: entry: Skip single stepping into interrupt handlers > > > arm64: kgdb: Set PSTATE.SS to 1 to re-enable single-step > > > > > > arch/arm64/include/asm/debug-monitors.h | 1 + > > > arch/arm64/kernel/debug-monitors.c | 5 +++++ > > > arch/arm64/kernel/entry-common.c | 18 +++++++++++++++++- > > > arch/arm64/kernel/kgdb.c | 2 ++ > > > 4 files changed, 25 insertions(+), 1 deletion(-) > > > > Sorry it took so long for me to respond. I kept dreaming that I'd find > > the time to really dig deep into this to understand it fully and I'm > > finally giving up on it. I'm going to hope that Will and/or Catalin > > knows this area of the code well and can give it a good review. If not > > then I'll strive harder to make the time... > > So the good news is that I spent a couple of days on this last week. > Thanks for spending time to review this. > The bad news is that I'm nowhere done and about to disappear on holiday > for a week! > > But anyway, I might be able to give this a review when I'm back. Failing > that, I wonder if enough of us have a little bit of time each that we > could hack on an agreed design together which covers the debug exception > behaviour beyond kgdb? Sure I will be happy to contribute to improving overall debug exception behaviour. I look forward to any further comments/suggestions. -Sumit > > Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-11 12:48 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-11 6:05 [PATCH v3 0/2] arm64: Fix pending single-step debugging issues Sumit Garg 2022-05-11 6:05 ` Sumit Garg 2022-05-11 6:05 ` [PATCH v3 1/2] arm64: entry: Skip single stepping into interrupt handlers Sumit Garg 2022-05-11 6:05 ` Sumit Garg 2022-05-11 6:05 ` [PATCH v3 2/2] arm64: kgdb: Set PSTATE.SS to 1 to re-enable single-step Sumit Garg 2022-05-11 6:05 ` Sumit Garg 2022-07-01 22:14 ` [PATCH v3 0/2] arm64: Fix pending single-step debugging issues Doug Anderson 2022-07-01 22:14 ` Doug Anderson 2022-07-08 16:31 ` Will Deacon 2022-07-08 16:31 ` Will Deacon 2022-07-08 16:44 ` Doug Anderson 2022-07-08 16:44 ` Doug Anderson 2022-07-11 12:48 ` Sumit Garg [this message] 2022-07-11 12:48 ` Sumit Garg 2022-07-11 12:43 ` Sumit Garg 2022-07-11 12:43 ` Sumit Garg 2022-07-11 13:47 ` Doug Anderson 2022-07-11 13:47 ` Doug Anderson 2022-07-11 13:51 ` Sumit Garg 2022-07-11 13:51 ` Sumit Garg 2022-08-04 9:18 ` Sumit Garg 2022-08-04 9:18 ` Sumit Garg
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAFA6WYNu=rJ=Vbs7TFFXzOh57ezum5FqFomCV8fLvAB02dxLug@mail.gmail.com' \ --to=sumit.garg@linaro.org \ --cc=catalin.marinas@arm.com \ --cc=daniel.thompson@linaro.org \ --cc=dianders@chromium.org \ --cc=jason.wessel@windriver.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=liwei391@huawei.com \ --cc=mark.rutland@arm.com \ --cc=maz@kernel.org \ --cc=mhiramat@kernel.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.