From: Sumit Garg <sumit.garg@linaro.org> To: Jens Wiklander <jens.wiklander@linaro.org> Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, OP-TEE TrustedFirmware <op-tee@lists.trustedfirmware.org>, Devicetree List <devicetree@vger.kernel.org>, Linux Doc Mailing List <linux-doc@vger.kernel.org>, Jerome Forissier <jerome@forissier.org>, Etienne Carriere <etienne.carriere@linaro.org>, Vincent Guittot <vincent.guittot@linaro.org>, Rob Herring <robh+dt@kernel.org>, Jonathan Corbet <corbet@lwn.net>, Ard Biesheuvel <ardb@kernel.org>, Marc Zyngier <maz@kernel.org> Subject: Re: [PATCH v6 4/6] tee: export teedev_open() and teedev_close_context() Date: Wed, 13 Oct 2021 12:39:51 +0530 [thread overview] Message-ID: <CAFA6WYOZ4Ux4XvMa_tZgR+mZbuNb0ypABvyUeMKc1ngAYR8zVA@mail.gmail.com> (raw) In-Reply-To: <20211006071546.2540920-5-jens.wiklander@linaro.org> On Wed, 6 Oct 2021 at 12:46, Jens Wiklander <jens.wiklander@linaro.org> wrote: > > Exports the two functions teedev_open() and teedev_close_context() in > order to make it easier to create a driver internal struct tee_context. > > Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org> > --- > drivers/tee/tee_core.c | 6 ++++-- > include/linux/tee_drv.h | 14 ++++++++++++++ > 2 files changed, 18 insertions(+), 2 deletions(-) > Reviewed-by: Sumit Garg <sumit.garg@linaro.org> -Sumit > diff --git a/drivers/tee/tee_core.c b/drivers/tee/tee_core.c > index 85102d12d716..3fc426dad2df 100644 > --- a/drivers/tee/tee_core.c > +++ b/drivers/tee/tee_core.c > @@ -43,7 +43,7 @@ static DEFINE_SPINLOCK(driver_lock); > static struct class *tee_class; > static dev_t tee_devt; > > -static struct tee_context *teedev_open(struct tee_device *teedev) > +struct tee_context *teedev_open(struct tee_device *teedev) > { > int rc; > struct tee_context *ctx; > @@ -70,6 +70,7 @@ static struct tee_context *teedev_open(struct tee_device *teedev) > return ERR_PTR(rc); > > } > +EXPORT_SYMBOL_GPL(teedev_open); > > void teedev_ctx_get(struct tee_context *ctx) > { > @@ -96,13 +97,14 @@ void teedev_ctx_put(struct tee_context *ctx) > kref_put(&ctx->refcount, teedev_ctx_release); > } > > -static void teedev_close_context(struct tee_context *ctx) > +void teedev_close_context(struct tee_context *ctx) > { > struct tee_device *teedev = ctx->teedev; > > teedev_ctx_put(ctx); > tee_device_put(teedev); > } > +EXPORT_SYMBOL_GPL(teedev_close_context); > > static int tee_open(struct inode *inode, struct file *filp) > { > diff --git a/include/linux/tee_drv.h b/include/linux/tee_drv.h > index 3ebfea0781f1..26f42c4cd7a1 100644 > --- a/include/linux/tee_drv.h > +++ b/include/linux/tee_drv.h > @@ -582,4 +582,18 @@ struct tee_client_driver { > #define to_tee_client_driver(d) \ > container_of(d, struct tee_client_driver, driver) > > +/** > + * teedev_open() - Open a struct tee_device > + * @teedev: Device to open > + * > + * @return a pointer to struct tee_context on success or an ERR_PTR on failure. > + */ > +struct tee_context *teedev_open(struct tee_device *teedev); > + > +/** > + * teedev_close_context() - closes a struct tee_context > + * @ctx: The struct tee_context to close > + */ > +void teedev_close_context(struct tee_context *ctx); > + > #endif /*__TEE_DRV_H*/ > -- > 2.31.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Sumit Garg <sumit.garg@linaro.org> To: Jens Wiklander <jens.wiklander@linaro.org> Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, OP-TEE TrustedFirmware <op-tee@lists.trustedfirmware.org>, Devicetree List <devicetree@vger.kernel.org>, Linux Doc Mailing List <linux-doc@vger.kernel.org>, Jerome Forissier <jerome@forissier.org>, Etienne Carriere <etienne.carriere@linaro.org>, Vincent Guittot <vincent.guittot@linaro.org>, Rob Herring <robh+dt@kernel.org>, Jonathan Corbet <corbet@lwn.net>, Ard Biesheuvel <ardb@kernel.org>, Marc Zyngier <maz@kernel.org> Subject: Re: [PATCH v6 4/6] tee: export teedev_open() and teedev_close_context() Date: Wed, 13 Oct 2021 12:39:51 +0530 [thread overview] Message-ID: <CAFA6WYOZ4Ux4XvMa_tZgR+mZbuNb0ypABvyUeMKc1ngAYR8zVA@mail.gmail.com> (raw) In-Reply-To: <20211006071546.2540920-5-jens.wiklander@linaro.org> On Wed, 6 Oct 2021 at 12:46, Jens Wiklander <jens.wiklander@linaro.org> wrote: > > Exports the two functions teedev_open() and teedev_close_context() in > order to make it easier to create a driver internal struct tee_context. > > Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org> > --- > drivers/tee/tee_core.c | 6 ++++-- > include/linux/tee_drv.h | 14 ++++++++++++++ > 2 files changed, 18 insertions(+), 2 deletions(-) > Reviewed-by: Sumit Garg <sumit.garg@linaro.org> -Sumit > diff --git a/drivers/tee/tee_core.c b/drivers/tee/tee_core.c > index 85102d12d716..3fc426dad2df 100644 > --- a/drivers/tee/tee_core.c > +++ b/drivers/tee/tee_core.c > @@ -43,7 +43,7 @@ static DEFINE_SPINLOCK(driver_lock); > static struct class *tee_class; > static dev_t tee_devt; > > -static struct tee_context *teedev_open(struct tee_device *teedev) > +struct tee_context *teedev_open(struct tee_device *teedev) > { > int rc; > struct tee_context *ctx; > @@ -70,6 +70,7 @@ static struct tee_context *teedev_open(struct tee_device *teedev) > return ERR_PTR(rc); > > } > +EXPORT_SYMBOL_GPL(teedev_open); > > void teedev_ctx_get(struct tee_context *ctx) > { > @@ -96,13 +97,14 @@ void teedev_ctx_put(struct tee_context *ctx) > kref_put(&ctx->refcount, teedev_ctx_release); > } > > -static void teedev_close_context(struct tee_context *ctx) > +void teedev_close_context(struct tee_context *ctx) > { > struct tee_device *teedev = ctx->teedev; > > teedev_ctx_put(ctx); > tee_device_put(teedev); > } > +EXPORT_SYMBOL_GPL(teedev_close_context); > > static int tee_open(struct inode *inode, struct file *filp) > { > diff --git a/include/linux/tee_drv.h b/include/linux/tee_drv.h > index 3ebfea0781f1..26f42c4cd7a1 100644 > --- a/include/linux/tee_drv.h > +++ b/include/linux/tee_drv.h > @@ -582,4 +582,18 @@ struct tee_client_driver { > #define to_tee_client_driver(d) \ > container_of(d, struct tee_client_driver, driver) > > +/** > + * teedev_open() - Open a struct tee_device > + * @teedev: Device to open > + * > + * @return a pointer to struct tee_context on success or an ERR_PTR on failure. > + */ > +struct tee_context *teedev_open(struct tee_device *teedev); > + > +/** > + * teedev_close_context() - closes a struct tee_context > + * @ctx: The struct tee_context to close > + */ > +void teedev_close_context(struct tee_context *ctx); > + > #endif /*__TEE_DRV_H*/ > -- > 2.31.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-13 7:10 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-06 7:15 [PATCH v6 0/6] Asynchronous notifications from secure world Jens Wiklander 2021-10-06 7:15 ` Jens Wiklander 2021-10-06 7:15 ` [PATCH v6 1/6] docs: staging/tee.rst: add a section on OP-TEE notifications Jens Wiklander 2021-10-06 7:15 ` Jens Wiklander 2021-10-13 7:02 ` Sumit Garg 2021-10-13 7:02 ` Sumit Garg 2021-10-06 7:15 ` [PATCH v6 2/6] dt-bindings: arm: optee: add interrupt property Jens Wiklander 2021-10-06 7:15 ` Jens Wiklander 2021-10-13 7:08 ` Sumit Garg 2021-10-13 7:08 ` Sumit Garg 2021-10-06 7:15 ` [PATCH v6 3/6] tee: fix put order in teedev_close_context() Jens Wiklander 2021-10-06 7:15 ` Jens Wiklander 2021-10-13 7:09 ` Sumit Garg 2021-10-13 7:09 ` Sumit Garg 2021-10-06 7:15 ` [PATCH v6 4/6] tee: export teedev_open() and teedev_close_context() Jens Wiklander 2021-10-06 7:15 ` Jens Wiklander 2021-10-13 7:09 ` Sumit Garg [this message] 2021-10-13 7:09 ` Sumit Garg 2021-10-06 7:15 ` [PATCH v6 5/6] optee: separate notification functions Jens Wiklander 2021-10-06 7:15 ` Jens Wiklander 2021-10-13 7:15 ` Sumit Garg 2021-10-13 7:15 ` Sumit Garg 2021-10-13 13:42 ` Jens Wiklander 2021-10-13 13:42 ` Jens Wiklander 2021-10-06 7:15 ` [PATCH v6 6/6] optee: add asynchronous notifications Jens Wiklander 2021-10-06 7:15 ` Jens Wiklander 2021-10-13 8:07 ` Sumit Garg 2021-10-13 8:07 ` Sumit Garg 2021-10-14 5:42 ` Jens Wiklander 2021-10-14 5:42 ` Jens Wiklander
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAFA6WYOZ4Ux4XvMa_tZgR+mZbuNb0ypABvyUeMKc1ngAYR8zVA@mail.gmail.com \ --to=sumit.garg@linaro.org \ --cc=ardb@kernel.org \ --cc=corbet@lwn.net \ --cc=devicetree@vger.kernel.org \ --cc=etienne.carriere@linaro.org \ --cc=jens.wiklander@linaro.org \ --cc=jerome@forissier.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=maz@kernel.org \ --cc=op-tee@lists.trustedfirmware.org \ --cc=robh+dt@kernel.org \ --cc=vincent.guittot@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.