From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH v1 3/3] iio: adc: meson_saradc: Use temporary variable for struct device
Date: Tue, 31 May 2022 23:47:50 +0200 [thread overview]
Message-ID: <CAFBinCDf4UfEPFV4_Qf3m16DE-NzNUk_ZVcHZhgxVvn_pokdgw@mail.gmail.com> (raw)
In-Reply-To: <20220531211842.71998-3-andriy.shevchenko@linux.intel.com>
Hi Andy,
On Tue, May 31, 2022 at 11:18 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
[...]
> @@ -650,11 +648,12 @@ static int meson_sar_adc_clk_init(struct iio_dev *indio_dev,
> void __iomem *base)
> {
> struct meson_sar_adc_priv *priv = iio_priv(indio_dev);
> + struct device *idev = &indio_dev->dev;
> + struct device *dev = dev->parent;
It looks like this should read:
struct device *dev = idev->parent;
That said, I think this kind of typo is very easy with the current
naming schema.
It's been a while since I looked at other drivers but maybe the IIO
maintainers have some recommendations for us (which would apply to
multiple IIO drivers, not just meson_saradc).
For example: I am not sure if iio_{err,warn} functions (which take a
struct iio_dev pointer) have been proposed/discussed before. I think
they could be useful for other drivers as well.
Best regards,
Martin
WARNING: multiple messages have this Message-ID (diff)
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH v1 3/3] iio: adc: meson_saradc: Use temporary variable for struct device
Date: Tue, 31 May 2022 23:47:50 +0200 [thread overview]
Message-ID: <CAFBinCDf4UfEPFV4_Qf3m16DE-NzNUk_ZVcHZhgxVvn_pokdgw@mail.gmail.com> (raw)
In-Reply-To: <20220531211842.71998-3-andriy.shevchenko@linux.intel.com>
Hi Andy,
On Tue, May 31, 2022 at 11:18 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
[...]
> @@ -650,11 +648,12 @@ static int meson_sar_adc_clk_init(struct iio_dev *indio_dev,
> void __iomem *base)
> {
> struct meson_sar_adc_priv *priv = iio_priv(indio_dev);
> + struct device *idev = &indio_dev->dev;
> + struct device *dev = dev->parent;
It looks like this should read:
struct device *dev = idev->parent;
That said, I think this kind of typo is very easy with the current
naming schema.
It's been a while since I looked at other drivers but maybe the IIO
maintainers have some recommendations for us (which would apply to
multiple IIO drivers, not just meson_saradc).
For example: I am not sure if iio_{err,warn} functions (which take a
struct iio_dev pointer) have been proposed/discussed before. I think
they could be useful for other drivers as well.
Best regards,
Martin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH v1 3/3] iio: adc: meson_saradc: Use temporary variable for struct device
Date: Tue, 31 May 2022 23:47:50 +0200 [thread overview]
Message-ID: <CAFBinCDf4UfEPFV4_Qf3m16DE-NzNUk_ZVcHZhgxVvn_pokdgw@mail.gmail.com> (raw)
In-Reply-To: <20220531211842.71998-3-andriy.shevchenko@linux.intel.com>
Hi Andy,
On Tue, May 31, 2022 at 11:18 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
[...]
> @@ -650,11 +648,12 @@ static int meson_sar_adc_clk_init(struct iio_dev *indio_dev,
> void __iomem *base)
> {
> struct meson_sar_adc_priv *priv = iio_priv(indio_dev);
> + struct device *idev = &indio_dev->dev;
> + struct device *dev = dev->parent;
It looks like this should read:
struct device *dev = idev->parent;
That said, I think this kind of typo is very easy with the current
naming schema.
It's been a while since I looked at other drivers but maybe the IIO
maintainers have some recommendations for us (which would apply to
multiple IIO drivers, not just meson_saradc).
For example: I am not sure if iio_{err,warn} functions (which take a
struct iio_dev pointer) have been proposed/discussed before. I think
they could be useful for other drivers as well.
Best regards,
Martin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-31 21:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 21:18 [PATCH v1 1/3] iio: adc: meson_saradc: Convert to use dev_err_probe() Andy Shevchenko
2022-05-31 21:18 ` Andy Shevchenko
2022-05-31 21:18 ` Andy Shevchenko
2022-05-31 21:18 ` [PATCH v1 2/3] iio: adc: meson_saradc: Use devm_clk_get_optional() Andy Shevchenko
2022-05-31 21:18 ` Andy Shevchenko
2022-05-31 21:18 ` Andy Shevchenko
2022-05-31 21:29 ` Martin Blumenstingl
2022-05-31 21:29 ` Martin Blumenstingl
2022-05-31 21:29 ` Martin Blumenstingl
2022-05-31 21:18 ` [PATCH v1 3/3] iio: adc: meson_saradc: Use temporary variable for struct device Andy Shevchenko
2022-05-31 21:18 ` Andy Shevchenko
2022-05-31 21:18 ` Andy Shevchenko
2022-05-31 21:47 ` Martin Blumenstingl [this message]
2022-05-31 21:47 ` Martin Blumenstingl
2022-05-31 21:47 ` Martin Blumenstingl
2022-06-01 10:30 ` Andy Shevchenko
2022-06-01 10:30 ` Andy Shevchenko
2022-06-01 10:30 ` Andy Shevchenko
2022-06-01 0:44 ` kernel test robot
2022-06-01 0:44 ` kernel test robot
2022-06-01 0:44 ` kernel test robot
2022-05-31 21:53 ` [PATCH v1 1/3] iio: adc: meson_saradc: Convert to use dev_err_probe() Martin Blumenstingl
2022-05-31 21:53 ` Martin Blumenstingl
2022-05-31 21:53 ` Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFBinCDf4UfEPFV4_Qf3m16DE-NzNUk_ZVcHZhgxVvn_pokdgw@mail.gmail.com \
--to=martin.blumenstingl@googlemail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jbrunet@baylibre.com \
--cc=jic23@kernel.org \
--cc=khilman@baylibre.com \
--cc=lars@metafoo.de \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.