From: Oded Gabbay <oded.gabbay@gmail.com>
To: "Luis R. Rodriguez" <mcgrof@kernel.org>
Cc: Joerg Roedel <joro@8bytes.org>,
iommu@lists.linux-foundation.org,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFT] iommu/amd: use subsys_initcall() on amdv2 iommu
Date: Wed, 16 Mar 2016 09:02:43 +0200 [thread overview]
Message-ID: <CAFCwf13RT9VyzhJ4AhAGd1ndd8f=Cd0TRnnRcDwBGHbOzyc5BQ@mail.gmail.com> (raw)
In-Reply-To: <1458079926-18716-1-git-send-email-mcgrof@kernel.org>
On Wed, Mar 16, 2016 at 12:12 AM, Luis R. Rodriguez <mcgrof@kernel.org> wrote:
> We need to ensure amd iommu v2 initializes before
> driver uses such as drivers/gpu/drm/amd/amdkfd/kfd_module.c,
> to do this make its init routine a subsys_initcall() which
> ensures its load init is called first than modules when
> built-in.
>
> Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
> ---
>
> Can someone test if this patch enables both CONFIG_AMD_IOMMU_V2 and
> CONFIG_HSA_AMD to be =y (built-in) without any conflicts ?
>
> drivers/iommu/amd_iommu_v2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/amd_iommu_v2.c b/drivers/iommu/amd_iommu_v2.c
> index 56999d2fac07..60df645b9927 100644
> --- a/drivers/iommu/amd_iommu_v2.c
> +++ b/drivers/iommu/amd_iommu_v2.c
> @@ -1004,5 +1004,5 @@ static void __exit amd_iommu_v2_exit(void)
> destroy_workqueue(iommu_wq);
> }
>
> -module_init(amd_iommu_v2_init);
> +subsys_initcall(amd_iommu_v2_init);
> module_exit(amd_iommu_v2_exit);
> --
> 2.7.2
>
fwiw, we currently have this covered by the ugly hack of putting iommu
subsystem in front of gpu subsystem in the main drivers makefile (See
1bacc894c227fad8a727eb99728df708eba57654)
Oded
WARNING: multiple messages have this Message-ID (diff)
From: Oded Gabbay <oded.gabbay-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Luis R. Rodriguez" <mcgrof-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
"Linux-Kernel@Vger. Kernel. Org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [RFT] iommu/amd: use subsys_initcall() on amdv2 iommu
Date: Wed, 16 Mar 2016 09:02:43 +0200 [thread overview]
Message-ID: <CAFCwf13RT9VyzhJ4AhAGd1ndd8f=Cd0TRnnRcDwBGHbOzyc5BQ@mail.gmail.com> (raw)
In-Reply-To: <1458079926-18716-1-git-send-email-mcgrof-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
On Wed, Mar 16, 2016 at 12:12 AM, Luis R. Rodriguez <mcgrof-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> We need to ensure amd iommu v2 initializes before
> driver uses such as drivers/gpu/drm/amd/amdkfd/kfd_module.c,
> to do this make its init routine a subsys_initcall() which
> ensures its load init is called first than modules when
> built-in.
>
> Signed-off-by: Luis R. Rodriguez <mcgrof-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> ---
>
> Can someone test if this patch enables both CONFIG_AMD_IOMMU_V2 and
> CONFIG_HSA_AMD to be =y (built-in) without any conflicts ?
>
> drivers/iommu/amd_iommu_v2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/amd_iommu_v2.c b/drivers/iommu/amd_iommu_v2.c
> index 56999d2fac07..60df645b9927 100644
> --- a/drivers/iommu/amd_iommu_v2.c
> +++ b/drivers/iommu/amd_iommu_v2.c
> @@ -1004,5 +1004,5 @@ static void __exit amd_iommu_v2_exit(void)
> destroy_workqueue(iommu_wq);
> }
>
> -module_init(amd_iommu_v2_init);
> +subsys_initcall(amd_iommu_v2_init);
> module_exit(amd_iommu_v2_exit);
> --
> 2.7.2
>
fwiw, we currently have this covered by the ugly hack of putting iommu
subsystem in front of gpu subsystem in the main drivers makefile (See
1bacc894c227fad8a727eb99728df708eba57654)
Oded
next prev parent reply other threads:[~2016-03-16 7:03 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 22:12 [RFT] iommu/amd: use subsys_initcall() on amdv2 iommu Luis R. Rodriguez
2016-03-16 7:02 ` Oded Gabbay [this message]
2016-03-16 7:02 ` Oded Gabbay
2016-03-16 10:14 ` Joerg Roedel
2016-03-16 10:14 ` Joerg Roedel
2016-03-16 10:16 ` Oded Gabbay
2016-03-16 16:17 ` Luis R. Rodriguez
2016-03-16 16:39 ` Joerg Roedel
2016-03-16 16:57 ` Luis R. Rodriguez
2016-03-16 17:17 ` Joerg Roedel
2016-03-16 17:17 ` Joerg Roedel
2016-03-29 17:41 ` [RFT v2] " Luis R. Rodriguez
2016-03-29 17:41 ` Luis R. Rodriguez
2016-04-09 0:25 ` Luis R. Rodriguez
2016-04-09 0:25 ` Luis R. Rodriguez
2016-04-11 13:28 ` Christian König
2016-04-11 13:28 ` Christian König
2016-04-11 13:39 ` Oded Gabbay
2016-04-11 13:39 ` Oded Gabbay
2016-04-11 13:52 ` Christian König
2016-04-11 13:52 ` Christian König
2016-04-12 22:07 ` Luis R. Rodriguez
2016-04-12 22:07 ` Luis R. Rodriguez
2016-04-18 6:48 ` Oded Gabbay
2016-04-18 6:48 ` Oded Gabbay
[not found] ` <CAFCwf12SJ-dTv6PC0_KfHbtC9951xb_4v8wu5uSjXO-V3TgdkA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-04-18 6:55 ` Luis R. Rodriguez
2016-04-18 7:02 ` Oded Gabbay
2016-04-18 7:02 ` Oded Gabbay
2016-04-18 12:03 ` Luis R. Rodriguez
2016-04-18 12:03 ` Luis R. Rodriguez
2016-04-19 2:02 ` Wan Zongshun
2016-04-19 2:02 ` Wan Zongshun
2016-05-27 0:12 ` Luis R. Rodriguez
2016-05-27 0:12 ` Luis R. Rodriguez
2016-04-25 10:23 ` Joerg Roedel
2016-04-25 10:23 ` Joerg Roedel
2016-05-27 0:46 ` Luis R. Rodriguez
2016-05-27 1:18 ` [RFT v3] drm: use late_initcall() for amdkfd and radeon Luis R. Rodriguez
2016-05-29 14:49 ` Oded Gabbay
2016-05-29 14:49 ` Oded Gabbay
2016-05-31 17:15 ` Luis R. Rodriguez
2016-05-31 17:15 ` Luis R. Rodriguez
2016-05-31 17:33 ` Oded Gabbay
2016-05-31 17:33 ` Oded Gabbay
2016-05-29 18:27 ` Daniel Vetter
2016-05-29 18:27 ` Daniel Vetter
2016-05-31 16:58 ` Luis R. Rodriguez
2016-05-31 19:04 ` Daniel Vetter
2016-05-31 19:04 ` Daniel Vetter
2016-06-01 21:11 ` Luis R. Rodriguez
2016-11-10 22:12 ` Luis R. Rodriguez
2016-11-10 22:12 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFCwf13RT9VyzhJ4AhAGd1ndd8f=Cd0TRnnRcDwBGHbOzyc5BQ@mail.gmail.com' \
--to=oded.gabbay@gmail.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.