From: "Christian König" <christian.koenig@amd.com>
To: "Luis R. Rodriguez" <mcgrof@kernel.org>,
Joerg Roedel <joro@8bytes.org>, <oded.gabbay@gmail.com>
Cc: <iommu@lists.linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFT v2] iommu/amd: use subsys_initcall() on amdv2 iommu
Date: Mon, 11 Apr 2016 15:28:52 +0200 [thread overview]
Message-ID: <570BA694.8040900@amd.com> (raw)
In-Reply-To: <CAB=NE6XCmMk4sraQo34XQJfjWu_yRc1rar_eQRSET8Q7VR9EOw@mail.gmail.com>
Am 09.04.2016 um 02:25 schrieb Luis R. Rodriguez:
> On Tue, Mar 29, 2016 at 10:41 AM, Luis R. Rodriguez <mcgrof@kernel.org> wrote:
>> We need to ensure amd iommu v2 initializes before
>> driver uses such as drivers/gpu/drm/amd/amdkfd/kfd_module.c,
>> to do this make its init routine a subsys_initcall() which
>> ensures its load init is called first than modules when
>> built-in.
>>
>> This reverts the old work around implemented through commit
>> 1bacc894c227fad8a7 ("drivers: Move iommu/ before gpu/ in Makefile"),
>> instead of making the dependency implicit by linker order this
>> makes the ordering requirement explicit through proper kernel
>> APIs.
>>
>> Cc: Oded Gabbay <oded.gabbay@amd.com>
>> Cc: Christian König <christian.koenig@amd.com>
>> Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
Sorry for not responding earlier. Just coming back to all the stuff on
my TODO list.
Patch is Acked-by: Christian König <christian.koenig@amd.com>
Regards,
Christian.
> *poke*
>
> Luis
WARNING: multiple messages have this Message-ID (diff)
From: "Christian König" <christian.koenig-5C7GfCeVMHo@public.gmane.org>
To: "Luis R. Rodriguez"
<mcgrof-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>,
oded.gabbay-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [RFT v2] iommu/amd: use subsys_initcall() on amdv2 iommu
Date: Mon, 11 Apr 2016 15:28:52 +0200 [thread overview]
Message-ID: <570BA694.8040900@amd.com> (raw)
In-Reply-To: <CAB=NE6XCmMk4sraQo34XQJfjWu_yRc1rar_eQRSET8Q7VR9EOw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Am 09.04.2016 um 02:25 schrieb Luis R. Rodriguez:
> On Tue, Mar 29, 2016 at 10:41 AM, Luis R. Rodriguez <mcgrof@kernel.org> wrote:
>> We need to ensure amd iommu v2 initializes before
>> driver uses such as drivers/gpu/drm/amd/amdkfd/kfd_module.c,
>> to do this make its init routine a subsys_initcall() which
>> ensures its load init is called first than modules when
>> built-in.
>>
>> This reverts the old work around implemented through commit
>> 1bacc894c227fad8a7 ("drivers: Move iommu/ before gpu/ in Makefile"),
>> instead of making the dependency implicit by linker order this
>> makes the ordering requirement explicit through proper kernel
>> APIs.
>>
>> Cc: Oded Gabbay <oded.gabbay@amd.com>
>> Cc: Christian König <christian.koenig@amd.com>
>> Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
Sorry for not responding earlier. Just coming back to all the stuff on
my TODO list.
Patch is Acked-by: Christian König <christian.koenig@amd.com>
Regards,
Christian.
> *poke*
>
> Luis
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2016-04-11 13:44 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 22:12 [RFT] iommu/amd: use subsys_initcall() on amdv2 iommu Luis R. Rodriguez
2016-03-16 7:02 ` Oded Gabbay
2016-03-16 7:02 ` Oded Gabbay
2016-03-16 10:14 ` Joerg Roedel
2016-03-16 10:14 ` Joerg Roedel
2016-03-16 10:16 ` Oded Gabbay
2016-03-16 16:17 ` Luis R. Rodriguez
2016-03-16 16:39 ` Joerg Roedel
2016-03-16 16:57 ` Luis R. Rodriguez
2016-03-16 17:17 ` Joerg Roedel
2016-03-16 17:17 ` Joerg Roedel
2016-03-29 17:41 ` [RFT v2] " Luis R. Rodriguez
2016-03-29 17:41 ` Luis R. Rodriguez
2016-04-09 0:25 ` Luis R. Rodriguez
2016-04-09 0:25 ` Luis R. Rodriguez
2016-04-11 13:28 ` Christian König [this message]
2016-04-11 13:28 ` Christian König
2016-04-11 13:39 ` Oded Gabbay
2016-04-11 13:39 ` Oded Gabbay
2016-04-11 13:52 ` Christian König
2016-04-11 13:52 ` Christian König
2016-04-12 22:07 ` Luis R. Rodriguez
2016-04-12 22:07 ` Luis R. Rodriguez
2016-04-18 6:48 ` Oded Gabbay
2016-04-18 6:48 ` Oded Gabbay
[not found] ` <CAFCwf12SJ-dTv6PC0_KfHbtC9951xb_4v8wu5uSjXO-V3TgdkA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-04-18 6:55 ` Luis R. Rodriguez
2016-04-18 7:02 ` Oded Gabbay
2016-04-18 7:02 ` Oded Gabbay
2016-04-18 12:03 ` Luis R. Rodriguez
2016-04-18 12:03 ` Luis R. Rodriguez
2016-04-19 2:02 ` Wan Zongshun
2016-04-19 2:02 ` Wan Zongshun
2016-05-27 0:12 ` Luis R. Rodriguez
2016-05-27 0:12 ` Luis R. Rodriguez
2016-04-25 10:23 ` Joerg Roedel
2016-04-25 10:23 ` Joerg Roedel
2016-05-27 0:46 ` Luis R. Rodriguez
2016-05-27 1:18 ` [RFT v3] drm: use late_initcall() for amdkfd and radeon Luis R. Rodriguez
2016-05-29 14:49 ` Oded Gabbay
2016-05-29 14:49 ` Oded Gabbay
2016-05-31 17:15 ` Luis R. Rodriguez
2016-05-31 17:15 ` Luis R. Rodriguez
2016-05-31 17:33 ` Oded Gabbay
2016-05-31 17:33 ` Oded Gabbay
2016-05-29 18:27 ` Daniel Vetter
2016-05-29 18:27 ` Daniel Vetter
2016-05-31 16:58 ` Luis R. Rodriguez
2016-05-31 19:04 ` Daniel Vetter
2016-05-31 19:04 ` Daniel Vetter
2016-06-01 21:11 ` Luis R. Rodriguez
2016-11-10 22:12 ` Luis R. Rodriguez
2016-11-10 22:12 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570BA694.8040900@amd.com \
--to=christian.koenig@amd.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=oded.gabbay@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.