checkpatch.pl block comment detection fail

checkpatch.pl block comment detection fail

[Doug Evans]

[-- Attachment #1: Type: text/plain, Size: 312 bytes --]

Hi.

The coding style docs don't specify this as being bad:

foo(/*bar=*/true);

which improves readability at the call site.
It's not a style to be used liberally, but sometimes it's helpful.

Alas checkpatch.pl claims this is a block comment.

Would it be ok if I try to fix checkpatch.pl to treat this as ok?

[-- Attachment #2: Type: text/html, Size: 1174 bytes --]

Re: checkpatch.pl block comment detection fail

[Peter Maydell]

On Fri, 11 Dec 2020 at 22:54, Doug Evans <dje@google.com> wrote:
>
> Hi.
>
> The coding style docs don't specify this as being bad:
>
> foo(/*bar=*/true);
>
> which improves readability at the call site.
> It's not a style to be used liberally, but sometimes it's helpful.
>
> Alas checkpatch.pl claims this is a block comment.
>
> Would it be ok if I try to fix checkpatch.pl to treat this as ok?

Well, whether it's good or bad style it's certainly not a block
comment, so it's a bug for checkpatch to call it one. If you want
to dive into that morass of perl feel free :-)

thanks
-- PMM