From: Peter Maydell <peter.maydell@linaro.org>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: patches@linaro.org, qemu-devel@nongnu.org, kvm@vger.kernel.org,
kvmarm@lists.cs.columbia.edu
Subject: Re: [RFC v2 2/6] ARM: KVM: Add support for KVM on ARM architecture
Date: Thu, 18 Oct 2012 18:53:26 +0100 [thread overview]
Message-ID: <CAFEAcA-EX6wvsATYvfB0wYcG_-Smnm4ewDSZLuTQfBLC9_JOSw@mail.gmail.com> (raw)
In-Reply-To: <50803F3F.1010609@siemens.com>
On 18 October 2012 18:41, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> Minor: If you do
>
> function()
> {
> #ifdef CONFIG_KVM
> ...
> #endif
> }
>
>> +
>> qemu_irq *arm_pic_init_cpu(ARMCPU *cpu)
>> {
>> +#ifdef CONFIG_KVM
>> + if (kvm_enabled()) {
>> + return qemu_allocate_irqs(kvm_arm_pic_cpu_handler, cpu, 2);
>> + }
>> +#endif
>
> ...you can avoid the ifdef'ery here.
Good idea -- will do that in next version.
-- PMM
WARNING: multiple messages have this Message-ID (diff)
From: Peter Maydell <peter.maydell@linaro.org>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: patches@linaro.org, qemu-devel@nongnu.org, kvm@vger.kernel.org,
kvmarm@lists.cs.columbia.edu
Subject: Re: [Qemu-devel] [RFC v2 2/6] ARM: KVM: Add support for KVM on ARM architecture
Date: Thu, 18 Oct 2012 18:53:26 +0100 [thread overview]
Message-ID: <CAFEAcA-EX6wvsATYvfB0wYcG_-Smnm4ewDSZLuTQfBLC9_JOSw@mail.gmail.com> (raw)
In-Reply-To: <50803F3F.1010609@siemens.com>
On 18 October 2012 18:41, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> Minor: If you do
>
> function()
> {
> #ifdef CONFIG_KVM
> ...
> #endif
> }
>
>> +
>> qemu_irq *arm_pic_init_cpu(ARMCPU *cpu)
>> {
>> +#ifdef CONFIG_KVM
>> + if (kvm_enabled()) {
>> + return qemu_allocate_irqs(kvm_arm_pic_cpu_handler, cpu, 2);
>> + }
>> +#endif
>
> ...you can avoid the ifdef'ery here.
Good idea -- will do that in next version.
-- PMM
next prev parent reply other threads:[~2012-10-18 17:53 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-10 15:07 [RFC v2 0/6] QEMU: Support KVM on ARM Peter Maydell
2012-10-10 15:07 ` [Qemu-devel] " Peter Maydell
2012-10-10 15:07 ` [RFC v2 1/6] linux-headers: Add ARM KVM headers (not for upstream) Peter Maydell
2012-10-10 15:07 ` [Qemu-devel] " Peter Maydell
2012-10-10 15:07 ` [RFC v2 2/6] ARM: KVM: Add support for KVM on ARM architecture Peter Maydell
2012-10-10 15:07 ` [Qemu-devel] " Peter Maydell
2012-10-13 9:09 ` Blue Swirl
2012-10-13 9:09 ` Blue Swirl
2012-10-13 19:19 ` Peter Maydell
2012-10-13 19:19 ` Peter Maydell
2012-10-18 12:37 ` Peter Maydell
2012-10-18 12:37 ` Peter Maydell
2012-10-18 17:41 ` Jan Kiszka
2012-10-18 17:41 ` [Qemu-devel] " Jan Kiszka
2012-10-18 17:53 ` Peter Maydell [this message]
2012-10-18 17:53 ` Peter Maydell
2012-10-10 15:07 ` [RFC v2 3/6] hw/arm_gic: Add presave/postload hooks Peter Maydell
2012-10-10 15:07 ` [Qemu-devel] " Peter Maydell
2012-10-10 17:29 ` Andreas Färber
2012-10-10 17:29 ` Andreas Färber
2012-10-10 15:07 ` [RFC v2 4/6] hw/kvm/arm_gic: Implement support for KVM in-kernel ARM GIC Peter Maydell
2012-10-10 15:07 ` [Qemu-devel] " Peter Maydell
2012-10-10 17:23 ` Andreas Färber
2012-10-10 17:23 ` Andreas Färber
2012-10-10 17:35 ` Peter Maydell
2012-10-10 17:35 ` Peter Maydell
2012-10-10 15:07 ` [RFC v2 5/6] ARM KVM: save and load VFP registers from kernel Peter Maydell
2012-10-10 15:07 ` [Qemu-devel] " Peter Maydell
2012-10-10 15:07 ` [RFC v2 6/6] configure: Enable KVM on ARM Peter Maydell
2012-10-10 15:07 ` [Qemu-devel] " Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-EX6wvsATYvfB0wYcG_-Smnm4ewDSZLuTQfBLC9_JOSw@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=patches@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.