All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org, kvmarm@lists.cs.columbia.edu,
	kvm@vger.kernel.org, patches@linaro.org
Subject: Re: [Qemu-devel] [RFC v2 2/6] ARM: KVM: Add support for KVM on ARM architecture
Date: Thu, 18 Oct 2012 13:37:14 +0100	[thread overview]
Message-ID: <CAFEAcA-MpFiHP=3bGXGQMZiv0dFm1yxpC_Caa5LmmJcgxckSbA@mail.gmail.com> (raw)
In-Reply-To: <CAAu8pHvDf-oy-nk+CWJ7KpgKP1cw4vBNXGKsCUCwrsLe4LaaKQ@mail.gmail.com>

On 13 October 2012 10:09, Blue Swirl <blauwirbel@gmail.com> wrote:
> On Wed, Oct 10, 2012 at 3:07 PM, Peter Maydell <peter.maydell@linaro.org> wrote:
>> +#include "hw/arm-misc.h"
>> +
>> +const KVMCapabilityInfo kvm_arch_required_capabilities[] = {
>
> 'static'. In fact, 'static' not used at all in this file, probably it
> could be used a lot more.

Actually this one can't be static -- it's defined here but used in
kvm-all.c. The same applies for most of the functions in this file.
I was able to add a 'static' to the regs[] array, but I couldn't
find anywhere else here where a 'static' was missing.

-- PMM

WARNING: multiple messages have this Message-ID (diff)
From: Peter Maydell <peter.maydell@linaro.org>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: patches@linaro.org, qemu-devel@nongnu.org, kvm@vger.kernel.org,
	kvmarm@lists.cs.columbia.edu
Subject: Re: [Qemu-devel] [RFC v2 2/6] ARM: KVM: Add support for KVM on ARM architecture
Date: Thu, 18 Oct 2012 13:37:14 +0100	[thread overview]
Message-ID: <CAFEAcA-MpFiHP=3bGXGQMZiv0dFm1yxpC_Caa5LmmJcgxckSbA@mail.gmail.com> (raw)
In-Reply-To: <CAAu8pHvDf-oy-nk+CWJ7KpgKP1cw4vBNXGKsCUCwrsLe4LaaKQ@mail.gmail.com>

On 13 October 2012 10:09, Blue Swirl <blauwirbel@gmail.com> wrote:
> On Wed, Oct 10, 2012 at 3:07 PM, Peter Maydell <peter.maydell@linaro.org> wrote:
>> +#include "hw/arm-misc.h"
>> +
>> +const KVMCapabilityInfo kvm_arch_required_capabilities[] = {
>
> 'static'. In fact, 'static' not used at all in this file, probably it
> could be used a lot more.

Actually this one can't be static -- it's defined here but used in
kvm-all.c. The same applies for most of the functions in this file.
I was able to add a 'static' to the regs[] array, but I couldn't
find anywhere else here where a 'static' was missing.

-- PMM

  parent reply	other threads:[~2012-10-18 12:37 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-10 15:07 [RFC v2 0/6] QEMU: Support KVM on ARM Peter Maydell
2012-10-10 15:07 ` [Qemu-devel] " Peter Maydell
2012-10-10 15:07 ` [RFC v2 1/6] linux-headers: Add ARM KVM headers (not for upstream) Peter Maydell
2012-10-10 15:07   ` [Qemu-devel] " Peter Maydell
2012-10-10 15:07 ` [RFC v2 2/6] ARM: KVM: Add support for KVM on ARM architecture Peter Maydell
2012-10-10 15:07   ` [Qemu-devel] " Peter Maydell
2012-10-13  9:09   ` Blue Swirl
2012-10-13  9:09     ` Blue Swirl
2012-10-13 19:19     ` Peter Maydell
2012-10-13 19:19       ` Peter Maydell
2012-10-18 12:37     ` Peter Maydell [this message]
2012-10-18 12:37       ` Peter Maydell
2012-10-18 17:41   ` Jan Kiszka
2012-10-18 17:41     ` [Qemu-devel] " Jan Kiszka
2012-10-18 17:53     ` Peter Maydell
2012-10-18 17:53       ` [Qemu-devel] " Peter Maydell
2012-10-10 15:07 ` [RFC v2 3/6] hw/arm_gic: Add presave/postload hooks Peter Maydell
2012-10-10 15:07   ` [Qemu-devel] " Peter Maydell
2012-10-10 17:29   ` Andreas Färber
2012-10-10 17:29     ` Andreas Färber
2012-10-10 15:07 ` [RFC v2 4/6] hw/kvm/arm_gic: Implement support for KVM in-kernel ARM GIC Peter Maydell
2012-10-10 15:07   ` [Qemu-devel] " Peter Maydell
2012-10-10 17:23   ` Andreas Färber
2012-10-10 17:23     ` Andreas Färber
2012-10-10 17:35     ` Peter Maydell
2012-10-10 17:35       ` Peter Maydell
2012-10-10 15:07 ` [RFC v2 5/6] ARM KVM: save and load VFP registers from kernel Peter Maydell
2012-10-10 15:07   ` [Qemu-devel] " Peter Maydell
2012-10-10 15:07 ` [RFC v2 6/6] configure: Enable KVM on ARM Peter Maydell
2012-10-10 15:07   ` [Qemu-devel] " Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFEAcA-MpFiHP=3bGXGQMZiv0dFm1yxpC_Caa5LmmJcgxckSbA@mail.gmail.com' \
    --to=peter.maydell@linaro.org \
    --cc=blauwirbel@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=patches@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.