* [Qemu-devel] [Bug 1625987] [NEW] target-arm/translate-a64.c:2028: possible coding error ?
@ 2016-09-21 8:29 dcb
2016-09-22 9:53 ` [Qemu-devel] [Bug 1625987] " Peter Maydell
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: dcb @ 2016-09-21 8:29 UTC (permalink / raw)
To: qemu-devel
Public bug reported:
target-arm/translate-a64.c:2028:37: warning: ?: using integer constants
in boolean context [-Wint-in-bool-context]
Source code is
bool iss_sf = opc == 0 ? 32 : 64;
Maybe better code
bool iss_sf = (opc == 0) ? 32 : 64;
** Affects: qemu
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1625987
Title:
target-arm/translate-a64.c:2028: possible coding error ?
Status in QEMU:
New
Bug description:
target-arm/translate-a64.c:2028:37: warning: ?: using integer
constants in boolean context [-Wint-in-bool-context]
Source code is
bool iss_sf = opc == 0 ? 32 : 64;
Maybe better code
bool iss_sf = (opc == 0) ? 32 : 64;
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1625987/+subscriptions
^ permalink raw reply [flat|nested] 6+ messages in thread* [Qemu-devel] [Bug 1625987] Re: target-arm/translate-a64.c:2028: possible coding error ?
2016-09-21 8:29 [Qemu-devel] [Bug 1625987] [NEW] target-arm/translate-a64.c:2028: possible coding error ? dcb
@ 2016-09-22 9:53 ` Peter Maydell
2016-09-30 1:40 ` Peter Maydell
2016-10-04 13:36 ` Peter Maydell
2017-01-16 11:45 ` Thomas Huth
2 siblings, 1 reply; 6+ messages in thread
From: Peter Maydell @ 2016-09-22 9:53 UTC (permalink / raw)
To: qemu-devel
This is clearly a bug, but your suggested change won't deal with the
problem, which is that we're trying to set a bool so the ? 32 : 64
construct is just wrong.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1625987
Title:
target-arm/translate-a64.c:2028: possible coding error ?
Status in QEMU:
New
Bug description:
target-arm/translate-a64.c:2028:37: warning: ?: using integer
constants in boolean context [-Wint-in-bool-context]
Source code is
bool iss_sf = opc == 0 ? 32 : 64;
Maybe better code
bool iss_sf = (opc == 0) ? 32 : 64;
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1625987/+subscriptions
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [Bug 1625987] Re: target-arm/translate-a64.c:2028: possible coding error ?
2016-09-22 9:53 ` [Qemu-devel] [Bug 1625987] " Peter Maydell
@ 2016-09-30 1:40 ` Peter Maydell
2016-09-30 10:21 ` Edgar E. Iglesias
0 siblings, 1 reply; 6+ messages in thread
From: Peter Maydell @ 2016-09-30 1:40 UTC (permalink / raw)
To: Edgar E. Iglesias; +Cc: QEMU Developers, Bug 1625987
On 22 September 2016 at 02:53, Peter Maydell <peter.maydell@linaro.org> wrote:
> This is clearly a bug, but your suggested change won't deal with the
> problem, which is that we're trying to set a bool so the ? 32 : 64
> construct is just wrong.
> Bug description:
> target-arm/translate-a64.c:2028:37: warning: ?: using integer
> constants in boolean context [-Wint-in-bool-context]
>
> Source code is
>
> bool iss_sf = opc == 0 ? 32 : 64;
Edgar, did you want to look at a fix for this? It was introduced
in your commit aaa1f954d4 adding syndrome info for loads and stores.
thanks
-- PMM
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [Bug 1625987] Re: target-arm/translate-a64.c:2028: possible coding error ?
2016-09-30 1:40 ` Peter Maydell
@ 2016-09-30 10:21 ` Edgar E. Iglesias
0 siblings, 0 replies; 6+ messages in thread
From: Edgar E. Iglesias @ 2016-09-30 10:21 UTC (permalink / raw)
To: Peter Maydell; +Cc: QEMU Developers, Bug 1625987
On Thu, Sep 29, 2016 at 06:40:53PM -0700, Peter Maydell wrote:
> On 22 September 2016 at 02:53, Peter Maydell <peter.maydell@linaro.org> wrote:
> > This is clearly a bug, but your suggested change won't deal with the
> > problem, which is that we're trying to set a bool so the ? 32 : 64
> > construct is just wrong.
>
> > Bug description:
> > target-arm/translate-a64.c:2028:37: warning: ?: using integer
> > constants in boolean context [-Wint-in-bool-context]
> >
> > Source code is
> >
> > bool iss_sf = opc == 0 ? 32 : 64;
>
> Edgar, did you want to look at a fix for this? It was introduced
> in your commit aaa1f954d4 adding syndrome info for loads and stores.
Hi Peter,
Yes, I've just posted a fix to the list.
It should have been:
bool iss_sf = opc == 0 ? false : true;
Cheers,
Edgar
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Qemu-devel] [Bug 1625987] Re: target-arm/translate-a64.c:2028: possible coding error ?
2016-09-21 8:29 [Qemu-devel] [Bug 1625987] [NEW] target-arm/translate-a64.c:2028: possible coding error ? dcb
2016-09-22 9:53 ` [Qemu-devel] [Bug 1625987] " Peter Maydell
@ 2016-10-04 13:36 ` Peter Maydell
2017-01-16 11:45 ` Thomas Huth
2 siblings, 0 replies; 6+ messages in thread
From: Peter Maydell @ 2016-10-04 13:36 UTC (permalink / raw)
To: qemu-devel
Now fixed in master, commit 173ff58580b383a7841.
** Changed in: qemu
Status: New => Fix Committed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1625987
Title:
target-arm/translate-a64.c:2028: possible coding error ?
Status in QEMU:
Fix Committed
Bug description:
target-arm/translate-a64.c:2028:37: warning: ?: using integer
constants in boolean context [-Wint-in-bool-context]
Source code is
bool iss_sf = opc == 0 ? 32 : 64;
Maybe better code
bool iss_sf = (opc == 0) ? 32 : 64;
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1625987/+subscriptions
^ permalink raw reply [flat|nested] 6+ messages in thread* [Qemu-devel] [Bug 1625987] Re: target-arm/translate-a64.c:2028: possible coding error ?
2016-09-21 8:29 [Qemu-devel] [Bug 1625987] [NEW] target-arm/translate-a64.c:2028: possible coding error ? dcb
2016-09-22 9:53 ` [Qemu-devel] [Bug 1625987] " Peter Maydell
2016-10-04 13:36 ` Peter Maydell
@ 2017-01-16 11:45 ` Thomas Huth
2 siblings, 0 replies; 6+ messages in thread
From: Thomas Huth @ 2017-01-16 11:45 UTC (permalink / raw)
To: qemu-devel
Released with v2.8
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1625987
Title:
target-arm/translate-a64.c:2028: possible coding error ?
Status in QEMU:
Fix Released
Bug description:
target-arm/translate-a64.c:2028:37: warning: ?: using integer
constants in boolean context [-Wint-in-bool-context]
Source code is
bool iss_sf = opc == 0 ? 32 : 64;
Maybe better code
bool iss_sf = (opc == 0) ? 32 : 64;
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1625987/+subscriptions
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-01-16 11:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-21 8:29 [Qemu-devel] [Bug 1625987] [NEW] target-arm/translate-a64.c:2028: possible coding error ? dcb
2016-09-22 9:53 ` [Qemu-devel] [Bug 1625987] " Peter Maydell
2016-09-30 1:40 ` Peter Maydell
2016-09-30 10:21 ` Edgar E. Iglesias
2016-10-04 13:36 ` Peter Maydell
2017-01-16 11:45 ` Thomas Huth
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.