* [Qemu-devel] [PATCH] CODING_STYLE: Fix a typo ("Many a flamewar")
@ 2016-09-29 20:46 Jonathan Neuschäfer
2016-09-29 22:14 ` Peter Maydell
0 siblings, 1 reply; 6+ messages in thread
From: Jonathan Neuschäfer @ 2016-09-29 20:46 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Jonathan Neuschäfer
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---
CODING_STYLE | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/CODING_STYLE b/CODING_STYLE
index e7fde15..a03a994 100644
--- a/CODING_STYLE
+++ b/CODING_STYLE
@@ -9,7 +9,7 @@ patches before submitting.
Of course, the most important aspect in any coding style is whitespace.
Crusty old coders who have trouble spotting the glasses on their noses
can tell the difference between a tab and eight spaces from a distance
-of approximately fifteen parsecs. Many a flamewar have been fought and
+of approximately fifteen parsecs. Many flamewars have been fought and
lost on this issue.
QEMU indents are four spaces. Tabs are never used, except in Makefiles
--
2.9.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] CODING_STYLE: Fix a typo ("Many a flamewar")
2016-09-29 20:46 [Qemu-devel] [PATCH] CODING_STYLE: Fix a typo ("Many a flamewar") Jonathan Neuschäfer
@ 2016-09-29 22:14 ` Peter Maydell
2016-09-29 23:38 ` Jonathan Neuschäfer
0 siblings, 1 reply; 6+ messages in thread
From: Peter Maydell @ 2016-09-29 22:14 UTC (permalink / raw)
To: Jonathan Neuschäfer; +Cc: QEMU Developers, QEMU Trivial
On 29 September 2016 at 13:46, Jonathan Neuschäfer
<j.neuschaefer@gmx.net> wrote:
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> ---
> CODING_STYLE | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/CODING_STYLE b/CODING_STYLE
> index e7fde15..a03a994 100644
> --- a/CODING_STYLE
> +++ b/CODING_STYLE
> @@ -9,7 +9,7 @@ patches before submitting.
> Of course, the most important aspect in any coding style is whitespace.
> Crusty old coders who have trouble spotting the glasses on their noses
> can tell the difference between a tab and eight spaces from a distance
> -of approximately fifteen parsecs. Many a flamewar have been fought and
> +of approximately fifteen parsecs. Many flamewars have been fought and
> lost on this issue.
Should be "Many a flamewar has been fought and lost".
(This is slightly poetic phrasing but it has a nice ring to it;
the complement does have to be singular, not plural, though.)
thanks
-- PMM
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] CODING_STYLE: Fix a typo ("Many a flamewar")
2016-09-29 22:14 ` Peter Maydell
@ 2016-09-29 23:38 ` Jonathan Neuschäfer
2016-09-30 0:04 ` [Qemu-devel] [PATCH v2] CODING_STYLE: Fix a typo ("have" vs. "has") Jonathan Neuschäfer
0 siblings, 1 reply; 6+ messages in thread
From: Jonathan Neuschäfer @ 2016-09-29 23:38 UTC (permalink / raw)
To: Peter Maydell; +Cc: Jonathan Neuschäfer, QEMU Trivial, QEMU Developers
[-- Attachment #1: Type: text/plain, Size: 1201 bytes --]
On Thu, Sep 29, 2016 at 03:14:45PM -0700, Peter Maydell wrote:
> On 29 September 2016 at 13:46, Jonathan Neuschäfer
> <j.neuschaefer@gmx.net> wrote:
> > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> > ---
> > CODING_STYLE | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/CODING_STYLE b/CODING_STYLE
> > index e7fde15..a03a994 100644
> > --- a/CODING_STYLE
> > +++ b/CODING_STYLE
> > @@ -9,7 +9,7 @@ patches before submitting.
> > Of course, the most important aspect in any coding style is whitespace.
> > Crusty old coders who have trouble spotting the glasses on their noses
> > can tell the difference between a tab and eight spaces from a distance
> > -of approximately fifteen parsecs. Many a flamewar have been fought and
> > +of approximately fifteen parsecs. Many flamewars have been fought and
> > lost on this issue.
>
> Should be "Many a flamewar has been fought and lost".
> (This is slightly poetic phrasing but it has a nice ring to it;
> the complement does have to be singular, not plural, though.)
Thanks for pointing that out; I didn't know the phrase. I'll update my
patch.
Jonathan Neuschäfer
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* [Qemu-devel] [PATCH v2] CODING_STYLE: Fix a typo ("have" vs. "has")
2016-09-29 23:38 ` Jonathan Neuschäfer
@ 2016-09-30 0:04 ` Jonathan Neuschäfer
2016-09-30 0:29 ` Peter Maydell
2016-10-08 8:12 ` Michael Tokarev
0 siblings, 2 replies; 6+ messages in thread
From: Jonathan Neuschäfer @ 2016-09-30 0:04 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Peter Maydell, Jonathan Neuschäfer
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---
v2:
- Preserve the poetic sound of "Many a flamewar", which Peter Maydell
pointed out.
---
CODING_STYLE | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/CODING_STYLE b/CODING_STYLE
index e7fde15..f53180b 100644
--- a/CODING_STYLE
+++ b/CODING_STYLE
@@ -9,7 +9,7 @@ patches before submitting.
Of course, the most important aspect in any coding style is whitespace.
Crusty old coders who have trouble spotting the glasses on their noses
can tell the difference between a tab and eight spaces from a distance
-of approximately fifteen parsecs. Many a flamewar have been fought and
+of approximately fifteen parsecs. Many a flamewar has been fought and
lost on this issue.
QEMU indents are four spaces. Tabs are never used, except in Makefiles
--
2.9.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH v2] CODING_STYLE: Fix a typo ("have" vs. "has")
2016-09-30 0:04 ` [Qemu-devel] [PATCH v2] CODING_STYLE: Fix a typo ("have" vs. "has") Jonathan Neuschäfer
@ 2016-09-30 0:29 ` Peter Maydell
2016-10-08 8:12 ` Michael Tokarev
1 sibling, 0 replies; 6+ messages in thread
From: Peter Maydell @ 2016-09-30 0:29 UTC (permalink / raw)
To: Jonathan Neuschäfer; +Cc: QEMU Developers, QEMU Trivial
On 29 September 2016 at 17:04, Jonathan Neuschäfer
<j.neuschaefer@gmx.net> wrote:
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
>
> ---
> v2:
> - Preserve the poetic sound of "Many a flamewar", which Peter Maydell
> pointed out.
> ---
> CODING_STYLE | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/CODING_STYLE b/CODING_STYLE
> index e7fde15..f53180b 100644
> --- a/CODING_STYLE
> +++ b/CODING_STYLE
> @@ -9,7 +9,7 @@ patches before submitting.
> Of course, the most important aspect in any coding style is whitespace.
> Crusty old coders who have trouble spotting the glasses on their noses
> can tell the difference between a tab and eight spaces from a distance
> -of approximately fifteen parsecs. Many a flamewar have been fought and
> +of approximately fifteen parsecs. Many a flamewar has been fought and
> lost on this issue.
>
> QEMU indents are four spaces. Tabs are never used, except in Makefiles
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH v2] CODING_STYLE: Fix a typo ("have" vs. "has")
2016-09-30 0:04 ` [Qemu-devel] [PATCH v2] CODING_STYLE: Fix a typo ("have" vs. "has") Jonathan Neuschäfer
2016-09-30 0:29 ` Peter Maydell
@ 2016-10-08 8:12 ` Michael Tokarev
1 sibling, 0 replies; 6+ messages in thread
From: Michael Tokarev @ 2016-10-08 8:12 UTC (permalink / raw)
To: Jonathan Neuschäfer, qemu-devel; +Cc: qemu-trivial, Peter Maydell
Applied to -trivial, thanks!
/mjt
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-10-08 8:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-29 20:46 [Qemu-devel] [PATCH] CODING_STYLE: Fix a typo ("Many a flamewar") Jonathan Neuschäfer
2016-09-29 22:14 ` Peter Maydell
2016-09-29 23:38 ` Jonathan Neuschäfer
2016-09-30 0:04 ` [Qemu-devel] [PATCH v2] CODING_STYLE: Fix a typo ("have" vs. "has") Jonathan Neuschäfer
2016-09-30 0:29 ` Peter Maydell
2016-10-08 8:12 ` Michael Tokarev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.