* [Qemu-devel] [PATCH] linux-user: Assert stack used for auxvec, envp, argv
@ 2014-03-25 23:21 James Hogan
2014-05-01 18:08 ` Peter Maydell
0 siblings, 1 reply; 4+ messages in thread
From: James Hogan @ 2014-03-25 23:21 UTC (permalink / raw)
To: qemu-devel; +Cc: Peter Maydell, Riku Voipio, James Hogan
Assert that the amount of stack space used for auxvec, envp & argv
exactly matches the amount allocated. This catches if DLINFO_ITEMS isn't
updated when another NEW_AUX_ENT is added.
Signed-off-by: James Hogan <james.hogan@imgtec.com>
Cc: Riku Voipio <riku.voipio@iki.fi>
Cc: Peter Maydell <peter.maydell@linaro.org>
---
This should be applied after "linux-user: Correct DLINFO_ITEMS" or the
assert will fail.
Tested with linux-user-test-0.3 before and after fixing DLINFO_ITEMS.
---
linux-user/elfload.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index d2380b6..ecf6f35 100644
--- a/linux-user/elfload.c
+++ b/linux-user/elfload.c
@@ -1455,6 +1455,8 @@ static abi_ulong create_elf_tables(abi_ulong p, int argc, int envc,
info->auxv_len = sp_auxv - sp;
sp = loader_build_argptr(envc, argc, sp, p, 0);
+ /* Check the right amount of stack was allocated for auxvec, envp & argv. */
+ assert(sp_auxv - sp == size);
return sp;
}
--
1.8.3.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] linux-user: Assert stack used for auxvec, envp, argv
2014-03-25 23:21 [Qemu-devel] [PATCH] linux-user: Assert stack used for auxvec, envp, argv James Hogan
@ 2014-05-01 18:08 ` Peter Maydell
2014-05-02 10:03 ` Riku Voipio
0 siblings, 1 reply; 4+ messages in thread
From: Peter Maydell @ 2014-05-01 18:08 UTC (permalink / raw)
To: James Hogan; +Cc: Riku Voipio, QEMU Developers
Ping!
Riku -- do you have this in your tree now?
(I'm adding an aux entry for AT_HWCAP2 and I noticed the
assert wasn't firing :-))
thanks
-- PMM
On 25 March 2014 23:21, James Hogan <james.hogan@imgtec.com> wrote:
> Assert that the amount of stack space used for auxvec, envp & argv
> exactly matches the amount allocated. This catches if DLINFO_ITEMS isn't
> updated when another NEW_AUX_ENT is added.
>
> Signed-off-by: James Hogan <james.hogan@imgtec.com>
> Cc: Riku Voipio <riku.voipio@iki.fi>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> ---
> This should be applied after "linux-user: Correct DLINFO_ITEMS" or the
> assert will fail.
>
> Tested with linux-user-test-0.3 before and after fixing DLINFO_ITEMS.
> ---
> linux-user/elfload.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/linux-user/elfload.c b/linux-user/elfload.c
> index d2380b6..ecf6f35 100644
> --- a/linux-user/elfload.c
> +++ b/linux-user/elfload.c
> @@ -1455,6 +1455,8 @@ static abi_ulong create_elf_tables(abi_ulong p, int argc, int envc,
> info->auxv_len = sp_auxv - sp;
>
> sp = loader_build_argptr(envc, argc, sp, p, 0);
> + /* Check the right amount of stack was allocated for auxvec, envp & argv. */
> + assert(sp_auxv - sp == size);
> return sp;
> }
>
> --
> 1.8.3.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] linux-user: Assert stack used for auxvec, envp, argv
2014-05-01 18:08 ` Peter Maydell
@ 2014-05-02 10:03 ` Riku Voipio
2014-05-02 10:07 ` Peter Maydell
0 siblings, 1 reply; 4+ messages in thread
From: Riku Voipio @ 2014-05-02 10:03 UTC (permalink / raw)
To: Peter Maydell; +Cc: Riku Voipio, James Hogan, QEMU Developers
Hi,
I've rolled up a new patchset to:
https://git.linaro.org/people/riku.voipio/qemu.git/shortlog/refs/heads/linux-user-for-upstream
Should I submit this or wait for your AT_HWCAP2 patch?
Riku
On Thu, May 01, 2014 at 07:08:29PM +0100, Peter Maydell wrote:
> Ping!
>
> Riku -- do you have this in your tree now?
>
> (I'm adding an aux entry for AT_HWCAP2 and I noticed the
> assert wasn't firing :-))
>
> thanks
> -- PMM
>
> On 25 March 2014 23:21, James Hogan <james.hogan@imgtec.com> wrote:
> > Assert that the amount of stack space used for auxvec, envp & argv
> > exactly matches the amount allocated. This catches if DLINFO_ITEMS isn't
> > updated when another NEW_AUX_ENT is added.
> >
> > Signed-off-by: James Hogan <james.hogan@imgtec.com>
> > Cc: Riku Voipio <riku.voipio@iki.fi>
> > Cc: Peter Maydell <peter.maydell@linaro.org>
> > ---
> > This should be applied after "linux-user: Correct DLINFO_ITEMS" or the
> > assert will fail.
> >
> > Tested with linux-user-test-0.3 before and after fixing DLINFO_ITEMS.
> > ---
> > linux-user/elfload.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/linux-user/elfload.c b/linux-user/elfload.c
> > index d2380b6..ecf6f35 100644
> > --- a/linux-user/elfload.c
> > +++ b/linux-user/elfload.c
> > @@ -1455,6 +1455,8 @@ static abi_ulong create_elf_tables(abi_ulong p, int argc, int envc,
> > info->auxv_len = sp_auxv - sp;
> >
> > sp = loader_build_argptr(envc, argc, sp, p, 0);
> > + /* Check the right amount of stack was allocated for auxvec, envp & argv. */
> > + assert(sp_auxv - sp == size);
> > return sp;
> > }
> >
> > --
> > 1.8.3.2
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] linux-user: Assert stack used for auxvec, envp, argv
2014-05-02 10:03 ` Riku Voipio
@ 2014-05-02 10:07 ` Peter Maydell
0 siblings, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2014-05-02 10:07 UTC (permalink / raw)
To: Riku Voipio; +Cc: James Hogan, QEMU Developers
On 2 May 2014 11:03, Riku Voipio <riku.voipio@iki.fi> wrote:
> Hi,
>
> I've rolled up a new patchset to:
>
> https://git.linaro.org/people/riku.voipio/qemu.git/shortlog/refs/heads/linux-user-for-upstream
>
> Should I submit this or wait for your AT_HWCAP2 patch?
I have the AT_HWCAP2 patch (and some other related fixes)
ready to send, I just need to do some testing. I'll try
to get that done and send the patches out in a couple of
hours.
thanks
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-05-02 10:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-03-25 23:21 [Qemu-devel] [PATCH] linux-user: Assert stack used for auxvec, envp, argv James Hogan
2014-05-01 18:08 ` Peter Maydell
2014-05-02 10:03 ` Riku Voipio
2014-05-02 10:07 ` Peter Maydell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.