Re: [PATCH 32/32] Remove qemu-common.h include from most units

From: Peter Maydell <peter.maydell@linaro.org>
To: Markus Armbruster <armbru@redhat.com>
Cc: "John G Johnson" <john.g.johnson@oracle.com>,
	"Alexey Kardashevskiy" <aik@ozlabs.ru>,
	"Li Zhijian" <lizhijian@fujitsu.com>,
	"KONRAD Frederic" <frederic.konrad@adacore.com>,
	"open list:raw" <qemu-block@nongnu.org>,
	"Stefan Berger" <stefanb@linux.vnet.ibm.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Huacai Chen" <chenhuacai@kernel.org>,
	"Halil Pasic" <pasic@linux.ibm.com>,
	"Kamil Rytarowski" <kamil@netbsd.org>,
	"Hervé Poussineau" <hpoussin@reactos.org>,
	"Christian Borntraeger" <borntraeger@linux.ibm.com>,
	"Michael Roth" <michael.roth@amd.com>,
	"Alexander Bulekov" <alxndr@bu.edu>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"John Snow" <jsnow@redhat.com>,
	"Aarushi Mehta" <mehta.aaru20@gmail.com>,
	"Kevin Wolf" <kwolf@redhat.com>,
	"Andrew Jeffery" <andrew@aj.id.au>,
	"Chris Wulff" <crwulff@gmail.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Subbaraya Sundeep" <sundeep.lkml@gmail.com>,
	"Zhang Chen" <chen.zhang@intel.com>,
	"open list:sPAPR (pseries)" <qemu-ppc@nongnu.org>,
	"Igor Mammedov" <imammedo@redhat.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>, "Fam Zheng" <fam@euphon.net>,
	"David Hildenbrand" <david@redhat.com>,
	"Yanan Wang" <wangyanan55@huawei.com>,
	"Max Filippov" <jcmvbkbc@gmail.com>,
	"Alistair Francis" <alistair.francis@wdc.com>,
	"Yoshinori Sato" <ysato@users.sourceforge.jp>,
	"Helge Deller" <deller@gmx.de>,
	"Qiuhao Li" <Qiuhao.Li@outlook.com>,
	"Artyom Tarasenko" <atar4qemu@gmail.com>,
	"Stefano Garzarella" <sgarzare@redhat.com>,
	"Eric Farman" <farman@linux.ibm.com>,
	"Corey Minyard" <minyard@acm.org>, "Stefan Weil" <sw@weilnetz.de>,
	"Julia Suvorova" <jusual@redhat.com>,
	"Greg Kurz" <groug@kaod.org>,
	"Cameron Esfahani" <dirty@apple.com>,
	"Bandan Das" <bsd@redhat.com>, "Alexander Graf" <agraf@csgraf.de>,
	"Michael Rolnik" <mrolnik@gmail.com>,
	"Cédric Le Goater" <clg@kaod.org>,
	"open list:RISC-V TCG CPUs" <qemu-riscv@nongnu.org>,
	"Cornelia Huck" <cohuck@redhat.com>,
	"open list:S390-ccw boot" <qemu-s390x@nongnu.org>,
	"Tyrone Ting" <kfting@nuvoton.com>,
	"Hanna Reitz" <hreitz@redhat.com>,
	"open list:ARM PrimeCell and..." <qemu-arm@nongnu.org>,
	"Wenchao Wang" <wenchao.wang@intel.com>,
	"Aurelien Jarno" <aurelien@aurel32.net>,
	"Elena Ufimtseva" <elena.ufimtseva@oracle.com>,
	"Jason Wang" <jasowang@redhat.com>,
	"Bin Meng" <bin.meng@windriver.com>,
	"Taylor Simpson" <tsimpson@quicinc.com>,
	"Colin Xu" <colin.xu@intel.com>,
	"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	"Daniel Henrique Barboza" <danielhb413@gmail.com>,
	"Joel Stanley" <joel@jms.id.au>,
	"Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
	"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
	"Fabien Chouteau" <chouteau@adacore.com>,
	"Roman Bolshakov" <r.bolshakov@yadro.com>,
	"Sunil Muthuswamy" <sunilmut@microsoft.com>,
	"Eduardo Habkost" <eduardo@habkost.net>,
	"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
	"Laurent Vivier" <Laurent@vivier.eu>,
	"open list:Overall KVM CPUs" <kvm@vger.kernel.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Christian Schoenebeck" <qemu_oss@crudebyte.com>,
	qemu-devel@nongnu.org,
	"open list:X86 HAXM CPUs" <haxm-team@intel.com>,
	"Ani Sinha" <ani@anisinha.ca>, "Warner Losh" <imp@bsdimp.com>,
	"Marek Vasut" <marex@denx.de>,
	"Jagannathan Raman" <jag.raman@oracle.com>,
	"Havard Skinnemoen" <hskinnemoen@google.com>,
	"Reinoud Zandijk" <reinoud@netbsd.org>,
	"Kyle Evans" <kevans@freebsd.org>,
	marcandre.lureau@redhat.com,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"David Gibson" <david@gibson.dropbear.id.au>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Darren Kenny" <darren.kenny@oracle.com>,
	"Eric Auger" <eric.auger@redhat.com>,
	"Thomas Huth" <huth@tuxfamily.org>,
	"Marcelo Tosatti" <mtosatti@redhat.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH 32/32] Remove qemu-common.h include from most units
Date: Wed, 6 Apr 2022 12:14:36 +0100	[thread overview]
Message-ID: <CAFEAcA9kYweS2zMHjWDuV_y2AxKbgJ5UYNHLK3sASCLVD=yEqg@mail.gmail.com> (raw)
In-Reply-To: <87o81epk1s.fsf@pond.sub.org>

On Wed, 6 Apr 2022 at 11:45, Markus Armbruster <armbru@redhat.com> wrote:
>
> First of all: thank you so much for completing the "empty out
> qemu-common.h" job!
>
> This is what's left:
>
>     #ifndef QEMU_COMMON_H
>     #define QEMU_COMMON_H
>
>     /* Copyright string for -version arguments, About dialogs, etc */
>     #define QEMU_COPYRIGHT "Copyright (c) 2003-2022 " \
>         "Fabrice Bellard and the QEMU Project developers"
>
>     /* Bug reporting information for --help arguments, About dialogs, etc */
>     #define QEMU_HELP_BOTTOM \
>         "See <https://qemu.org/contribute/report-a-bug> for how to report bugs.\n" \
>         "More information on the QEMU project at <https://qemu.org>."
>
>     #endif

> Rename the header?  Or replace the macros by variables, and move their
> declarations elsewhere?  Not demands; this series is lovely progress as
> is.

We should put those in a qemu/copyright.h, I think.
Leaving a "qemu-common.h" around is an open invitation to people
throwing more random stuff into it again in future.

As you say, we can totally do this as a later followup.

thanks
-- PMM