[PATCH] ebpf: only include in system emulators

[PATCH] ebpf: only include in system emulators

[Paolo Bonzini]

eBPF files are being included in system emulators, which is useless and
also breaks compilation because ebpf/trace-events is only processed
if a system emulator is included in the build.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/566
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 ebpf/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ebpf/meson.build b/ebpf/meson.build
index 9cd0635370..2dd0fd8948 100644
--- a/ebpf/meson.build
+++ b/ebpf/meson.build
@@ -1 +1 @@
-common_ss.add(when: libbpf, if_true: files('ebpf_rss.c'), if_false: files('ebpf_rss-stub.c'))
+softmmu_ss.add(when: libbpf, if_true: files('ebpf_rss.c'), if_false: files('ebpf_rss-stub.c'))
-- 
2.31.1

Re: [PATCH] ebpf: only include in system emulators

[Philippe Mathieu-Daudé]

On 9/7/21 12:45 PM, Paolo Bonzini wrote:
> eBPF files are being included in system emulators, which is useless and
> also breaks compilation because ebpf/trace-events is only processed
> if a system emulator is included in the build.
> 
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/566
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  ebpf/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Thanks.

Re: [PATCH] ebpf: only include in system emulators

[Peter Maydell]

On Tue, 7 Sept 2021 at 11:47, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> eBPF files are being included in system emulators, which is useless and

do you mean "in user-mode emulators" here ?


> also breaks compilation because ebpf/trace-events is only processed
> if a system emulator is included in the build.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/566
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

-- PMM

Re: [PATCH] ebpf: only include in system emulators

[Jason Wang]

在 2021/9/7 下午6:45, Paolo Bonzini 写道:
> eBPF files are being included in system emulators, which is useless


I think it should work since it's an independent feature. The current 
use case is to offload the RSS from Qemu to kernel TAP.


>   and
> also breaks compilation because ebpf/trace-events is only processed
> if a system emulator is included in the build.


Andrew, any way to fix this?

Thanks


>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/566
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   ebpf/meson.build | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ebpf/meson.build b/ebpf/meson.build
> index 9cd0635370..2dd0fd8948 100644
> --- a/ebpf/meson.build
> +++ b/ebpf/meson.build
> @@ -1 +1 @@
> -common_ss.add(when: libbpf, if_true: files('ebpf_rss.c'), if_false: files('ebpf_rss-stub.c'))
> +softmmu_ss.add(when: libbpf, if_true: files('ebpf_rss.c'), if_false: files('ebpf_rss-stub.c'))

Re: [PATCH] ebpf: only include in system emulators

[Paolo Bonzini]

On 08/09/21 05:08, Jason Wang wrote:
> 
> 在 2021/9/7 下午6:45, Paolo Bonzini 写道:
>> eBPF files are being included in system emulators, which is useless
> 
> 
> I think it should work since it's an independent feature. The current 
> use case is to offload the RSS from Qemu to kernel TAP.

Sorry, I meant "user emulators".  That should make more sense, they 
don't have TAP at all.

Paolo

Re: [PATCH] ebpf: only include in system emulators

[Jason Wang]

On Wed, Sep 8, 2021 at 1:46 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 08/09/21 05:08, Jason Wang wrote:
> >
> > 在 2021/9/7 下午6:45, Paolo Bonzini 写道:
> >> eBPF files are being included in system emulators, which is useless
> >
> >
> > I think it should work since it's an independent feature. The current
> > use case is to offload the RSS from Qemu to kernel TAP.
>
> Sorry, I meant "user emulators".  That should make more sense, they
> don't have TAP at all.
>
> Paolo
>

I see so I've queued this.

Thanks

Re: [PATCH] ebpf: only include in system emulators

[Peter Maydell]

On Thu, 9 Sept 2021 at 04:14, Jason Wang <jasowang@redhat.com> wrote:
>
> On Wed, Sep 8, 2021 at 1:46 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
> >
> > On 08/09/21 05:08, Jason Wang wrote:
> > >
> > > 在 2021/9/7 下午6:45, Paolo Bonzini 写道:
> > >> eBPF files are being included in system emulators, which is useless
> > >
> > >
> > > I think it should work since it's an independent feature. The current
> > > use case is to offload the RSS from Qemu to kernel TAP.
> >
> > Sorry, I meant "user emulators".  That should make more sense, they
> > don't have TAP at all.

> I see so I've queued this.

Did you fix the mistake in the commit message ?

thanks
-- PMM

Re: [PATCH] ebpf: only include in system emulators

[Jason Wang]

On Thu, Sep 9, 2021 at 5:50 PM Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Thu, 9 Sept 2021 at 04:14, Jason Wang <jasowang@redhat.com> wrote:
> >
> > On Wed, Sep 8, 2021 at 1:46 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
> > >
> > > On 08/09/21 05:08, Jason Wang wrote:
> > > >
> > > > 在 2021/9/7 下午6:45, Paolo Bonzini 写道:
> > > >> eBPF files are being included in system emulators, which is useless
> > > >
> > > >
> > > > I think it should work since it's an independent feature. The current
> > > > use case is to offload the RSS from Qemu to kernel TAP.
> > >
> > > Sorry, I meant "user emulators".  That should make more sense, they
> > > don't have TAP at all.
>
> > I see so I've queued this.
>
> Did you fix the mistake in the commit message ?

Yes.

Thanks

>
> thanks
> -- PMM
>