* [PATCH] ebpf: only include in system emulators
@ 2021-09-07 10:45 Paolo Bonzini
2021-09-07 10:58 ` Philippe Mathieu-Daudé
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Paolo Bonzini @ 2021-09-07 10:45 UTC (permalink / raw)
To: qemu-devel; +Cc: yuri.benditovich, jasowang, andrew
eBPF files are being included in system emulators, which is useless and
also breaks compilation because ebpf/trace-events is only processed
if a system emulator is included in the build.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/566
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
ebpf/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ebpf/meson.build b/ebpf/meson.build
index 9cd0635370..2dd0fd8948 100644
--- a/ebpf/meson.build
+++ b/ebpf/meson.build
@@ -1 +1 @@
-common_ss.add(when: libbpf, if_true: files('ebpf_rss.c'), if_false: files('ebpf_rss-stub.c'))
+softmmu_ss.add(when: libbpf, if_true: files('ebpf_rss.c'), if_false: files('ebpf_rss-stub.c'))
--
2.31.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] ebpf: only include in system emulators
2021-09-07 10:45 [PATCH] ebpf: only include in system emulators Paolo Bonzini
@ 2021-09-07 10:58 ` Philippe Mathieu-Daudé
2021-09-07 11:05 ` Peter Maydell
2021-09-08 3:08 ` Jason Wang
2 siblings, 0 replies; 8+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-09-07 10:58 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: yuri.benditovich, jasowang, andrew
On 9/7/21 12:45 PM, Paolo Bonzini wrote:
> eBPF files are being included in system emulators, which is useless and
> also breaks compilation because ebpf/trace-events is only processed
> if a system emulator is included in the build.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/566
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> ebpf/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ebpf: only include in system emulators
2021-09-07 10:45 [PATCH] ebpf: only include in system emulators Paolo Bonzini
2021-09-07 10:58 ` Philippe Mathieu-Daudé
@ 2021-09-07 11:05 ` Peter Maydell
2021-09-08 3:08 ` Jason Wang
2 siblings, 0 replies; 8+ messages in thread
From: Peter Maydell @ 2021-09-07 11:05 UTC (permalink / raw)
To: Paolo Bonzini
Cc: Yuri Benditovich, Jason Wang, QEMU Developers, Andrew Melnychenko
On Tue, 7 Sept 2021 at 11:47, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> eBPF files are being included in system emulators, which is useless and
do you mean "in user-mode emulators" here ?
> also breaks compilation because ebpf/trace-events is only processed
> if a system emulator is included in the build.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/566
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
-- PMM
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ebpf: only include in system emulators
2021-09-07 10:45 [PATCH] ebpf: only include in system emulators Paolo Bonzini
2021-09-07 10:58 ` Philippe Mathieu-Daudé
2021-09-07 11:05 ` Peter Maydell
@ 2021-09-08 3:08 ` Jason Wang
2021-09-08 5:46 ` Paolo Bonzini
2 siblings, 1 reply; 8+ messages in thread
From: Jason Wang @ 2021-09-08 3:08 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: yuri.benditovich, andrew
在 2021/9/7 下午6:45, Paolo Bonzini 写道:
> eBPF files are being included in system emulators, which is useless
I think it should work since it's an independent feature. The current
use case is to offload the RSS from Qemu to kernel TAP.
> and
> also breaks compilation because ebpf/trace-events is only processed
> if a system emulator is included in the build.
Andrew, any way to fix this?
Thanks
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/566
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> ebpf/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ebpf/meson.build b/ebpf/meson.build
> index 9cd0635370..2dd0fd8948 100644
> --- a/ebpf/meson.build
> +++ b/ebpf/meson.build
> @@ -1 +1 @@
> -common_ss.add(when: libbpf, if_true: files('ebpf_rss.c'), if_false: files('ebpf_rss-stub.c'))
> +softmmu_ss.add(when: libbpf, if_true: files('ebpf_rss.c'), if_false: files('ebpf_rss-stub.c'))
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ebpf: only include in system emulators
2021-09-08 3:08 ` Jason Wang
@ 2021-09-08 5:46 ` Paolo Bonzini
2021-09-09 3:07 ` Jason Wang
0 siblings, 1 reply; 8+ messages in thread
From: Paolo Bonzini @ 2021-09-08 5:46 UTC (permalink / raw)
To: Jason Wang, qemu-devel; +Cc: yuri.benditovich, andrew
On 08/09/21 05:08, Jason Wang wrote:
>
> 在 2021/9/7 下午6:45, Paolo Bonzini 写道:
>> eBPF files are being included in system emulators, which is useless
>
>
> I think it should work since it's an independent feature. The current
> use case is to offload the RSS from Qemu to kernel TAP.
Sorry, I meant "user emulators". That should make more sense, they
don't have TAP at all.
Paolo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ebpf: only include in system emulators
2021-09-08 5:46 ` Paolo Bonzini
@ 2021-09-09 3:07 ` Jason Wang
2021-09-09 9:49 ` Peter Maydell
0 siblings, 1 reply; 8+ messages in thread
From: Jason Wang @ 2021-09-09 3:07 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: Yuri Benditovich, Andrew Melnychenko, qemu-devel
On Wed, Sep 8, 2021 at 1:46 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 08/09/21 05:08, Jason Wang wrote:
> >
> > 在 2021/9/7 下午6:45, Paolo Bonzini 写道:
> >> eBPF files are being included in system emulators, which is useless
> >
> >
> > I think it should work since it's an independent feature. The current
> > use case is to offload the RSS from Qemu to kernel TAP.
>
> Sorry, I meant "user emulators". That should make more sense, they
> don't have TAP at all.
>
> Paolo
>
I see so I've queued this.
Thanks
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ebpf: only include in system emulators
2021-09-09 3:07 ` Jason Wang
@ 2021-09-09 9:49 ` Peter Maydell
2021-09-09 9:51 ` Jason Wang
0 siblings, 1 reply; 8+ messages in thread
From: Peter Maydell @ 2021-09-09 9:49 UTC (permalink / raw)
To: Jason Wang
Cc: Paolo Bonzini, Andrew Melnychenko, qemu-devel, Yuri Benditovich
On Thu, 9 Sept 2021 at 04:14, Jason Wang <jasowang@redhat.com> wrote:
>
> On Wed, Sep 8, 2021 at 1:46 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
> >
> > On 08/09/21 05:08, Jason Wang wrote:
> > >
> > > 在 2021/9/7 下午6:45, Paolo Bonzini 写道:
> > >> eBPF files are being included in system emulators, which is useless
> > >
> > >
> > > I think it should work since it's an independent feature. The current
> > > use case is to offload the RSS from Qemu to kernel TAP.
> >
> > Sorry, I meant "user emulators". That should make more sense, they
> > don't have TAP at all.
> I see so I've queued this.
Did you fix the mistake in the commit message ?
thanks
-- PMM
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ebpf: only include in system emulators
2021-09-09 9:49 ` Peter Maydell
@ 2021-09-09 9:51 ` Jason Wang
0 siblings, 0 replies; 8+ messages in thread
From: Jason Wang @ 2021-09-09 9:51 UTC (permalink / raw)
To: Peter Maydell
Cc: Paolo Bonzini, Andrew Melnychenko, qemu-devel, Yuri Benditovich
On Thu, Sep 9, 2021 at 5:50 PM Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Thu, 9 Sept 2021 at 04:14, Jason Wang <jasowang@redhat.com> wrote:
> >
> > On Wed, Sep 8, 2021 at 1:46 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
> > >
> > > On 08/09/21 05:08, Jason Wang wrote:
> > > >
> > > > 在 2021/9/7 下午6:45, Paolo Bonzini 写道:
> > > >> eBPF files are being included in system emulators, which is useless
> > > >
> > > >
> > > > I think it should work since it's an independent feature. The current
> > > > use case is to offload the RSS from Qemu to kernel TAP.
> > >
> > > Sorry, I meant "user emulators". That should make more sense, they
> > > don't have TAP at all.
>
> > I see so I've queued this.
>
> Did you fix the mistake in the commit message ?
Yes.
Thanks
>
> thanks
> -- PMM
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-09-09 9:53 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-07 10:45 [PATCH] ebpf: only include in system emulators Paolo Bonzini
2021-09-07 10:58 ` Philippe Mathieu-Daudé
2021-09-07 11:05 ` Peter Maydell
2021-09-08 3:08 ` Jason Wang
2021-09-08 5:46 ` Paolo Bonzini
2021-09-09 3:07 ` Jason Wang
2021-09-09 9:49 ` Peter Maydell
2021-09-09 9:51 ` Jason Wang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.