* [Qemu-devel] [PATCH] qemu-char: fix warning 'res' may be used uninitialized
@ 2014-06-25 8:00 Igor Mammedov
2014-06-25 9:08 ` Markus Armbruster
0 siblings, 1 reply; 5+ messages in thread
From: Igor Mammedov @ 2014-06-25 8:00 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, peter.maydell
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
qemu-char.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index 2e50a10..f6bdf2f 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -132,7 +132,7 @@ int qemu_chr_fe_write(CharDriverState *s, const uint8_t *buf, int len)
int qemu_chr_fe_write_all(CharDriverState *s, const uint8_t *buf, int len)
{
int offset = 0;
- int res;
+ int res = 0;
qemu_mutex_lock(&s->chr_write_lock);
while (offset < len) {
--
1.7.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] qemu-char: fix warning 'res' may be used uninitialized
2014-06-25 8:00 [Qemu-devel] [PATCH] qemu-char: fix warning 'res' may be used uninitialized Igor Mammedov
@ 2014-06-25 9:08 ` Markus Armbruster
2014-06-25 11:51 ` Igor Mammedov
0 siblings, 1 reply; 5+ messages in thread
From: Markus Armbruster @ 2014-06-25 9:08 UTC (permalink / raw)
To: Igor Mammedov; +Cc: qemu-trivial, peter.maydell, qemu-devel, Paolo Bonzini
Igor Mammedov <imammedo@redhat.com> writes:
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Broken in commit 9005b2a (author cc'ed). Bites only when passed zero
len, which seems unlikely.
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] qemu-char: fix warning 'res' may be used uninitialized
2014-06-25 9:08 ` Markus Armbruster
@ 2014-06-25 11:51 ` Igor Mammedov
2014-06-25 19:10 ` Stefan Weil
0 siblings, 1 reply; 5+ messages in thread
From: Igor Mammedov @ 2014-06-25 11:51 UTC (permalink / raw)
To: Markus Armbruster; +Cc: qemu-trivial, peter.maydell, qemu-devel, Paolo Bonzini
On Wed, 25 Jun 2014 11:08:29 +0200
Markus Armbruster <armbru@redhat.com> wrote:
> Igor Mammedov <imammedo@redhat.com> writes:
>
> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
>
> Broken in commit 9005b2a (author cc'ed). Bites only when passed zero
> len, which seems unlikely.
>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
>
main motivation for the patch was to allow -Werror=all build pass.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] qemu-char: fix warning 'res' may be used uninitialized
2014-06-25 11:51 ` Igor Mammedov
@ 2014-06-25 19:10 ` Stefan Weil
2014-06-26 12:03 ` Peter Maydell
0 siblings, 1 reply; 5+ messages in thread
From: Stefan Weil @ 2014-06-25 19:10 UTC (permalink / raw)
To: Igor Mammedov, Markus Armbruster
Cc: qemu-trivial, peter.maydell, qemu-devel, Paolo Bonzini
Am 25.06.2014 13:51, schrieb Igor Mammedov:
> On Wed, 25 Jun 2014 11:08:29 +0200
> Markus Armbruster <armbru@redhat.com> wrote:
>
>> Igor Mammedov <imammedo@redhat.com> writes:
>>
>>> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
>>
>> Broken in commit 9005b2a (author cc'ed). Bites only when passed zero
>> len, which seems unlikely.
>>
>> Reviewed-by: Markus Armbruster <armbru@redhat.com>
>>
>
> main motivation for the patch was to allow -Werror=all build pass.
>
As I sent an identical patch some minutes ago, I can add
Reviewed-by: Stefan Weil <sw@weilnetz.de>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] qemu-char: fix warning 'res' may be used uninitialized
2014-06-25 19:10 ` Stefan Weil
@ 2014-06-26 12:03 ` Peter Maydell
0 siblings, 0 replies; 5+ messages in thread
From: Peter Maydell @ 2014-06-26 12:03 UTC (permalink / raw)
To: Stefan Weil
Cc: QEMU Trivial, Igor Mammedov, Paolo Bonzini, Markus Armbruster,
QEMU Developers
On 25 June 2014 20:10, Stefan Weil <sw@weilnetz.de> wrote:
> Am 25.06.2014 13:51, schrieb Igor Mammedov:
>> On Wed, 25 Jun 2014 11:08:29 +0200
>> Markus Armbruster <armbru@redhat.com> wrote:
>>
>>> Igor Mammedov <imammedo@redhat.com> writes:
>>>
>>>> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
>>>
>>> Broken in commit 9005b2a (author cc'ed). Bites only when passed zero
>>> len, which seems unlikely.
>>>
>>> Reviewed-by: Markus Armbruster <armbru@redhat.com>
>>>
>>
>> main motivation for the patch was to allow -Werror=all build pass.
>>
>
> As I sent an identical patch some minutes ago, I can add
>
> Reviewed-by: Stefan Weil <sw@weilnetz.de>
Applied to master as a buildfix; thanks.
-- PMM
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-06-26 12:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-25 8:00 [Qemu-devel] [PATCH] qemu-char: fix warning 'res' may be used uninitialized Igor Mammedov
2014-06-25 9:08 ` Markus Armbruster
2014-06-25 11:51 ` Igor Mammedov
2014-06-25 19:10 ` Stefan Weil
2014-06-26 12:03 ` Peter Maydell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.