All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] badblocks: Prefer unsigned int over unsigned
@ 2019-02-24 14:19 Bharath Vedartham
  2019-02-24 15:15 ` Jens Axboe
  0 siblings, 1 reply; 5+ messages in thread
From: Bharath Vedartham @ 2019-02-24 14:19 UTC (permalink / raw)
  To: axboe; +Cc: linux-block, linux-kernel

Replace unsigned with unsigned int to improve readability.

Signed-off-by: Bharath Vedartham <linux.bhar@gmail.com>
---
 block/badblocks.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/badblocks.c b/block/badblocks.c
index 91f7bcf..e3f90c9 100644
--- a/block/badblocks.c
+++ b/block/badblocks.c
@@ -66,7 +66,7 @@ int badblocks_check(struct badblocks *bb, sector_t s, int sectors,
 	u64 *p = bb->page;
 	int rv;
 	sector_t target = s + sectors;
-	unsigned seq;
+	unsigned int seq;
 
 	if (bb->shift > 0) {
 		/* round the start down, and the end up */
-- 
2.7.4


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] badblocks: Prefer unsigned int over unsigned
  2019-02-24 14:19 [PATCH] badblocks: Prefer unsigned int over unsigned Bharath Vedartham
@ 2019-02-24 15:15 ` Jens Axboe
  2019-02-24 15:37   ` Bharath Vedartham
  0 siblings, 1 reply; 5+ messages in thread
From: Jens Axboe @ 2019-02-24 15:15 UTC (permalink / raw)
  To: Bharath Vedartham; +Cc: linux-block, linux-kernel

On 2/24/19 7:19 AM, Bharath Vedartham wrote:
> Replace unsigned with unsigned int to improve readability.

Frivolous change, would make a lot more sense to get checkpatch
to stop complaining about this.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] badblocks: Prefer unsigned int over unsigned
  2019-02-24 15:15 ` Jens Axboe
@ 2019-02-24 15:37   ` Bharath Vedartham
  2019-02-24 15:50     ` Richard Weinberger
  0 siblings, 1 reply; 5+ messages in thread
From: Bharath Vedartham @ 2019-02-24 15:37 UTC (permalink / raw)
  To: Jens Axboe; +Cc: linux-block, linux-kernel

On Sun, Feb 24, 2019 at 08:15:30AM -0700, Jens Axboe wrote:
> On 2/24/19 7:19 AM, Bharath Vedartham wrote:
> > Replace unsigned with unsigned int to improve readability.
> 
> Frivolous change, would make a lot more sense to get checkpatch
> to stop complaining about this.
> 
> -- 
> Jens Axboe
>
I understand. I am starting out kernel hacking. I have been working on
fixing checkpatch.pl warnings. If you have any tasks for me in the
kernel, it would be great.

I have also noticed a lot of warnings to replace printk with subsystem
specific warning functions. Is that a valuable change?

Bharath

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] badblocks: Prefer unsigned int over unsigned
  2019-02-24 15:37   ` Bharath Vedartham
@ 2019-02-24 15:50     ` Richard Weinberger
  2019-02-25 17:03       ` Bharath Vedartham
  0 siblings, 1 reply; 5+ messages in thread
From: Richard Weinberger @ 2019-02-24 15:50 UTC (permalink / raw)
  To: Bharath Vedartham; +Cc: Jens Axboe, linux-block, LKML

On Sun, Feb 24, 2019 at 4:38 PM Bharath Vedartham <linux.bhar@gmail.com> wrote:
> I understand. I am starting out kernel hacking. I have been working on
> fixing checkpatch.pl warnings. If you have any tasks for me in the
> kernel, it would be great.
>
> I have also noticed a lot of warnings to replace printk with subsystem
> specific warning functions. Is that a valuable change?

This is a very good start:
https://lists.kernelnewbies.org/pipermail/kernelnewbies/2017-April/017765.html

Happy hacking and welcome! :-)

-- 
Thanks,
//richard

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] badblocks: Prefer unsigned int over unsigned
  2019-02-24 15:50     ` Richard Weinberger
@ 2019-02-25 17:03       ` Bharath Vedartham
  0 siblings, 0 replies; 5+ messages in thread
From: Bharath Vedartham @ 2019-02-25 17:03 UTC (permalink / raw)
  To: Richard Weinberger; +Cc: Jens Axboe, linux-block, LKML

On Sun, Feb 24, 2019 at 04:50:51PM +0100, Richard Weinberger wrote:
> On Sun, Feb 24, 2019 at 4:38 PM Bharath Vedartham <linux.bhar@gmail.com> wrote:
> > I understand. I am starting out kernel hacking. I have been working on
> > fixing checkpatch.pl warnings. If you have any tasks for me in the
> > kernel, it would be great.
> >
> > I have also noticed a lot of warnings to replace printk with subsystem
> > specific warning functions. Is that a valuable change?
> 
> This is a very good start:
> https://lists.kernelnewbies.org/pipermail/kernelnewbies/2017-April/017765.html
> 
> Happy hacking and welcome! :-)
> 
> -- 
> Thanks,
> //richard

Hey! Thanks for the link Richard! I have read it and clearly understood
the message. I will work on understanding the kernel and writing my own
code for my own personal learning before jumping into tasks! Thanks for
your time!

Bharath

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-02-25 17:05 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-24 14:19 [PATCH] badblocks: Prefer unsigned int over unsigned Bharath Vedartham
2019-02-24 15:15 ` Jens Axboe
2019-02-24 15:37   ` Bharath Vedartham
2019-02-24 15:50     ` Richard Weinberger
2019-02-25 17:03       ` Bharath Vedartham

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.