* [PATCH] regulator: max77620: Fix regulator info setting for max20024
@ 2019-02-24 1:26 Axel Lin
2019-03-21 8:37 ` Axel Lin
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2019-02-24 1:26 UTC (permalink / raw)
To: Mark Brown
Cc: Mark Zhang, Venkat Reddy Talla, Laxman Dewangan, Liam Girdwood,
linux-kernel, Axel Lin
Current code always set pmic->rinfo[id] = &max77620_regs_info[id];
It should set to either max77620_regs_info or max20024_regs_info
depends on the chip_id.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/regulator/max77620-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/max77620-regulator.c b/drivers/regulator/max77620-regulator.c
index 1607ac673e44..0ad91a7f9cb9 100644
--- a/drivers/regulator/max77620-regulator.c
+++ b/drivers/regulator/max77620-regulator.c
@@ -803,7 +803,7 @@ static int max77620_regulator_probe(struct platform_device *pdev)
continue;
rdesc = &rinfo[id].desc;
- pmic->rinfo[id] = &max77620_regs_info[id];
+ pmic->rinfo[id] = &rinfo[id];
pmic->enable_power_mode[id] = MAX77620_POWER_MODE_NORMAL;
pmic->reg_pdata[id].active_fps_src = -1;
pmic->reg_pdata[id].active_fps_pd_slot = -1;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] regulator: max77620: Fix regulator info setting for max20024
2019-02-24 1:26 [PATCH] regulator: max77620: Fix regulator info setting for max20024 Axel Lin
@ 2019-03-21 8:37 ` Axel Lin
0 siblings, 0 replies; 2+ messages in thread
From: Axel Lin @ 2019-03-21 8:37 UTC (permalink / raw)
To: Mark Brown
Cc: Mark Zhang, Venkat Reddy Talla, Laxman Dewangan, Liam Girdwood, LKML
Axel Lin <axel.lin@ingics.com> 於 2019年2月24日 週日 上午9:27寫道：
>
> Current code always set pmic->rinfo[id] = &max77620_regs_info[id];
> It should set to either max77620_regs_info or max20024_regs_info
> depends on the chip_id.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/regulator/max77620-regulator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/max77620-regulator.c b/drivers/regulator/max77620-regulator.c
> index 1607ac673e44..0ad91a7f9cb9 100644
> --- a/drivers/regulator/max77620-regulator.c
> +++ b/drivers/regulator/max77620-regulator.c
> @@ -803,7 +803,7 @@ static int max77620_regulator_probe(struct platform_device *pdev)
> continue;
>
> rdesc = &rinfo[id].desc;
> - pmic->rinfo[id] = &max77620_regs_info[id];
> + pmic->rinfo[id] = &rinfo[id];
I'm wondering if anyone can help review this patch.
This looks like a bug fix to me because for max20024 MAX77620_REGULATOR_ID_SD4,
the pmic->rinfo[id] = &max77620_regs_info[id]; set pmic->rinfo[id] to
a zero-filled entry.
e.g. In max77620_regulator_set_power_mode, rinfo->cfg_addr is wrong
for MAX77620_REGULATOR_ID_SD4.
Thanks,
Axel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-21 8:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-24 1:26 [PATCH] regulator: max77620: Fix regulator info setting for max20024 Axel Lin
2019-03-21 8:37 ` Axel Lin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.