* [PATCH v2 20/20] x86/PCI: VMD: Fix malformed Kconfig default
[not found] <0180206191126.GB98765@bhelgaas-glaptop.roam.corp.google.com>
@ 2018-02-06 22:11 ` Ulf Magnusson
2018-02-22 23:00 ` Bjorn Helgaas
2018-02-23 11:52 ` Lorenzo Pieralisi
0 siblings, 2 replies; 6+ messages in thread
From: Ulf Magnusson @ 2018-02-06 22:11 UTC (permalink / raw)
To: helgaas
Cc: linux-kernel, linux-kbuild, tfiga, paul.burton, m.szyprowski,
egtvedt, linus.walleij, vgupta, mgorman, hch, mina86, robh,
sboyd, paulus, will.deacon, tony, npiggin, yamada.masahiro,
lorenzo.pieralisi, bhelgaas, linux-pci, Ulf Magnusson
'default N' should be 'default n', though they happen to have the same
effect here, due to undefined symbols (N in this case) evaluating to n
in a tristate sense.
Remove the default instead of changing it. bool and tristate symbols
implicitly default to n.
Discovered with the
https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
script.
Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
Changes in v2:
Make it clear that Kconfig is involved.
drivers/pci/host/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
index a4ed7484d127..dc8a2a175f19 100644
--- a/drivers/pci/host/Kconfig
+++ b/drivers/pci/host/Kconfig
@@ -215,7 +215,6 @@ config PCIE_TANGO_SMP8759
config VMD
depends on PCI_MSI && X86_64 && SRCU
tristate "Intel Volume Management Device Driver"
- default N
---help---
Adds support for the Intel Volume Management Device (VMD). VMD is a
secondary PCI host bridge that allows PCI Express root ports,
--
2.14.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 20/20] x86/PCI: VMD: Fix malformed Kconfig default
2018-02-06 22:11 ` [PATCH v2 20/20] x86/PCI: VMD: Fix malformed Kconfig default Ulf Magnusson
@ 2018-02-22 23:00 ` Bjorn Helgaas
2018-02-22 23:42 ` Ulf Magnusson
2018-02-23 11:52 ` Lorenzo Pieralisi
1 sibling, 1 reply; 6+ messages in thread
From: Bjorn Helgaas @ 2018-02-22 23:00 UTC (permalink / raw)
To: Ulf Magnusson
Cc: linux-kernel, linux-kbuild, tfiga, paul.burton, m.szyprowski,
egtvedt, linus.walleij, vgupta, mgorman, hch, mina86, robh,
sboyd, paulus, will.deacon, tony, npiggin, yamada.masahiro,
lorenzo.pieralisi, bhelgaas, linux-pci
On Tue, Feb 06, 2018 at 11:11:06PM +0100, Ulf Magnusson wrote:
> 'default N' should be 'default n', though they happen to have the same
> effect here, due to undefined symbols (N in this case) evaluating to n
> in a tristate sense.
>
> Remove the default instead of changing it. bool and tristate symbols
> implicitly default to n.
s/bool/Bool/
> Discovered with the
> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
> script.
>
> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
Since only this patch was posted to linux-pci, I assume it will be merged
via some other tree.
> ---
> Changes in v2:
> Make it clear that Kconfig is involved.
>
> drivers/pci/host/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> index a4ed7484d127..dc8a2a175f19 100644
> --- a/drivers/pci/host/Kconfig
> +++ b/drivers/pci/host/Kconfig
> @@ -215,7 +215,6 @@ config PCIE_TANGO_SMP8759
> config VMD
> depends on PCI_MSI && X86_64 && SRCU
> tristate "Intel Volume Management Device Driver"
> - default N
> ---help---
> Adds support for the Intel Volume Management Device (VMD). VMD is a
> secondary PCI host bridge that allows PCI Express root ports,
> --
> 2.14.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 20/20] x86/PCI: VMD: Fix malformed Kconfig default
2018-02-22 23:00 ` Bjorn Helgaas
@ 2018-02-22 23:42 ` Ulf Magnusson
2018-02-23 0:21 ` Bjorn Helgaas
0 siblings, 1 reply; 6+ messages in thread
From: Ulf Magnusson @ 2018-02-22 23:42 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: Linux Kernel Mailing List, Linux Kbuild mailing list,
Tomasz Figa, Paul Burton, Marek Szyprowski,
Hans-Christian Noren Egtvedt, Linus Walleij, Vineet Gupta,
Mel Gorman, Christoph Hellwig, Michal Nazarewicz, Rob Herring,
Stephen Boyd, Paul Mackerras, Will Deacon, Tony Lindgren,
Nicholas Piggin, Masahiro Yamada, Lorenzo Pieralisi,
Bjorn Helgaas, linux-pci
On Fri, Feb 23, 2018 at 12:00 AM, Bjorn Helgaas <helgaas@kernel.org> wrote:
> On Tue, Feb 06, 2018 at 11:11:06PM +0100, Ulf Magnusson wrote:
>> 'default N' should be 'default n', though they happen to have the same
>> effect here, due to undefined symbols (N in this case) evaluating to n
>> in a tristate sense.
>>
>> Remove the default instead of changing it. bool and tristate symbols
>> implicitly default to n.
>
> s/bool/Bool/
Not a great excuse, but I was thinking syntactically -- 'bool' and
'tristate' symbols... :)
>
>> Discovered with the
>> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
>> script.
>>
>> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
>
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
>
> Since only this patch was posted to linux-pci, I assume it will be merged
> via some other tree.
I didn't have a particular tree in mind for this patchset. I imagined
people would pick up patches into the trees where they make the most
sense, and only created the patchset to keep track of the patches more
easily. Might have created some confusion in retrospect.
I just did a --cc-cmd="scripts/get_maintainer.pl -i" for the
individual patches by the way.
Cheers,
Ulf
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 20/20] x86/PCI: VMD: Fix malformed Kconfig default
2018-02-22 23:42 ` Ulf Magnusson
@ 2018-02-23 0:21 ` Bjorn Helgaas
2018-02-23 10:35 ` Lorenzo Pieralisi
0 siblings, 1 reply; 6+ messages in thread
From: Bjorn Helgaas @ 2018-02-23 0:21 UTC (permalink / raw)
To: Ulf Magnusson
Cc: Linux Kernel Mailing List, Linux Kbuild mailing list,
Tomasz Figa, Paul Burton, Marek Szyprowski,
Hans-Christian Noren Egtvedt, Linus Walleij, Vineet Gupta,
Mel Gorman, Christoph Hellwig, Michal Nazarewicz, Rob Herring,
Stephen Boyd, Paul Mackerras, Will Deacon, Tony Lindgren,
Nicholas Piggin, Masahiro Yamada, Lorenzo Pieralisi,
Bjorn Helgaas, linux-pci
On Fri, Feb 23, 2018 at 12:42:28AM +0100, Ulf Magnusson wrote:
> On Fri, Feb 23, 2018 at 12:00 AM, Bjorn Helgaas <helgaas@kernel.org> wrote:
> > On Tue, Feb 06, 2018 at 11:11:06PM +0100, Ulf Magnusson wrote:
> >> 'default N' should be 'default n', though they happen to have the same
> >> effect here, due to undefined symbols (N in this case) evaluating to n
> >> in a tristate sense.
> >>
> >> Remove the default instead of changing it. bool and tristate symbols
> >> implicitly default to n.
> >
> > s/bool/Bool/
>
> Not a great excuse, but I was thinking syntactically -- 'bool' and
> 'tristate' symbols... :)
>
> >
> >> Discovered with the
> >> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
> >> script.
> >>
> >> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
> >
> > Acked-by: Bjorn Helgaas <bhelgaas@google.com>
> >
> > Since only this patch was posted to linux-pci, I assume it will be merged
> > via some other tree.
>
> I didn't have a particular tree in mind for this patchset. I imagined
> people would pick up patches into the trees where they make the most
> sense, and only created the patchset to keep track of the patches more
> easily. Might have created some confusion in retrospect.
>
> I just did a --cc-cmd="scripts/get_maintainer.pl -i" for the
> individual patches by the way.
OK, then either Lorenzo or I will pick it up.
It's in drivers/pci/host/, so ideally Lorenzo will take it since he
looks after everything else in there.
Bjorn
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 20/20] x86/PCI: VMD: Fix malformed Kconfig default
2018-02-23 0:21 ` Bjorn Helgaas
@ 2018-02-23 10:35 ` Lorenzo Pieralisi
0 siblings, 0 replies; 6+ messages in thread
From: Lorenzo Pieralisi @ 2018-02-23 10:35 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: Ulf Magnusson, Linux Kernel Mailing List,
Linux Kbuild mailing list, Tomasz Figa, Paul Burton,
Marek Szyprowski, Hans-Christian Noren Egtvedt, Linus Walleij,
Vineet Gupta, Mel Gorman, Christoph Hellwig, Michal Nazarewicz,
Rob Herring, Stephen Boyd, Paul Mackerras, Will Deacon,
Tony Lindgren, Nicholas Piggin, Masahiro Yamada, Bjorn Helgaas,
linux-pci
On Thu, Feb 22, 2018 at 06:21:42PM -0600, Bjorn Helgaas wrote:
> On Fri, Feb 23, 2018 at 12:42:28AM +0100, Ulf Magnusson wrote:
> > On Fri, Feb 23, 2018 at 12:00 AM, Bjorn Helgaas <helgaas@kernel.org> wrote:
> > > On Tue, Feb 06, 2018 at 11:11:06PM +0100, Ulf Magnusson wrote:
> > >> 'default N' should be 'default n', though they happen to have the same
> > >> effect here, due to undefined symbols (N in this case) evaluating to n
> > >> in a tristate sense.
> > >>
> > >> Remove the default instead of changing it. bool and tristate symbols
> > >> implicitly default to n.
> > >
> > > s/bool/Bool/
> >
> > Not a great excuse, but I was thinking syntactically -- 'bool' and
> > 'tristate' symbols... :)
> >
> > >
> > >> Discovered with the
> > >> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
> > >> script.
> > >>
> > >> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
> > >
> > > Acked-by: Bjorn Helgaas <bhelgaas@google.com>
> > >
> > > Since only this patch was posted to linux-pci, I assume it will be merged
> > > via some other tree.
> >
> > I didn't have a particular tree in mind for this patchset. I imagined
> > people would pick up patches into the trees where they make the most
> > sense, and only created the patchset to keep track of the patches more
> > easily. Might have created some confusion in retrospect.
> >
> > I just did a --cc-cmd="scripts/get_maintainer.pl -i" for the
> > individual patches by the way.
>
> OK, then either Lorenzo or I will pick it up.
>
> It's in drivers/pci/host/, so ideally Lorenzo will take it since he
> looks after everything else in there.
Sure I will take it, thanks.
Lorenzo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 20/20] x86/PCI: VMD: Fix malformed Kconfig default
2018-02-06 22:11 ` [PATCH v2 20/20] x86/PCI: VMD: Fix malformed Kconfig default Ulf Magnusson
2018-02-22 23:00 ` Bjorn Helgaas
@ 2018-02-23 11:52 ` Lorenzo Pieralisi
1 sibling, 0 replies; 6+ messages in thread
From: Lorenzo Pieralisi @ 2018-02-23 11:52 UTC (permalink / raw)
To: Ulf Magnusson
Cc: helgaas, linux-kernel, linux-kbuild, tfiga, paul.burton,
m.szyprowski, egtvedt, linus.walleij, vgupta, mgorman, hch,
mina86, robh, sboyd, paulus, will.deacon, tony, npiggin,
yamada.masahiro, bhelgaas, linux-pci
On Tue, Feb 06, 2018 at 11:11:06PM +0100, Ulf Magnusson wrote:
> 'default N' should be 'default n', though they happen to have the same
> effect here, due to undefined symbols (N in this case) evaluating to n
> in a tristate sense.
>
> Remove the default instead of changing it. bool and tristate symbols
> implicitly default to n.
>
> Discovered with the
> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
> script.
I have remove this link - it can become stale so I do not think it is
worth adding it to the log.
I have also reworded the $SUBJECT.
Applied to pci/host/misc for v4.17, let me know if that's fine for you.
Thanks,
Lorenzo
> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
> ---
> Changes in v2:
> Make it clear that Kconfig is involved.
>
> drivers/pci/host/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> index a4ed7484d127..dc8a2a175f19 100644
> --- a/drivers/pci/host/Kconfig
> +++ b/drivers/pci/host/Kconfig
> @@ -215,7 +215,6 @@ config PCIE_TANGO_SMP8759
> config VMD
> depends on PCI_MSI && X86_64 && SRCU
> tristate "Intel Volume Management Device Driver"
> - default N
> ---help---
> Adds support for the Intel Volume Management Device (VMD). VMD is a
> secondary PCI host bridge that allows PCI Express root ports,
> --
> 2.14.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-02-23 11:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <0180206191126.GB98765@bhelgaas-glaptop.roam.corp.google.com>
2018-02-06 22:11 ` [PATCH v2 20/20] x86/PCI: VMD: Fix malformed Kconfig default Ulf Magnusson
2018-02-22 23:00 ` Bjorn Helgaas
2018-02-22 23:42 ` Ulf Magnusson
2018-02-23 0:21 ` Bjorn Helgaas
2018-02-23 10:35 ` Lorenzo Pieralisi
2018-02-23 11:52 ` Lorenzo Pieralisi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.