Re: [Outreachy kernel] [PATCH 3/6] staging: vt6656: main_usb: Replace data type declaration with variable of same type

[Namrata A Shettar <namrataashettar@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2220 bytes --]

On Thu, Sep 15, 2016 at 07:19:23AM +0200, Julia Lawall wrote:
>
>
> On Thu, 15 Sep 2016, Namrata A Shettar wrote:
>
> > This patch fixes checkpatch issue:
> > -Replacing sizeof(struct vnt_usb_send_context) with sizeof(*tx_context)
> > -Replacing sizeof(struct vnt_rcb) with sizeof(*priv->rcb[ii])
> > The replacements are of the type they are replaced with hence size
> > remains same.
> >
> > Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
> > ---
> >  drivers/staging/vt6656/main_usb.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> >         for (ii = 0; ii < priv->num_tx_context; ii++) {
> > -               tx_context = kmalloc(sizeof(struct
vnt_usb_send_context),
> > +               tx_context = kmalloc(sizeof(*tx_context),
> >
GFP_KERNEL);
>
> The GFP_KERNEL argument should not be left way out on the right like that.
> Now it could be on the sam line as the kmalloc.
>
> julia
>

Will that change come in the same patch? or should I create a new patch
for the same?

Thanks,
Namrata

On Thu, Sep 15, 2016 at 11:38 PM, Namrata A Shettar <
namrataashettar@gmail.com> wrote:

> On Thu, Sep 15, 2016 at 07:19:23AM +0200, Julia Lawall wrote:
> >
> >
> > On Thu, 15 Sep 2016, Namrata A Shettar wrote:
> >
> > > This patch fixes checkpatch issue:
> > > -Replacing sizeof(struct vnt_usb_send_context) with sizeof(*tx_context)
> > > -Replacing sizeof(struct vnt_rcb) with sizeof(*priv->rcb[ii])
> > > The replacements are of the type they are replaced with hence size
> > > remains same.
> > >
> > > Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
> > > ---
> > >  drivers/staging/vt6656/main_usb.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > >         for (ii = 0; ii < priv->num_tx_context; ii++) {
> > > -               tx_context = kmalloc(sizeof(struct
> vnt_usb_send_context),
> > > +               tx_context = kmalloc(sizeof(*tx_context),
> > >
> GFP_KERNEL);
> >
> > The GFP_KERNEL argument should not be left way out on the right like
> that.
> > Now it could be on the sam line as the kmalloc.
> >
> > julia
> >
>
> Will that change come in the same patch? or should I create a new patch
> for the same?
>
> Thanks,
> Namrata
>

[-- Attachment #2: Type: text/html, Size: 3575 bytes --]