Re: [Outreachy kernel] [PATCH 3/6] staging: vt6656: main_usb: Replace data type declaration with variable of same type

[Julia Lawall <julia.lawall@lip6.fr>]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 3494 bytes --]



On Thu, 15 Sep 2016, Namrata A Shettar wrote:

> On Thu, Sep 15, 2016 at 07:19:23AM +0200, Julia Lawall wrote:
> >
> >
> > On Thu, 15 Sep 2016, Namrata A Shettar wrote:
> >
> > > This patch fixes checkpatch issue:
> > > -Replacing sizeof(struct vnt_usb_send_context) with sizeof(*tx_context)
> > > -Replacing sizeof(struct vnt_rcb) with sizeof(*priv->rcb[ii])
> > > The replacements are of the type they are replaced with hence size
> > > remains same.
> > >
> > > Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
> > > ---
> > >  drivers/staging/vt6656/main_usb.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > >         for (ii = 0; ii < priv->num_tx_context; ii++) {
> > > -               tx_context = kmalloc(sizeof(struct
> vnt_usb_send_context),
> > > +               tx_context = kmalloc(sizeof(*tx_context),
> > >                                                                
> GFP_KERNEL);
> >
> > The GFP_KERNEL argument should not be left way out on the right like that.
> > Now it could be on the sam line as the kmalloc.
> >
> > julia
> >
>
> Will that change come in the same patch? or should I create a new patch
> for the same?

I think you could put the whole thing in one patch. The need to move the
GFP_KERNEL comes because you changed the sizeof argument.

julia

>
> Thanks,
> Namrata
>
> On Thu, Sep 15, 2016 at 11:38 PM, Namrata A Shettar
> <namrataashettar@gmail.com> wrote:
>       On Thu, Sep 15, 2016 at 07:19:23AM +0200, Julia Lawall wrote:
>       >
>       >
>       > On Thu, 15 Sep 2016, Namrata A Shettar wrote:
>       >
>       > > This patch fixes checkpatch issue:
>       > > -Replacing sizeof(struct vnt_usb_send_context) with
>       sizeof(*tx_context)
>       > > -Replacing sizeof(struct vnt_rcb) with
>       sizeof(*priv->rcb[ii])
>       > > The replacements are of the type they are replaced with
>       hence size
>       > > remains same.
>       > >
>       > > Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
>       > > ---
>       > >  drivers/staging/vt6656/main_usb.c | 4 ++--
>       > >  1 file changed, 2 insertions(+), 2 deletions(-)
>       > >
>       > >         for (ii = 0; ii < priv->num_tx_context; ii++) {
>       > > -               tx_context = kmalloc(sizeof(struct
>       vnt_usb_send_context),
>       > > +               tx_context = kmalloc(sizeof(*tx_context),
>       > >                                                            
>           GFP_KERNEL);
>       >
>       > The GFP_KERNEL argument should not be left way out on the
>       right like that.
>       > Now it could be on the sam line as the kmalloc.
>       >
>       > julia
>       >
>
>       Will that change come in the same patch? or should I create a
>       new patch
>       for the same?
>
>       Thanks,
>       Namrata
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CAFrQyDFZ92oTmzrW1k62uyj
> RowFKbkhmX6jzzcX334kJCzjbuA%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
>