Re: [Outreachy kernel] [PATCH 3/6] staging: vt6656: main_usb: Replace data type declaration with variable of same type

[Julia Lawall <julia.lawall@lip6.fr>]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 2442 bytes --]



On Thu, 15 Sep 2016, Namrata A Shettar wrote:

> This patch fixes checkpatch issue:
> -Replacing sizeof(struct vnt_usb_send_context) with sizeof(*tx_context)
> -Replacing sizeof(struct vnt_rcb) with sizeof(*priv->rcb[ii])
> The replacements are of the type they are replaced with hence size
> remains same.
>
> Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
> ---
>  drivers/staging/vt6656/main_usb.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/vt6656/main_usb.c
> b/drivers/staging/vt6656/main_usb.c
> index d79f07f..c03f023 100644
> --- a/drivers/staging/vt6656/main_usb.c
> +++ b/drivers/staging/vt6656/main_usb.c
> @@ -429,7 +429,7 @@ static bool vnt_alloc_bufs(struct vnt_private *priv)
>         int ii;
>
>         for (ii = 0; ii < priv->num_tx_context; ii++) {
> -               tx_context = kmalloc(sizeof(struct vnt_usb_send_context),
> +               tx_context = kmalloc(sizeof(*tx_context),
>                                                                 GFP_KERNEL);

The GFP_KERNEL argument should not be left way out on the right like that.
Now it could be on the sam line as the kmalloc.

julia

>                 if (!tx_context)
>                         goto free_tx;
> @@ -447,7 +447,7 @@ static bool vnt_alloc_bufs(struct vnt_private *priv)
>         }
>
>         for (ii = 0; ii < priv->num_rcb; ii++) {
> -               priv->rcb[ii] = kzalloc(sizeof(struct vnt_rcb), GFP_KERNEL);
> +               priv->rcb[ii] = kzalloc(sizeof(*priv->rcb[ii]), GFP_KERNEL);
>                 if (!priv->rcb[ii]) {
>                         dev_err(&priv->usb->dev,
>                                         "failed to allocate rcb no %d\n",
> ii);
>
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CAFrQyDHhpXVeYyQGb%3DkwR
> p%3D4ToJw-9i6Y2KiwxVTb%3D21Wtxb9Q%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
>