From: Chunyan Zhang <zhang.chunyan@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: SF Markus Elfring <elfring@users.sourceforge.net>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Harjani Ritesh <riteshh@codeaurora.org>,
Jens Axboe <axboe@fb.com>, Mike Christie <mchristi@redhat.com>,
Shawn Lin <shawn.lin@rock-chips.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/8] mmc-core: Use kmalloc_array() in mmc_test_area_init()
Date: Tue, 10 Jan 2017 15:37:54 +0800 [thread overview]
Message-ID: <CAG2=9p_E6byp0PKY5FUbXgwrN6pwYAxBh40SpDXJSu_yWSBxWQ@mail.gmail.com> (raw)
In-Reply-To: <CACRpkdbO2_fRDuuEV-aJCL7X=m7Zads=M-N_75OqBdz66YYqHA@mail.gmail.com>
On 10 January 2017 at 02:31, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Sun, Jan 8, 2017 at 10:42 PM, SF Markus Elfring
> <elfring@users.sourceforge.net> wrote:
>
>> From: Markus Elfring <elfring@users.sourceforge.net>
>> Date: Sun, 8 Jan 2017 18:44:26 +0100
>>
>> * A multiplication for the size determination of a memory allocation
>> indicated that an array data structure should be processed.
>> Thus use the corresponding function "kmalloc_array".
>>
>> This issue was detected by using the Coccinelle software.
>>
>> * Replace the specification of a data structure by a pointer dereference
>> to make the corresponding size determination a bit safer according to
>> the Linux coding style convention.
>>
>> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
>
> Chunyan has been running this test code so she might have additional
> insights to provide. I am not aware about anyone else really running the
> tests, are there people who do it?
I talked about mmc_test on #armlinux channel with a person whose
nickname was s84 other day. It seemed that s84 was also trying to use
mmc_test module.
Regards,
Chunyan
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> Yours,
> Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: Chunyan Zhang <zhang.chunyan@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: SF Markus Elfring <elfring@users.sourceforge.net>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Harjani Ritesh <riteshh@codeaurora.org>,
Jens Axboe <axboe@fb.com>, Mike Christie <mchristi@redhat.com>,
Shawn Lin <shawn.lin@rock-chips.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/8] mmc-core: Use kmalloc_array() in mmc_test_area_init()
Date: Tue, 10 Jan 2017 07:37:54 +0000 [thread overview]
Message-ID: <CAG2=9p_E6byp0PKY5FUbXgwrN6pwYAxBh40SpDXJSu_yWSBxWQ@mail.gmail.com> (raw)
In-Reply-To: <CACRpkdbO2_fRDuuEV-aJCL7X=m7Zads=M-N_75OqBdz66YYqHA@mail.gmail.com>
On 10 January 2017 at 02:31, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Sun, Jan 8, 2017 at 10:42 PM, SF Markus Elfring
> <elfring@users.sourceforge.net> wrote:
>
>> From: Markus Elfring <elfring@users.sourceforge.net>
>> Date: Sun, 8 Jan 2017 18:44:26 +0100
>>
>> * A multiplication for the size determination of a memory allocation
>> indicated that an array data structure should be processed.
>> Thus use the corresponding function "kmalloc_array".
>>
>> This issue was detected by using the Coccinelle software.
>>
>> * Replace the specification of a data structure by a pointer dereference
>> to make the corresponding size determination a bit safer according to
>> the Linux coding style convention.
>>
>> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
>
> Chunyan has been running this test code so she might have additional
> insights to provide. I am not aware about anyone else really running the
> tests, are there people who do it?
I talked about mmc_test on #armlinux channel with a person whose
nickname was s84 other day. It seemed that s84 was also trying to use
mmc_test module.
Regards,
Chunyan
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> Yours,
> Linus Walleij
next prev parent reply other threads:[~2017-01-10 7:38 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-08 21:38 [PATCH 0/8] MMC-core: Fine-tuning for some function implementations SF Markus Elfring
2017-01-08 21:38 ` SF Markus Elfring
2017-01-08 21:42 ` [PATCH 1/8] mmc-core: Use kmalloc_array() in mmc_test_area_init() SF Markus Elfring
2017-01-08 21:42 ` SF Markus Elfring
2017-01-09 18:31 ` Linus Walleij
2017-01-09 18:31 ` Linus Walleij
2017-01-10 7:37 ` Chunyan Zhang [this message]
2017-01-10 7:37 ` Chunyan Zhang
2017-01-10 8:44 ` Shawn Lin
2017-01-10 8:44 ` Shawn Lin
2017-01-11 1:59 ` Andy Shevchenko
2017-01-11 1:59 ` Andy Shevchenko
2017-01-08 21:43 ` [PATCH 2/8] mmc-core: Fix a typo in a comment line SF Markus Elfring
2017-01-08 21:43 ` SF Markus Elfring
2017-01-09 18:32 ` Linus Walleij
2017-01-09 18:32 ` Linus Walleij
2017-01-10 8:43 ` Shawn Lin
2017-01-10 8:43 ` Shawn Lin
2017-01-08 21:45 ` [PATCH 3/8] mmc-core: Use seq_puts() in mtf_testlist_show() SF Markus Elfring
2017-01-08 21:45 ` SF Markus Elfring
2017-01-09 18:33 ` Linus Walleij
2017-01-09 18:33 ` Linus Walleij
2017-01-10 8:41 ` Shawn Lin
2017-01-10 8:41 ` Shawn Lin
2017-01-08 21:46 ` [PATCH 4/8] mmc/core/mmc_test: Add some spaces for better code readability SF Markus Elfring
2017-01-08 21:46 ` SF Markus Elfring
2017-01-09 18:34 ` Linus Walleij
2017-01-09 18:34 ` Linus Walleij
2017-01-10 8:35 ` Shawn Lin
2017-01-10 8:35 ` Shawn Lin
2017-01-08 21:47 ` [PATCH 5/8] mmc/core/mmc_test: Combine substrings for 5 messages SF Markus Elfring
2017-01-08 21:47 ` SF Markus Elfring
2017-01-09 18:35 ` Linus Walleij
2017-01-09 18:35 ` Linus Walleij
2017-01-10 8:34 ` Shawn Lin
2017-01-10 8:34 ` Shawn Lin
2017-01-08 21:49 ` [PATCH 6/8] mmc/core/mmc_test: Improve a size determination in five functions SF Markus Elfring
2017-01-08 21:49 ` SF Markus Elfring
2017-01-09 18:35 ` Linus Walleij
2017-01-09 18:35 ` Linus Walleij
2017-01-10 8:31 ` Shawn Lin
2017-01-10 8:31 ` Shawn Lin
2017-01-08 21:50 ` [PATCH 7/8] mmc-core: Use kcalloc() in mmc_test_alloc_mem() SF Markus Elfring
2017-01-08 21:50 ` SF Markus Elfring
2017-01-09 18:36 ` Linus Walleij
2017-01-09 18:36 ` Linus Walleij
2017-01-10 8:28 ` Shawn Lin
2017-01-10 8:28 ` Shawn Lin
2017-01-08 21:55 ` [PATCH 8/8] mmc-core: Use kmalloc_array() in mmc_alloc_sg() SF Markus Elfring
2017-01-08 21:55 ` SF Markus Elfring
2017-01-09 18:37 ` Linus Walleij
2017-01-09 18:37 ` Linus Walleij
2017-01-10 8:27 ` Shawn Lin
2017-01-10 8:27 ` Shawn Lin
2017-01-12 12:01 ` [PATCH 0/8] MMC-core: Fine-tuning for some function implementations Ulf Hansson
2017-01-12 12:01 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAG2=9p_E6byp0PKY5FUbXgwrN6pwYAxBh40SpDXJSu_yWSBxWQ@mail.gmail.com' \
--to=zhang.chunyan@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=axboe@fb.com \
--cc=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mchristi@redhat.com \
--cc=riteshh@codeaurora.org \
--cc=shawn.lin@rock-chips.com \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.